On windows we got false negatives due to one path starting with "C:" and
the other with "c:". Use Utils::FileName which should do the right thing.
Change-Id: I7dcf8ad3f61caca7ac7c183d492ebfd57fe1b669
Reviewed-by: Cristian Adam <cristian.adam@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Previously qrc paths of QML/JS documents were not considered for
implicit imports. Only the path of the document in the file system
was considered. The QML engine, however, doesn't know the original
path at all and only uses the qrc paths for import resolution. This
created a mismatch between what the QML engine could recognize and
what the code model suggested.
Without alias directives, any files imported from a qrc file would
have to reside in the same directory as the one implicitly importing
them, so this arrangement happened to work, most of the time.
In order to support aliases we have to search the files in the same
qrc path to figure out the imports. To do that, we keep a reverse
map of qrc paths to files in the QrcParser and iterate that when
resolving imports.
Change-Id: I84baae6cbfbe96ddd5322c81494c1e4a3f473f3f
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Overlayed icons are not clearly enough visible. This was mentioned by
Diana and by several users. This change fixes that.
Change-Id: If3e767b5248c9802a1e3d255f6d314660a4efff6
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
This is the only RunControl which set another icon than
ProjectExplorer::Icons::RUN_SMALL. I assume that was a mistake.
Change-Id: I1c31909827c03b2c9b7acb0488eb269ef30c2a34
Reviewed-by: hjk <hjk@theqtcompany.com>
fce83bd9f84883f93829e6ca9eacf098b018a02d in qtbase causes a crash:
setModel creates a new selection model, which calls currentChanged,
which accesses an uninitialized member. Hence, protect the access to it.
Change-Id: I144f40aa4286f1a9edba24519a30c08ff5091f57
Reviewed-by: hjk <hjk@theqtcompany.com>
In 7de7eb6bca the behavior on Unrunnable
state was changed, probably by mistake.
AddWatcherWhileRunningCapability should allow adding watchers while
running, but it should not prevent selection when not supported and
the inferior is not running.
Another missing part was that Unrunnable was considered running,
although it shouldn't.
Change-Id: I7d27b81977a6921919327b3122a865b7ffa2d0bd
Reviewed-by: hjk <hjk@theqtcompany.com>
Getting e.g. an object's address is better than an empty value.
Change-Id: Ia78335da8b9eadeadc2e6f1757399ae604eb6610
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Generation and optimization of all icons becomes slower with each added
icon. Regex based filtering by element will save me time.
Change-Id: I0d621e6ce78968d5a04d3f595f7c5ef60c129432
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
in places where we do not need it
Change-Id: Ibf35f8144da859fffa3e0a7b6bb262284ec2292a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
removed loadResource which was left from
96e8f0bb7b.
Change-Id: Ie1b00412104735b5f3e67939c99dc6cd68d85522
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
It's only used when starting with a -debug command line and
when attaching to a running run control. No need to clutter
the normal codepaths with it.
Change-Id: Ib374c64a7f63fa79e88967573c37a5da1f415d50
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
If at all possible, we want to load a project even in the presence of
some problems in project files, so that users can still navigate it even
if it cannot be built successfully.
Change-Id: If938d43b4c02a3e90d3066e0c6820e6b63cc58d0
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This is especially useful if you work on several projects, and
therefore don't use -lastsession. Currently there's a bit of arrow key
navigation involved to get to the Sessions item, so this speeds up
users' workflows.
Change-Id: Ic77741ce88acd6e34cf7d3a253a2b3d6c9b2b514
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
It was a pure red, which is really hard to read against a dark
background. This patch makes it a pastel red; the same color as error
messages in the application output, which was implemented in f4a9eaf3.
Change-Id: If013c7215d50c3a75d62031ab19874cfb8545cad
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Keep magic guessing to a minimum.
Change-Id: I3474b4406fa047dff468e853bd6fee7c962e065d
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This change flattens the desktop device icon in the mode bar. Only for
themes which set the FlatSideBarIcons flag.
":///DESKTOP///" deduplicates to Constants::DESKTOP_DEVICE_ICON
Change-Id: Ie31d9c501db2a1e36edbfac59abdd22a4d8c6773
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
The event that triggers the hoverhandler can occur on the last position
in a textline. This position is identical to the text length.
Change-Id: Ia73685b69793fc305094db6611c95c3f03e3a8eb
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
The debugger validation was operating on wrong language data,
i.e. run unconditionally even on pure Qml projects that doesn't
require an external debugger.
Change-Id: Ic9c96d88f2014d62e8720f1e80134f561fc40bb9
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Were not shown anymore. Regression already in 3.6.
Change-Id: Id92a7655423add70864a123e16e4a3d344289612
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Pointers often don't have an address at all, or have the pointer's
address instaed of the target address.
For example:
int main()
{
char str[11] = "HelloWorld";
char *s1 = str; // s1 shows its own address
}
Change-Id: I2436578c073a00a3fec9411ef7ec82ae4e63a8b0
Reviewed-by: hjk <hjk@theqtcompany.com>
The default fallback font was arbitrary. So far this was not a big issue
because it was basically never used.
Set sensible fallback fonts on the different platforms.
Also make sure that we can see in the settings if the default fallback
font has been changed by the user, and also separate the setting for the
different font properties. Since we did not do this before, we now have
to reset the setting for all existing users, so they benefit from the
more sensible default.
Task-number: QTCREATORBUG-15887
Change-Id: I16419f54c300580d5c9a9b19722aacf790ef66fc
GPush-Base: 44820dae13
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
This change makes sure that the "UI coloring" feature respects the
original brightness of the current theme. It prevents dark themes from
getting a too light recoloring and vice versa.
Extra benefit: this allows to remove much recently introduced code.
Change-Id: Ib2c96e7ed172a4cc97520aa4b5d180cc6353c661
Reviewed-by: hjk <hjk@theqtcompany.com>
Fix a crash occurring when dropping a .js file onto the Widget Designer.
Task-number: QTCREATORBUG-15903
Change-Id: I3e952df1483c5683fa7daa3a1f2fb8ebbbc1b491
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
