Commit Graph

29 Commits

Author SHA1 Message Date
hjk
e7c6169d70 ProjectExplorer etc: More FilePath usage
Mostly for project files.

Change-Id: Icb6059f80758865e42cc9f9c092ec6782770dfd7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-06-26 16:02:23 +00:00
hjk
473a741c9f Utils: Rename FileName to FilePath
More in line with QFileInfo terminonlogy which appears to be
best-of-breed within Qt.

Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-28 12:23:26 +00:00
hjk
c1bfc5d8ec ProjectExplorer: Follow up on too-much-magic in IProjectManager
Use a ProjectManager::registerProjectType<Project>(MimeType) function,
removing cryptic IProjectManager object ownership.

Change-Id: I212cd25bd4ee757022a8cb0decb4b8de3a112d12
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-03-09 10:41:33 +00:00
hjk
e9cdc807e7 ProjectExplorer: Use a local object pool for IProjectManagers
Change-Id: I94ada96da2bf7ce4c95c0ae8f393e6303e79ff60
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-03-03 14:49:49 +00:00
hjk
3f5caf4cdc Utils: Wrap MimeDatabase into static functions
To avoid repeating the 'MimeDatabase mdb; mdb.something(); ' mantra
all over the place.

Change-Id: I4bfef62e73275a991455141671d6071162788e9d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-03-03 07:57:54 +00:00
hjk
50d1690854 ProjectManager: Centralize "File not found handling"
That's the only error that was ever checked for, in all nine
project manager. In the hypothetical case that we'll need something
else than the name of a file to identify a "project file", we'd
probably need to touch the signature anyway. Until then, remove
the duplication.

Change-Id: Iba00b8f71309a908e2d29c0a58c50b685eca0cae
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-02-28 16:14:35 +00:00
Tobias Hunger
25fbcca96b KitManager: Get rid of KitMatcher class
Use std::function instead. Clean up API while at it.

Change-Id: I6e401ab57f5375e36710c30508c596af3f4b3385
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-01-18 10:39:16 +00:00
Tim Jenssen
f061c8a53a Utils: Initialize all members of ShellCommandPage
Change-Id: I6f6d06f4e6be8b6a8c3b5f7c4b2072660b099699
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2016-12-05 19:04:02 +00:00
Tobias Hunger
b31c408c87 ProjectExplorer: Check before setting errorMessage
Change-Id: Ic9437c3527f4f26bf72c5f7d18fdbde1217f4dd4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2016-12-05 18:41:55 +00:00
Tobias Hunger
95ac4edfd4 Projectexplorer: Modernize codebase
Change-Id: I4793b58aa77bcd46af99f8b843c0f7439cdc9269
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
2016-04-15 09:40:53 +00:00
Tobias Hunger
397e7f4843 Update License according to agreement with Free Qt Foundation
* Update files in src/plugins

Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-19 15:57:01 +00:00
Tobias Hunger
71b4ce6673 Qt: Remove platformName and platformDisplayName methods
Fix fallout of this in KitInformation/Kit/KitManager and the wizards.

Change-Id: I5cb88cc381dc04409401909b810940ab6dccf86a
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
2015-12-02 14:49:29 +00:00
Tobias Hunger
eebe44d3cf Wizards: Turn "platform" into an Id
It used to be a string constant.

Change-Id: Ibea34dc52e97a483989e6d628b908231f4e2dc54
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
2015-12-02 14:49:20 +00:00
Tobias Hunger
4b0a8648e4 FeatureProvider: Remove Feature and FeatureSet
Use Core::Id for Feature and QSet<Core::Id> for FeatureSet.

Change-Id: I12341036bd9eaa82589d92bd3f7d21f2e6b737bd
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
2015-12-02 14:49:17 +00:00
Orgad Shaneh
3389e5f969 ProjectExplorer: Do not resolve symlinks when opening a project
Task-number: QTCREATORBUG-15145
Change-Id: I71ec43fa8cb0073100c988b6aa8a8a59a254af0c
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-10-14 11:58:46 +00:00
Tobias Hunger
040a0f2d30 JsonWizard: Allow for variables in features passed to KitsPage
Change-Id: I8c0d6b8b6e46d2de7cd4b088c7c98c2efe57427f
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-06-25 14:12:20 +00:00
Tobias Hunger
0511721313 Core: Make Id and Feature more separate
Remove Id from the public interfaces of Feature and FeatureSet and
disallow implicit conversions from Id to Feature.

Change-Id: I33ba692ce82552f0c2b867c6c57b9c8547264243
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-06-25 13:01:57 +00:00
Tobias Hunger
695b752b57 JsonWizard: Explicitly set required/preferred features on kits page
Do not use the required/preferred features from the wizard in the
kits page. The wizard's features are used to decide which wizards
will be shown (together with the enabled key). The kits page has
a separate set of features that are used to decide on the Kits
shown.

Keep these settings separate, as they are different things.

If nothing is set at the Kits page, then the wizard's values
will be copied. This is to stay compatible with existing
JSON wizards.

Change-Id: I2f8e3ccc46ce92f5be89aecaf52e5a81e4b29e83
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-06-17 11:27:51 +00:00
Tobias Hunger
35aafdcdd9 JsonWizard: Add a polish phase
Add a signal/method to polish the generated files: This phase happens after all files
are written to disk and are ready. It is intended for tasks not directly related to
the project setup: E.g. generation of config files, etc.

Use this to generate our config files.

Change-Id: I9bb5d296bec19f163b70c5ec8d43d5b8e3a52d79
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2015-04-23 15:51:33 +00:00
Tobias Hunger
e5d8dbd070 Json Wizard: Do not write .user files for subprojects
Delay till subprojects are handled and only create .user files for
those projects that are not a subproject.

Change-Id: I606acbce5a9a8ca7c033f94869e796edd88d6c1e
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2015-04-20 12:44:36 +00:00
Eike Ziller
5a3a940ad3 Use new mime database
Change-Id: I4305872b6b11ef3e8a364280ffa5209a5a793600
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-02-17 13:00:07 +00:00
Eike Ziller
3c85058694 Update License
Change-Id: I711d5fb475ef814a1dc9d2822740e827f3f67125
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
2015-01-16 12:37:56 +01:00
hjk
cb30a1ae10 ProjectExplorer: Compile fix after 78f1b24c
Change-Id: I6e106d4ae20b0c26acbb1f2257c59dea0498f623
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2014-11-21 18:01:56 +01:00
Tobias Hunger
fa223ab65b JsonWizard: Add separate method to get stringified values
Have value(...) return a QVariant that is never mangeled and add
a stringValue(...) method to retrieve stringified values. It is
way easier to see who needs what now.

Use this consistently in the JsonWizard and fix one place where
a QVariant was expected but a stringified version was returned.

Task-number: QTCREATORBUG-13486
Change-Id: I2c4e9188280940e529f0f60bcc18b9b7330865d1
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2014-11-21 17:25:12 +01:00
Tobias Hunger
78f1b24cd4 JsonKitsPage: Clarify unexpanded/expanded project path
Change-Id: I62a04582d29b122f6210b3bcef0d3e5e26d5286e
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2014-11-21 17:25:07 +01:00
Kai Koehne
2c8bc2700e Fix license headers
Change-Id: I810aa2d98c96040fd536ae0711041f301e5c22d7
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2014-11-20 16:58:22 +01:00
Tobias Hunger
4fefe0c202 JsonWizard: Code cleanup
Make sure project is 0, clang reports a free after use otherwise.

Clean up the code a bit.

Change-Id: Ie21cc83c589fdc5eed197bd3f005b309c000cc0d
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
2014-11-20 16:16:35 +01:00
Orgad Shaneh
6c139bd62b Fix compilation
Change-Id: I298f5d655f69597920994d8d5efc1b67f1bd72bf
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-10-23 18:43:07 +02:00
Tobias Hunger
3cb4f6dbf3 JsonWizard: Make TargetSetupPage available to JsonWizards
Change-Id: I59cf128635c28f5cbc45336bef82f63ee5da4e6c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
2014-10-23 17:05:19 +02:00