Commit Graph

84931 Commits

Author SHA1 Message Date
hjk
11d5fbe04c ImageViewer: Move Viewer class definition to .cpp
And de-pimpl.

Change-Id: I2c4acc95a7d583b4bfbc98bee3c989425d9306c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 07:24:28 +00:00
hjk
8aa78b119a Fossil: Move plugin class definition to .cpp
And split out the tests into a separate class.

Change-Id: I908c4cec5d6a69850867cf2e51c050c8dd356a26
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-11-20 07:24:12 +00:00
Eike Ziller
fd256b57de German translation: IncrediBuild
Change-Id: I9b801fe83b681551b123ce167a34ec44249a8bd6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-11-20 07:15:52 +00:00
hjk
d924d4e886 Fossil: Delay-create FossilClient
By three liens, the connect in the pluginprivate ctor
will create it.

Change-Id: I23c80884f293fae434de573b8684bde2c56bd45e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-11-20 07:13:39 +00:00
Eike Ziller
8116aaaab8 Fix missing wizard after loading CompilerExplorer without restart
Wizards should be reloaded after plugins are loaded. They might either
add wizard paths, or wizards that check for plugins might be loaded even
though they were not loaded before.
Emit PluginManager::pluginsChanged when plugins are loaded at runtime
too, and connect that to clearing the list of wizard factories.

Change-Id: I79e0fb4991074cba592296620f1758136d60b378
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-20 07:12:10 +00:00
Eike Ziller
b60fd77fc1 Fix clearing the list of wizard factories
Clearing the list of wizard factories did not result in updating the
available JSON wizards. The JSON wizard paths were scanned only once at
startup. Instead partially revert back to before
1cf6b031cf and let the JSON "factory
creator" parse the directories and return a list of wizard factories.

Change-Id: Ifc253479973be801c5323588800bb264610187b6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-20 07:12:00 +00:00
Eike Ziller
4362318c14 WizardFactory: Early return in clearWizardFactories
Detect early if there is nothing to do

Change-Id: Ic2c27c2d265cbc245d383531ad7d844457ea8121
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-20 07:11:46 +00:00
hjk
34f374baec Todo: Move TodoPlugin class definition to .cpp
Change-Id: I5b82b14bf86655f0dab9379effb4ff156900b610
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 07:07:02 +00:00
Christian Stenger
9b429c7ebd ImageViewer: Fix build
Remove now superfluous moc include.

Change-Id: Id0d0a4110e4be9206bd09a4795ebc63b7b443221
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-20 06:37:50 +00:00
Jarek Kobus
c8541962a6 DeviceShell: Get rid of unused variable
Change-Id: I8f93364b347460b1daef1149d3ff5c28436b0754
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-20 06:31:25 +00:00
Cristian Adam
48a3a12b01 CMakePM: Add failure logging for add|rename|removeFiles
Task-number: QTCREATORBUG-29914
Change-Id: I404a3efb8cabafba6036eb1bc07d19f18af17cd8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-17 21:09:31 +00:00
Alessandro Portale
8798ed1ace ProjectExplorer: Fix sorting of file names in subpaths in wizard summary
In the wizard summary page, on Windows, the sorting of files in sub
directories is not correct. The paths got converted to userOutput before
they were tested for '/' and then assigned to a FilePath (which caused a
QTC_CHEK warning in addition).

This is reproducible with the "QDS compatible" Qt Quick application
wizard.

Fixes: QTCREATORBUG-29921
Change-Id: I45b623409831b21467e33481dcc3ca557f0f9afc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-17 20:08:38 +00:00
Jarek Kobus
9d44d1899d TaskTree: Fix Timeout activation
The activation of one timeout may cancel the other running
timeout. Don't remove all timeouts which are to be activated before
the activation loop. Remove and activate incrementally instead.

Change-Id: I6147fb63b6ef9d6ada034330d98d1c13419012b4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-17 17:09:25 +00:00
Jarek Kobus
73bff6d497 TaskTree: Fix TimeoutTask ordering
Make ordering separate for each thread.
Add stress test for it.

Change-Id: Idb42ce2511b18c0e9dd4dcb216ca39b35b5c980e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-17 17:09:19 +00:00
hjk
43f1281674 Qnx: Use new setup scheme for most factories
Change-Id: Ie6154d816fb9d77948d73416b43bb933a56f6bbb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 17:08:35 +00:00
hjk
65dbc1eaf6 ImageViewer: Use new plugin setup system
Change-Id: Ie2178c6b38a0b122ab225bae30ea25e1c57b73ad
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:53:21 +00:00
hjk
3b05a6f58e FakeVim: Merge Plugin and PluginPrivate classes
There were different from the PluginPrivate-created-in-initialize
pattern anyway.

Change-Id: I690c9c0511203f3c4d6ec9eeca85c0a277330e2f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:48:46 +00:00
hjk
bde92e035e FakeVim: Move plugin class definition to .cpp
Change-Id: Iac485bbd6cd00ddfae189a6f82c9f5f2c7e9aaf9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 16:47:38 +00:00
hjk
d1aaebc3b4 FakeVim: Move test declaration from plugin to separate object
Also ugly, but differently.

Change-Id: I832ac19c7d8a3457a40baaae60653a02a32dbd75
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-17 16:36:19 +00:00
hjk
15e499df06 BareMetal: Dissolve baremetalplugin.h
Split test so they can be closer to the implementation,
move rest to plugin.cpp.

Change-Id: I30310f5b2658ac669d219c2978c6a3d6c9d8b107
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 13:09:30 +00:00
hjk
c4c561556d BareMetal: Move DebugServerProviderManager closer to new setup system
Change-Id: Ic8029b0436d4c0e86e0f707632139a2074b296eb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 13:08:40 +00:00
hjk
7c7abec04f BareMetal: Use new setup scheme for various factories
Change-Id: I62f17efb8241acbfa954c07b0fa6f088990be7a2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 12:59:51 +00:00
hjk
fc1325d6c9 BareMetal: Use new setup approach for toolchain factories
Change-Id: Ic91ccab925f054d80fbfa8bc018b3e86d207b186
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-11-17 12:59:40 +00:00
Christian Stenger
4101260f41 Utils: Update mime type for linguist files
Use new mimetype used inside freedesktop's definition. The old one is
still used internally as alias.

Change-Id: If8405c109a1bfb326db84f480d35bc62625358a3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-17 12:56:15 +00:00
Christian Stenger
f06b821f58 AutoTest: Fix handling of critical messages
Fixes handling of qCritical() messages or similar and
silences a soft assert.

Change-Id: I74f485ffd75b65170c2c9752bd774401c0f19734
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 12:55:43 +00:00
Christian Kandeler
d05d6f2469 Update qbs submodule to HEAD of 2.2 branch
Change-Id: I56bfc87909d6b73b90243371c30138be9fcff6ca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-17 12:35:54 +00:00
Jarek Kobus
07f5c7638d TaskTree: Hide more API of GroupItem into protected section
Rename TaskXxxHandlers into InterfaceXxxHandlers.
Rename CustomTask::[Setup/Done]Function into Task[Setup/Done]Handler
to conform with Group[Setup/Done]Handler.
Fix the CustomTask::TaskSetupHandler type.

Change-Id: I0c69fc75622eb8324278f713db22a6de314d44ef
Reviewed-by: hjk <hjk@qt.io>
2023-11-17 11:35:23 +00:00
Jarek Kobus
ea5195afff Translations: Update Polish translations
Change-Id: Ibd4f5736eceed9c2eee4f8e4b6efa17d4b33e539
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Patryk Stachniak <patryk.stachniak@scythe-studio.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
2023-11-17 11:27:02 +00:00
Jarek Kobus
20752a7811 Translations: Clean update of Polish ts file
Change-Id: Id4ec2377443b8fe42fa51f38c63a7a6c3bd6e6ee
Reviewed-by: Patryk Stachniak <patryk.stachniak@scythe-studio.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-17 11:26:52 +00:00
Christian Kandeler
89d9a481e2 Revert "QmlProject: Fix crash"
This reverts commit 4d55d6be18,
which broke all project loading.
The crash was properly fixed elsewhere.

Change-Id: I49f42dce1d7f69d6a1c3c769dc6a1399f26650d5
Reviewed-by: hjk <hjk@qt.io>
2023-11-17 11:26:40 +00:00
Alessandro Portale
1da84754db Utils: Align enum StyleHelper::UiElement with upcoming design system #3
The Qt Creator Design System defines display headings H1 and H2 with a
"Titillium  Web" font face.

This change introduces the "Titillium Web" based as new H1 and H2 and
lets the WelcomeScreen code obtain them via StyleHelper::UiFont(). It is
supposed to not change the visual appearance.

Change-Id: Ia2c5ac14858e574c4ffd31af1ed80ac1781cd970
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-17 10:43:06 +00:00
Alessandro Portale
b3acdae338 Utils: Align enum StyleHelper::UiElement with upcoming design system #2
This change "PanelTitle" to "Caption". It is supposed to not change the
visual appearance.

Change-Id: I3342e6c80d8ce11b7ab1ac40b4395c265e1e07ec
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-17 10:43:00 +00:00
Alessandro Portale
7f60ce0666 Utils: Align enum StyleHelper::UiElement with upcoming design system #1
This change demotes the existing H1 and H2 to H3 and H4. It is supposed
to not change the visual appearance.

Change-Id: Idc3056307f0286a2d4d276ba79125ba93d5ac428
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-17 10:42:53 +00:00
Alessandro Portale
aa83b0ce65 ProjectExplorer: Make CodeStyleSettingsWidget expanding
This encourages the code style project settings panel to take the
abundant vertical space.

Change-Id: Ia14c4e3246a0ab4099850b3013e4ea915a7e1433
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 10:21:42 +00:00
Christian Kandeler
5baf4d83c6 TextEditor: Remove now-unused RefactoringChangesData
Change-Id: Idf82ce013f19422d2b5931669e1aaa4a3aa64b16
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 10:02:01 +00:00
Christian Kandeler
246a878a34 TextEditor: Remove RefactoringChanges::m_data
There is no use for a data member in the base class.

Change-Id: I126d8713d2a7bf4061ecbd60b4c144d39c08d550
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 10:01:48 +00:00
Christian Kandeler
5d6fc1fc3b TextEditor: Remove RefactoringFile::m_data
There is no use for a generic data member.

Change-Id: Iabfbc0587db2cffcc1c19baed832aa866f696ffe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 10:01:34 +00:00
Jarek Kobus
1c8ac2e7d3 TaskTree docs: Update docs about TaskInterface::done()'s arg
Now it's DoneResult, instead of bool.

Change-Id: Ia6eab42b08774d6b51f2bf4435ac083946f5d53d
Reviewed-by: hjk <hjk@qt.io>
2023-11-17 09:44:31 +00:00
Jarek Kobus
659f0f000c TaskTree: Unify TaskInterface::done(DoneResult) signal
Change the argument of TaskInterface::done() signal
from bool into DoneResult. Make it consistent with
other TaskTree API.

Introduce toDoneResult(bool success) helper.

Change-Id: I7b3041d7c1ed0317c76adbc1fd37448231e85f82
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-11-17 09:44:20 +00:00
Christian Kandeler
6f3bc431fc TextEditor: Move more code into RefactoringFile
We want to get rid of RefactoringChangesData.

Change-Id: Ia428563a0ff70ec9660761beac3eb7168b8e9eca
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-17 09:43:02 +00:00
hjk
4c0abb6d2c ExtensionSystem: Make IPlugin::addTest* public
This allows somewhat easier test setup by defining test classes
nearer to the tested code.

Change-Id: I7c300a442c9433355d97742b17b394a6d2352270
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-17 09:02:56 +00:00
Christian Kandeler
413a6a6fde TextEditor: Make RefactoringChanges::file() virtual
More preparation for de-virtualization of RefactoringChangesData.

Change-Id: Ib5f7782a8dcaa2ae093b62aebedbd7bae9d4c3f1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-17 08:37:14 +00:00
Christian Kandeler
156569fcc7 TextEditor: Move code from RefactoringChanges to RefactoringFile
Preparation for de-polymorphisation of RefactoringChangesData.

Change-Id: Ia2a8f8e2a3a403f809e67c907d3474e7c1a52417
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-17 08:31:45 +00:00
Eike Ziller
d652d7bfbd Change log: Switch documentation links to stable documentation
Change-Id: Ifd1c17808787182668ef0c1d35f33b89860aa8d9
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-11-17 08:22:56 +00:00
Eike Ziller
583a9dcea1 Add Line/Column indicator to Markdown editor
And make the LineColumnButton independent of IEditor for that (since the
IEditor for the Markdown editor is not a TextEditor.

Change-Id: I52d378ec46d86b1c7928d18f7d39f9726bb6ad23
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-17 08:15:43 +00:00
David Schulz
fbf8b4d3c3 Copilot: fix applying copilot suggestions word by word
via the ctrl+right shortcut

Change-Id: I1a9460a456833c7ddd35a42a63eaf75b8e2930b3
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-11-17 06:48:39 +00:00
David Schulz
cff26d813a Clangd: Avoid client restart after modifying open documents
Change-Id: I116eed1b047159e3d1ce64f18f44da6a0ad7b231
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-17 05:38:13 +00:00
Alessandro Portale
a810995aae Vcpkg: Enable soft loading of the plugin
Change-Id: Iddca570d1f29e51221a3958d6fa246beb00d8168
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-16 18:03:05 +00:00
hjk
43e4c7913f ClangCodeModel: Use ActionBuilder
Change-Id: I40cd7fc9eb346b0b70ea24f980846d175cfde3d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-16 17:04:45 +00:00
Cristian Adam
7affb80fc3 CMakePM: Do not show source/group/path twice
For the cases of:
  source_group(TREE ${CMAKE_SOURCE_DIR} FILES my/subdir/file.cpp)

Treat the "my\\subdir" part in the project view as part of the source
group name.

Fixes: QTCREATORBUG-29799
Change-Id: I92bf581be25d085783bcdadd8a418b849a29c708
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-11-16 16:39:38 +00:00