Detected by GCC8.
messageenvelop.h:83: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
out << static_cast<const quint8>(messageEnvelop.messageType_);
^
Change-Id: I46ee5fb45b6ebc3c75475faa16cba66243a38fb3
Reviewed-by: hjk <hjk@qt.io>
The patch is mostly mechanical, but contains also a few spurious changes
from values references for some local variables, foreach -> ranged for
etc that I coulnd't resist.
Change-Id: I58f0bd972546895eb318607cbfbd7ac35caf3f23
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This partially reverts 6e419d642a as the restriction is not need.
QNX + CMake is working fine.
Change-Id: I430c6e8c25f8975201892759abb20a52cb04e4a4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
No need to have half a dozen lines of code in a separate translation
unit.
Change-Id: I7b611f3404d3db4a1f731b4bfa79bd560a2bf9f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Setting up the qbs run environment is not free, and the respective code
gets triggered from other plugins much more often than expected.
Task-number: QTCREATORBUG-20175
Change-Id: I6529718d20738140963486caef103d6d17958d50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Purely mechanical, no visible/functional changes intended or expected.
- have one file pair for each set of config/factory/widget
- de-pimpl BareMetalRunConfigWidget, it's very local now
- use new wrapWidget convenience function for run config widget setup
Change-Id: Icd0df2bc7e206d6bf15d722f7eaa3b9fbee0b0fa
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
... in preparation of upcoming OutputFormatter creation reorganization.
Also, replace a raw string literal by a normal one to accommodate moc
and remove an unused member.
Change-Id: I416bb20afd891717fcb4f449955b4e46e5c05590
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
...to be able to parse type_traits of libstdc++ 7 without errors.
Task-number: QTCREATORBUG-18757
Change-Id: Ib76e233e77a58a9fb6761c733057dcc1d6c42ead
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Register code/name combinations together.
Also make the otherwise implicitly preferred first entry
explicit in the API.
Change-Id: I80f68b01d53e2672480365d4efcb9d790b8363fd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Double clicking an item will now rebuild the flame graph with that item
as root. Double clicking on an empty area will reset the root.
Change-Id: I16dd4b00d0dd09ff922a01acee67f0d553da6323
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
It should not make a difference if an item is created in a state.
Change-Id: I788cb2aec758a42418a5939c2430074803a662db
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Use new ExecutableAspect, simplify working directory and
'use terminal' access.
Change-Id: I1daca3a30a4a46f3e1ad0019a49d28279cbc885f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
canHandle() is only used locally in the implementation, so
make it private and de-virtualize.
canCreateHelper() did nothing except returning true anymore,
so remove it.
Change-Id: Ifac39e077e3c296b2b2dfc9fbb29c20884e056a3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The Qt Quick Designer synthesized a few theme colors from existing theme
colors. That was in order to prevent the need for 6 theme colors being
defined in every theme. It turned out, however, that being able to
define these if favorable.
Todo in follow-up commit: remove QmlDesigner::Theme::qmlDesigner...()
functions, and fix up the qml, accordingly.
Change-Id: Ica85df5472cd7b9da8bf215eb6dbdcf608a4fb2d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Creating a new ReadingContext is an expensive operation as it creates
and call a Link object. This operation is needed only when the document
is actually changed, in all the other cases it is not needed.
Change-Id: Ia368122d60d2c7de86d10e169dd7f20a19f01115
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
While the user is editing text in the text editor
we disable the input widgets.
This ensures that the rewriter is not confused by the
manual editing and also there is no guarantee that the
QML code is syntacially correct.
We also disable the toolbar.
Change-Id: If062b49f834e901a933a9b1f67582ee9be6232bc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Exceptions in the merger are very rare but not impossible.
Therefore we have to catch potential exceptions.
Change-Id: I83b2e9e41aa7b21374c06e2401c13df984fe0fd5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
On Linux destructing the local sockets leads to commands being
dispatched synchronously. This is not expected and totally unrequired.
When we shutdown the instance server no commands have to be dispatched
anymore.
Change-Id: Ieeca7ac2103e7b463137d76f85cd326888cc38ce
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Everything that is in or below a designer folder with a *.metainfo file
is not supposed to show up in the resource browser.
The code is written very defensive way and we check a maximum
of 3 directories above the current file.
Change-Id: I14b3ae8a7e47208e15e9adfc1696c531a8589231
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Output panes must be created before handling the settings
which of the panes to display.
Change-Id: I0c391f4c56c517d5a9626735006d741f64cf161f
Reviewed-by: hjk <hjk@qt.io>
The reformatter used to remove the quotes that wraps the property name
in object literals. This causes problem when the name is not a
valid identifier, resulting in that valid code become invalid after
reformatting.
This patch forces wrapping of property's name in quotes: in this way,
the reformatted code is consistent and it never get invalidated.
However the resulting formatted code is not consisted with the one
formatted by previous versions.
Task-number: QTCREATORBUG-17455
Change-Id: I1e361102819055de210d6c81020f204c08aaa253
Reviewed-by: Markus Maier <markus.maier.sw@gmail.com>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Otherwise compile fails with
constexpr constructor does not have empty body.
Broke with 2f8c075a01.
Change-Id: I04ce03eaf51ddb3b4233abc4b51a553355e28e04
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Easier to keep one variable in sync than three, and moves
the code closer towards a unified pattern in the local
runconfigurations.
Change-Id: I2df09127d476be4ddab466f8a709a2b383a76b97
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
So we don't recompile them again and again.
Change-Id: I54c95e9d81df86f4944b9e3d45a7277f93f37312
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
If we get this any hope is lost any way but we now know why. ;-)
Change-Id: Ic08b104825dc51ce5453203e70a0804265e47330
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
We really want to delete the right copy and move constructor.
Change-Id: I9572c197b1be89fc1ce996d65e2de671f48abb4e
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
It can be happen that the entry is written by an other connection after
we tried to read and before we write. This would lead to a double entry
which be prevented by the unique index in the database. In that case we
simply try again and read the id from the database.
Change-Id: I6c9d94e95ae11556bb446813f64be0855be4ddbe
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
It can be happen if different connections try to write and read at the
same time.
Change-Id: I30e9120fdb8f6963f5440eed48e2cfdf8803b2be
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
You use now a busy timeout of one second. This is preventing the throwing
of a exception for a busy time under one second.
Change-Id: Iae800a525ad009b594c29883ffb243c1be8b3874
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This can be always happen for write statements. It fixes the wrong behavior
of the transaction that it tried to rollback if begin fails. If begin fails
the transaction never started so there is nothing to rollback.
Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
We now distinguish between the the top external headers which are used for
the PCH and all external includes which are used for watching. Adding
indirect external includes can lead to errors because some are not
protected by a header guard.
Change-Id: I01576fcf1ad25e7a6e3efc252eabbd23d5c0e727
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This is providing more security that there will be no double entries in
the database. Instead you will get an exception if you try to corrupt the
database.
Change-Id: I162dc8ddd270b86afdf12ba4d55686637b2c09ef
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
