Commit Graph

12 Commits

Author SHA1 Message Date
Marcus Tillmanns
02d7e59a2e Terminal: Fix Id
m_commandLine is not useful to distinguish terminals
as it may contain wrapper scripts with temporary arguments that make each invocation of a target
spawn a new terminal window.

Instead use the provided "shell name".

Also make sure to use the actual target name as the
shell name in runcontrol.

Fixes: QTCREATORBUG-32197
Change-Id: I8c0760be375d559391dbd831080aa7153786f411
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2025-01-09 08:27:06 +00:00
Marcus Tillmanns
f28fe261f4 Terminal: Fix Terminal reuse key
Use the full command line to determine the Terminals
reuse key, as the executable may be a helper tool like "disclaim"
on macOS

Fixes: QTCREATORBUG-32197
Change-Id: I9d6cba4963fce5e2c4b2506577346446a564d5fc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2025-01-07 11:56:13 +00:00
hjk
da0cfadb20 Remove a few unneded #include <QTemporaryFile>
Change-Id: I3bb102a9ac50b69ee84dd4486dcb8d4bffaeff56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-09-27 12:19:34 +00:00
Orgad Shaneh
ce082bb09f Terminal: Simplify OpenTerminalParameters construction
Change-Id: I4dcc2146f227e4a408c88de62f7594953c8ccb66
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-03 13:30:43 +00:00
Marcus Tillmanns
79dd731d87 Utils: Add Extra Data to Terminal process
Allows a terminal to display the "correct" program name.

Fixes: QTCREATORBUG-29281
Change-Id: I73dacf71078dd1407ddda7bbc33a93c5ad172cbf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-06-14 13:51:49 +00:00
Marcus Tillmanns
06365fa39f Terminal: External terminal if blocked by modal
Change-Id: I89ba438c7a9f4d593e849b9b7ca2daf202cca625
Reviewed-by: hjk <hjk@qt.io>
2023-05-25 09:24:36 +00:00
Marcus Tillmanns
0c8ae843c6 Terminal: Switch Mode to ensure visible
Change-Id: I6d92ac07b7f6e7d5ed3fa4d27531d1cb8ec1a36f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-12 06:41:13 +00:00
Marcus Tillmanns
c0f0ccdc78 Terminal: Ensure terminal is visible
When restarting an app, make sure the terminal is visible and focused.

Change-Id: I305eb59ddf2f5e0f2844d47e51500953c3145c38
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-09 11:20:49 +00:00
Marcus Tillmanns
6aa02fe804 Utils: Combine startStubProcess parameters
Change-Id: Ic0515a3864687494bd1e280a82b91a5bafef46b1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-08 06:24:00 +00:00
Marcus Tillmanns
e6081aaa0a Utils: Add TerminalMode::Detached
Change-Id: Ic36845d3469719e17f24602ce80f3e6cfc984fbf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-04 10:43:36 +00:00
Marcus Tillmanns
80fa3339e0 Utils: Re-add "press enter to continue" to stub
To keep the terminal from closing immediately, ask the user
to press enter after the inferior exited.

Make it configurable as the terminal plugin does not need
this.

Change-Id: I1949895f022a54539a6139be9f92fdc698f6534e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-03-21 13:50:18 +00:00
Marcus Tillmanns
0870f2583b Terminal: Enable TerminalProcessInterface
Adds a new helper app "process_stub" that replaces the previous.
"process_stub_unix/win". The purpose was and is to allow processes
to be "injected" into other hosts apps like terminals while still
being able to control and debug them.

A new base class called "TerminalInterface" is used for both the new
Terminal plugin and the legacy TerminalProcess implementation.

Fixes: QTCREATORBUG-16364
Change-Id: If21273fe53ad545d1a768c17c83db4bf2fd85395
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-03-20 10:03:23 +00:00