Commit Graph

68765 Commits

Author SHA1 Message Date
Shrief Gabr
f5cb1530a4 QmlDesigner: Add context menu to the cell
Task-number: QDS-11253
Change-Id: I4b93feb867d0d78d9e9b473c9dd6a645c031ccaf
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-16 14:09:12 +00:00
Ali Kianian
63f98ec9e4 QmlDesigner: Keep the order of columns in CollectionEditor
Fixes: QDS-11508
Change-Id: Ic75f86207149469ed4b08605db9feb10c4e1141d
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-16 13:43:34 +00:00
Ali Kianian
cb868a4c9e QmlDesigner: Set texRole when assigning a collection to a node
Task-number: QDS-11461
Change-Id: Ia03c8267cc6f6b93860aa853afb048650f1acb3f
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-16 13:43:20 +00:00
Ali Kianian
daf23602fe QmlDesigner: Use ColorEditor as view delegate in CollectionEditor
Use StudioControls.ColorEditor as a view delegate for the
CollectionDetailsView

Task-number: QDS-11114
Change-Id: Ic91d734c4fc62ddb51c4db7029714d409d51b732
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-16 09:23:39 +00:00
Mahmoud Badri
7dd789fab4 EffectMaker: Enable effect animation by default
Fixes: QDS-11609
Change-Id: I143a91cbc6c16f9e2a613e2cf56199820d40dd66
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-15 16:02:16 +00:00
Henning Gruendl
ae28fb67b5 QmlDesigner: Fix all changed signals get skipped
Fix "positionChanged" signal getting skipped when creating the list of
potential signal connections.

Task-number: QDS-11625
Change-Id: Ic0e3e7170044c635e83bc22ac1fc82c92102f584
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-15 15:23:35 +00:00
Henning Gruendl
afdf82a6c1 QmlDesigner: Add "on" to signal handler
Fix missing "on" for signal handlers generated via the context menu.

Task-number: QDS-11626
Change-Id: Ide32bfdddf4ee16e650e0adac9fbb3fda9694f3b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-15 15:23:13 +00:00
Karim Abdelrahman
94125f9416 QmlDesigner: Disable MCU unsupported workspace and views
This patch disable unsupported 3D workspace and some views
from view menu and toolbar combobox

Task-number: QDS-10336
Change-Id: Ic97baead8029a93ae95707b9349f81f02adb6335
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-15 12:43:38 +00:00
Ali Kianian
194a34a8f1 QmlDesigner: Move CollectionEditor functions to utils
- Collection editor functions are moved to CollectionEditorUtils
  namespace
- Collection import tools functions are also moved to
  CollectionEditorUtils. Also, the former files of import tools are
  deleted since their functions are moved.

Task-number: QDS-11391
Change-Id: I1ec1b2b7568658c1637a4c267989425189f07039
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-12 14:51:07 +00:00
Shrief Gabr
191db5c9ae QmlDesigner: Fix data loss after saving collections
Task-number: QDS-11582
Change-Id: I69fbfbcebd880a4df1597bde25aac8372950cdfb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-12 12:11:54 +00:00
Ali Kianian
208fa8f3e7 QmlDesigner: Select columns by left click on Model Editor
* HelperWidgets.ToolTip is replaced by ToolTip in order to prevent
mouse are conflict
* The content of the tooltip is updated by activation
* CollectionDetailsModel notifies changes on column type

Fixes: QDS-11591
Change-Id: I0b5e42b7a8656e3119f7ac60f6be78d6ca46e055
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-12 11:22:08 +00:00
Ali Kianian
63f8ecd003 QmlDesigner: Read DataStore.qml before writing properties
The properties of DataStore.qml are read, So the property-name for
a collection name will not be changed if it's not like the
Collection-name.
* Unique names will be created only when a user adds a collection.
* Renaming a collection shouldn't affect the related property-name
of DataStore.

Fixes: QDS-11540
Change-Id: I797a29c116051f79cfa6680360e5b086154a1df6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-09 08:32:08 +00:00
Thomas Hartmann
6fcb853b19 QmlDesigner: Add QTC_ASSERTS
This can prevent crashes, but is unexpected behaivour.

Change-Id: Ie0944652c230a25e18f5d740cf134bc3ef7e2f2f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-08 15:35:18 +00:00
Tim Jenssen
10ba9b63a5 StudioWelcome: do not crash if StudioWelcome can not be loaded
Change-Id: Ifc543842d85598cf8b8be16478ff9d66aa4d0592
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-05 15:22:48 +00:00
Thomas Hartmann
81421c2c8e QmlDesigner: Do not warn about attached properties
Change-Id: I2a59f5133d1542766bcd82551c998d5cf4d38d56
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-05 12:41:53 +00:00
Thomas Hartmann
87df3f1307 QmlDesigner: Catch exception when refactoring id
Task-number: QDS-11576
Change-Id: I1081be20e0885fc460852e1d51cb7e85cab73a99
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-05 07:18:21 +00:00
Shrief Gabr
9ca5b7fea2 QmlDesigner: Fix cells' unpredictable yellow outlines
Task-number: QDS-11573
Change-Id: I00a57e39804e54ce2fc25f4430975267c61a953a
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-22 13:24:59 +00:00
Ali Kianian
6e75d21f84 QmlDesigner: Fix lambda unique connections for CollectionSourceModel
Fixes: QDS-11572
Change-Id: I25f3cbd8b6f806c347102ddea3855c23b30bf8f9
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-21 14:16:50 +00:00
Tim Jenssen
238bc38f88 QmlDesigner: QDir -> FilePath to get a saver removeRecursively
Change-Id: I89bf782e8e6e119de44ee4540e8d2ab7dbef738c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-21 12:14:25 +00:00
Tim Jenssen
506ff2eea7 Utils: add more removeRecursively checks
Change-Id: I0b8bbe99132157cc5a73355c9b396201ec259aaa
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-21 12:13:15 +00:00
Miikka Heikkinen
c046dc42c1 QmlDesigner: Always render items with effects
Items with effects may lose their cached layers if they are not
rendered every frame, so make sure we always render items with effects
if anything else is rendered.

Fixes: QDS-11561
Change-Id: I7aa6542fc619e634fa06fe7c8d59fd485a150296
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-21 12:03:07 +00:00
Thomas Hartmann
8738057967 QmlDesigner: Do not scatter pasted nodes anymore
Scattering/moving pasted nodes does more harm than good.

Task-number: QDS-10972
Change-Id: I625cf228fb688c48715152eb6471728ca7202a23
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-12-21 07:43:06 +00:00
Jarek Kobus
e436bf47fe EasingCurveDialog: Avoid using sender()
Amends a0e551a1e8

Change-Id: I2178d4417214c77a104c0d0840f1de6f460fadb5
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-19 15:49:08 +00:00
Jarek Kobus
77aeba3c88 FileDownloader: Avoid using sender()
Change-Id: Ifd943b1c827e30fd72320035d1329b6e47aeee96
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-19 15:48:20 +00:00
Jarek Kobus
466856ca79 ShortCutManager: Avoid using sender()
Change-Id: Ibe0c2835463e1397b960526383afed73df50b62a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-19 15:48:02 +00:00
Jarek Kobus
7969fb2147 QmlDesignerPlugin: Use Utils::Guard for guarding the recursive call
Change-Id: I179d58374fcef4bebce1c3240bf8ba3d956f9c9c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-19 15:47:53 +00:00
Tim Jenssen
c8f35db483 ADS: fix crash on exit
None QObjects are not children of something - so they
need to get tracked.

Task-number: QDS-11555
Change-Id: I866097f9553a6080b30f0c12362bf7ec66321c05
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-12-19 15:42:40 +00:00
Miikka Heikkinen
24c2cd857d Effect Maker: Store property display names when saving effect
Fixes: QDS-11345
Change-Id: Id948bf6474fcc6bfff0d6e2f14241c4e4e916f6a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-19 12:03:59 +00:00
Thomas Hartmann
4eb1511977 QmlDesigner: Add checks against deleting files
There were reported cases in which the documents folder was deleted.
Adding checks to ensure only temporary files are deleted or single examples.

Task-number: QDS-11545
Change-Id: I93257ca6a9898ea6844cbc4125daef28ea57a7e7
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-19 11:56:42 +00:00
Miikka Heikkinen
2d166d0839 Effect Maker: Notice property changes in helper nodes
Property changes in helper nodes are now properly noticed as unsaved
changes.

Change-Id: I757f519075d2f96be2b84b57b25b916665e26ba7
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-12-19 09:15:49 +00:00
Miikka Heikkinen
c6b6a64e24 Effect Maker: Fix for case sensitive file systems
Helper node .qen are all lowercase, so use lowercased node ids as
filenames are generated from those.

Change-Id: I86ae7b07dbc30b7a68e0ee9214213d83d4e5dbd3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-19 09:15:38 +00:00
Ali Kianian
a3b58d9107 QmlDesigner: Fix the bug for QRegularExpression in dataStoreNode
Change-Id: Ibe6dff5d5304ec4e48a4f7239a3811feee455f8c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-18 13:04:03 +00:00
Ali Kianian
f41b69159b QmlDesigner: Extract unique property name by collection name
- The property names of the data store are defined after converting
collection names to a proper unique property name.
- Now, Spaces are supported in the collection names.
- Collection property names will remain the same by collection
renames, and only the modelName will change

Task-number: QDS-11462
Change-Id: I2031c2e0a9afc5388386dc6e54c66e75f0d13ded
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
2023-12-15 14:08:21 +00:00
Jarek Kobus
1a07fa87fd CollectionSourceModel: Avoid using sender()
Amends 6eb522f0ca
Amends 01a4f087c6

Change-Id: Ifa1be7cd2a39e6910160a4383fd9a1c1ce743731
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-15 11:07:39 +00:00
Jarek Kobus
efc63c8ffb NodeListDelegate: Get rid of unused functions
Amends 1a402984da

Change-Id: I518c2bcc638f295b1540361c633af045c0caf524
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-12-15 10:43:18 +00:00
Jarek Kobus
53c4fb0243 EventListDelegate: Avoid using sender()
Amends 1a402984da

Change-Id: I635febfb3c9b3f51a8155491a2e3d8edeb3647c9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-12-15 10:42:50 +00:00
Ali Kianian
08d7dcc46b QmlDesigner: Fix the bug for adding rows to a Collection
After adding a row to the model, TableView reads the whole model except
one cell. It also ignores all the further notifications for that cell
even if we notify it explicitly. By notifying a model reset, this will
be solved.

Fixes: QDS-11248
Change-Id: I92cc7be5f82bc9acd2f9695f6f6a306ef003b78c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-15 08:06:36 +00:00
Jarek Kobus
bc1f1c3719 QmlDesignerPlugin: Restore emitUsageStatisticsUsageDuration
It is still used in assetimporter.cpp.

Amends 80b3c9c35f

Change-Id: I53aad38072d6b0ae1e120a539a1f2fc713f5730d
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-12-15 07:27:18 +00:00
Jarek Kobus
ea0d814905 QmlDesignerPlugin: Use QWidget::isAncestorOf()
Change-Id: I7896fe5907e3af932ad29e6577207ac803164330
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-14 19:52:45 +00:00
Jarek Kobus
d18ef94aaf ShortCutManager: Hide currentDesignDocument() inside cpp
Change-Id: I21bd2bbfd29de810715286402f6d261f49051297
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-14 19:52:29 +00:00
Jarek Kobus
80b3c9c35f QmlDesignerPlugin: Make code less verbose
Replace some emit helpers with direct emission.

Change-Id: I832fc942234424f96da8516a18bd4b9e0c66c71a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-14 19:52:16 +00:00
Jarek Kobus
e919e235b7 ShortCutManager: Fix the disconnect condition
The intention was to check the passed arg, not a static state.

Amends 8d9710c074

Change-Id: I5215c67c533c399694883b83ea7ea66da8387342
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-14 19:52:01 +00:00
Mahmoud Badri
dc42b62ddf Effect Maker: Enable helper nodes
Helper nodes are nodes that another node depends on and are added
automatically when the depending node is added. Helper nodes are
placed before all other nodes. Helper nodes that do not contain
any properties are not shown. Helper nodes keep reference count
and are removed when last referring node is removed.

Task-number: QDS-11193
Change-Id: I036019afb1414ec6e98b2f949a18bd217753a910
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-14 15:17:22 +00:00
Shrief Gabr
6b6f74ccad QmlDesigner: Create data type warnings for CollectionDetailsModel
Task-number: QDS-11079
Change-Id: I8cb5167d71ff96d01313bc559401e16f0925afbb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-12-14 13:12:57 +00:00
Jarek Kobus
d6bc19e54d Qt5InformationNodeInstanceServer: Avoid using sender()
Get rid of some unused includes.

Change-Id: Ib8dd5f9672c446c5c571e79ed1f26f3f4af2b65d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:55:28 +00:00
Jarek Kobus
2f4fa0b62d Qt5NodeInstanceServer: Avoid using sender()
Amends b4db8a2d84

Change-Id: I9dc446d376bce9d91eb9d7a753003e0d92e10889
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:45:14 +00:00
Jarek Kobus
0f2a69408b Edit3DWidget: Avoid using sender()
Amends b662c50e0a
Amends 23f12f7b42

Change-Id: I71adb71c47e90aa257158eb7e600b99860432b3e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:45:04 +00:00
Mahmoud Badri
434d0faaa0 EffectMaker: Add 'assign to selected' feature
Fixes: QDS-11444
Change-Id: I17b5397b88eeccaae585e84d7ce62f4f80474f87
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-14 09:39:30 +00:00
Tim Jenssen
d186d9df6a Merge remote-tracking branch 'origin/12.0' into qds/dev
Change-Id: I0a598ba1b4d57be361a7a203d0c39e99b5cd5fba
2023-12-13 14:53:17 +00:00
Mahmoud Badri
82a0ae5caf QmlDesigner: Add 'save as' icon and update zoom and save icons
Change-Id: Id05dd67407dd8a4db0056caa94c61b459bd4ab23
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-12-13 09:38:31 +00:00