Commit Graph

67787 Commits

Author SHA1 Message Date
Christian Kandeler
6355796f11 QbsProjectManager: Improve interactive build config creation
- Offer Debug and Release.
- Make sure the qbs config names for two build configs of
  the same type do not clash.

Change-Id: Ia3bcb3243abfc64d71d20344e3bb16f00ba28c0d
Reviewed-by: hjk <hjk@qt.io>
2020-01-27 16:52:55 +00:00
Cristian Adam
b11445429e GitHub Workflow: Update Qt to 5.14.1
Change-Id: I8bc4ae712bdd886d4fa76fe26ba4152c87580cf0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-01-27 16:49:19 +00:00
hjk
86b5a81cf0 Beautifier: Avoid using QObject parent in settings pages
Change-Id: I66ecc5c6b4d79d27ac6bc6845eb56c4fdd7102a4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-27 16:41:25 +00:00
Christian Kandeler
d2d560c63b QbsProjectManager: Make BuildInfo::typeName unique
... per build type.
This is required these days by the target setup page

Fixes: QTCREATORBUG-23523
Change-Id: I8f00ffaf1401cd91ad7d4a550adcaf26b401fe52
Reviewed-by: hjk <hjk@qt.io>
2020-01-27 16:12:23 +00:00
Christian Kandeler
314ceb13bc CMakeProjectManager: Fix memory leaks
Change-Id: Ie1d046a4d736b02db9465062784730ebbab6a2ed
Reviewed-by: hjk <hjk@qt.io>
2020-01-27 15:08:43 +00:00
Christian Stenger
51cc14c738 Squish: Close Link with Qt banner at startup
Change-Id: I02e9a1b4eecc21804a2570a72cbdc0b19ae4f7a1
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2020-01-27 14:38:24 +00:00
Mahmoud Badri
5dcd9685f9 Fix form editor locking after dragging a 3D object over it
Also some code style cleanups.

Task-number: QDS-1529
Change-Id: Ie40763d11801adc91860a30e493240e797c4a752
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-01-27 14:14:44 +00:00
Christian Stenger
7a239ff62f ExamplesListModel: Fix leaks
Amends e96feed16f.

Change-Id: I9782fbc7f2ce0698efc0011e26653eb280ee23d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-27 13:11:31 +00:00
Denis Shienkov
de2fc39aa1 BareMetal: Fix Keil toolchains detection on Windows
A problem is that a latest installed toolchain overrides a previous
installed toolchain. In this case a previous toolchain will be skipped
from the search.

We need to fetch an information from the 'uninstall' registry entry,
which describes all installed toolchains.

Change-Id: I662e2696900909607d5ce618a728804e3683c856
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-27 12:48:00 +00:00
Christian Kandeler
350fe09cec Adapt qbs build to doc changes
Amends 5fc456dd22.

Change-Id: I342b82248ee84267613dd17583840d1c4daaaef3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-01-27 12:33:51 +00:00
Christian Stenger
3573b2db7f Squish: Fix wizard template categories
Change-Id: Ifb26430c429dc41ea73789a210f93b80e0e8d3f2
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2020-01-27 12:07:33 +00:00
Christian Kandeler
2c295905a9 Fix various leaks relating to use of Core::NavigationView
Change-Id: I8ba508b279376047bcf7ae17dbdadba70ec13582
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-27 09:12:52 +00:00
Leena Miettinen
5fc456dd22 Doc: Rearrange files in the doc folder
Source and configuration files for each manual are now located in a
separate subdirectory, with common configuration files in doc/config.

doc
|_config
|_qtcreator
|_qtcreatordev
|_qtdesignstudio

Edit the config files accordingly.

Change-Id: Idc747a7c16e84f3e06add91234dc5fc908e64cc5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-27 09:05:07 +00:00
Miikka Heikkinen
c9f90047ac QmlDesigner: Fix qml warning in edit 3D view
Change-Id: I736723a2acc896367760cf7137250d8d7d05ca91
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-01-27 08:54:53 +00:00
Mahmoud Badri
b842267814 Fix imported models do not appear in the Navigator issue
Task-number: QDS-1516
Change-Id: I0f9a062d99382ec8d8830410f2e1d190ff363a2a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-01-27 08:34:53 +00:00
hjk
461d278a35 CPaster: Pimpl plugin
Change-Id: I595222c374be30bfc3f32897a6096a528188cfc5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-27 08:25:04 +00:00
hjk
37188ee3a1 Nim: Use new settings page convenience functions
Change-Id: Ie6e317724cfacbd6b565931056fb88d3773a5bed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-27 07:15:16 +00:00
hjk
3e67c2ce92 TextEditor: Make FontSettingsPage more like the other ones
Change-Id: I00d758bcdafd39b14498bdf182332ece53215d64
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-27 07:02:18 +00:00
Christian Stenger
03ddc603cf Wizards: Split Application category
It lately became messy and it feels like it is
time to clean up these a bit.

Change-Id: I7b5da97cd7ad4231e28db13c98db16c656c8a6b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-01-27 07:00:57 +00:00
hjk
5ea999402c ModelEditor: Move closer to standard plugin setup
The private structure was already there, just delay initialization
and make the members direct.

Change-Id: Ic0d71fe27f15a5c270544469d046b3298e6b2c65
Reviewed-by: Jochen Becher <jochen_becher@gmx.de>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-27 06:45:09 +00:00
hjk
b093941435 Vcs: Drop VcsBaseOptionsPage hierarchy level
Adapt the remaining users: Cvs,Git,Svn.

Change-Id: Idd730a33e5c64d18002b1a21b5f5c715b7fa5ffb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-27 06:44:55 +00:00
Alessandro Portale
004614f6db GitHub action: Set the current sha as IDE_REVISION_STR
Change-Id: Ib18148c76cf504da8b70541fb472088b3b4f779c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-01-26 15:09:26 +00:00
Alessandro Portale
28ce199217 Core: Let the clickable link in VersionDialog jump to git log
...instead to just one commit.

Change-Id: I8bb53ba3e7f4fcfb2fb306afe2a06a2b63dc89d8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-01-24 17:20:05 +00:00
hjk
60f0e06942 Bazaar: Remove direct accesses to singletons
Change-Id: Ie736597dcc17256fc1ef912689ef86e706acbd99
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 14:34:10 +00:00
Alessandro Portale
f39e9be2f2 Utils: Use themed text color in EnvironmentWidget
Since we also have dark themes, we cannot always use black. Use the
application global QPalette colors which originate from the theme.

Task-number: QTCREATORBUG-23358
Change-Id: Id997e3b0d125d8e39fe7951b5dc827288b8086bb
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-24 14:05:05 +00:00
Alessandro Portale
8d722587b9 Core: Use themed color for "highlightWidget" in ManhattanStyle
Change-Id: I0bd594fec2a0fe9b3093d7c6a4439657c78dfff6
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-24 13:45:13 +00:00
Alessandro Portale
0d991985d6 Core: Fix non-CMake compilation with IDE_REVISION
amends ae9fbd04dd

Change-Id: I746a89b21ee07aecad525b7b91fe1f360ad1e853
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-24 13:44:52 +00:00
hjk
68f90d1c67 Cvs: Drop direct access to plugin singleton data
Not needed anymore.

Change-Id: Icb00cddf01ebfe7054cb85efc76f46578e3f1a1e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 13:33:30 +00:00
hjk
4f8f156aa1 Cvs: Remove some unneeded indirections
Change-Id: Ia2265d1a46c6141b1412f65d9548e3ad04f6a6a8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 12:57:25 +00:00
Oliver Wolff
6eb3fa4580 winrt: Fix crash when opening run configurations
The "Smuggle in the button" hack broke and made Creator crash when a run
configuration is opened. Having a "proper" aspect for the arguments
saves the day.

Change-Id: I45646318f5e8c42fb1ed64c07de5728d9d08c431
Reviewed-by: hjk <hjk@qt.io>
2020-01-24 12:19:37 +00:00
hjk
16a4c56bdf Cvs: Fix crash on load
Amends 1cd936c531

Change-Id: I14239730bc079be570f060ce48cb84eb2bfe02d4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-01-24 12:17:24 +00:00
Eike Ziller
bc4fd14ee4 CMake build: Some clean up for macOS
Don't install qtcreator.sh, it cannot be used.
Don't install application into bin/ subfolder. App-bundles do not follow
the UNIX bin/, lib/, share/ convention, so don't even try. (This makes
bundling it into a 7z consistent with what we do on the other
platforms.)

Change-Id: Ib3faa2909a9b30a11193586f279528f1b8bd96fa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-01-24 11:43:27 +00:00
hjk
866f3aeb4a Vcs: Pass settings handles to settings pages more directly
Change-Id: I5fdec80de5678dd544713fc18335cbd805d7b9f4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 11:40:49 +00:00
Alessandro Portale
ba5c0323fa CppEditor: Use FancyLineEdit in CppCodeModelInspectorDialog
Change-Id: Ib4688ec1406dafb39059fe3b4ea3277ea8e6fffa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-01-24 10:41:17 +00:00
Alessandro Portale
0675ece793 Core: Set FindToolBar's prev/next buttons disabled on document close
If the current document closes, all items of the find toolbar (except
"Advanced...") are supposed to be disabled. The previous and next
buttons however remained enabled, which is now fixed with this change.

Change-Id: I33f978f23970280f04fb4f6237b733d5109043c1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-24 10:22:20 +00:00
Cristian Adam
d2bdd5fc40 Remove stray debug cmd file
Change-Id: I19a50e13951f876fcde26a34cd7db0a0e5359a55
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-01-24 10:11:02 +00:00
hjk
e0072ec165 Vcs: Move settings ownership from VcsBaseClientImpl to plugin
Turns out CVS and Bazaar already had an unused copy there...

Change-Id: I512c4d6322620e2b55d9008600ac676ce09032aa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 09:55:35 +00:00
hjk
1cd936c531 Vcs: Pimpl plugins
Essentially rename all *Plugin into *PluginPrivate, and pull out
the actual IPlugin related pieces into new *Plugin classes.

Shift the construction of the PluginPrivate to initialize(),
following the general pattern.

I tried to keep the patch as mechanical as possible, giving
room to some obvious but less mechanical cleanup needs,
that are intentionally left out of this here.

Change-Id: Iac662bf73338f9f7669064ed67b960246875c23c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 09:47:28 +00:00
hjk
01e4f573e8 VcsBase: Un-pimpl VcsBaseClientImpl
Not helpful for a single pointer.

Change-Id: Id5cfdb67533ca1852d5594d25689b2e46baca992
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-24 09:02:25 +00:00
Miikka Heikkinen
fd40bdd606 QmlDesigner: Use double precision to calculate ray-plane intersections
Float precision becomes issue when calculating ray-plane intersections
for gizmo hit detection when camera is very zoomed (in or out).
Do the critical calculations in double precision to mitigate the issue.

Change-Id: I8c33e17bf19d092e24ab19f8f8f2a54cd83304cc
Fixes: QDS-1526
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-24 08:42:31 +00:00
Maximilian Goldstein
4d269f930a lib/utils/consoleprocess: Check for xdg-terminal
Change-Id: I9970153d9abc9beff3081ddb09e7d3d95ea8c63a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-24 07:13:42 +00:00
Christian Kandeler
5d53dbd501 QbsProjectManager: Relax qbs API version check
We have recently bumped the API compatibility version in qbs master.
However, Qt Creator did not make use of the removed feature and can
therefore deal with the old and the new version.

Change-Id: I40b2d8c9ef16993617b346887d4de5a936e8ec54
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-01-23 16:37:10 +00:00
Alessandro Portale
c6a7aed17e QmlDesigner: Make "Generate resources" action translatable
As a first step towards enabling the creation of .qmlrc packages in Qt
Creator, make it translatable (before Qt Creator 4.12 string freeze).

Task-number: QDS-1286
Change-Id: I3fd296c3a9c8ec7fc985b61893b1a7e7037328d2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-01-23 16:22:38 +00:00
Christian Kandeler
e1d04362ec QmakePM: Let some more built-in qmake variables get highlighted
Task-number: QTCREATORBUG-14389
Change-Id: Iacd6524bf8a7a970af6515193dd7ca4a0814e121
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-01-23 16:18:33 +00:00
Christian Kandeler
eb0a9a2800 Qmake: Re-add accidentally deleted line
Amends e70116bf67.

Fixes: QTCREATORBUG-23514
Change-Id: Id852c591ae21d29312eb934f14970c6b05300bc9
Reviewed-by: hjk <hjk@qt.io>
2020-01-23 15:54:39 +00:00
Leena Miettinen
5b21c66b1d Doc: Update information about Sketch
This change was missed when moving the docs.

Change-Id: I106f5505de46785afd80ea668aa2c13ee4a9d072
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-01-23 14:48:31 +00:00
Tobias Hunger
3444194f2d Kit: Define a default predicate
Define a default predicate that just checks whether or not a kit is valid.

Change-Id: Ibfa38a3c802bc1442bf922eccbedd650d89703c9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-23 14:34:16 +00:00
Alessandro Portale
ae9fbd04dd Core: Make the revision sha in VersionDialog a clickable link
The base URL can be defined via the IDE branding mechanism. If omitted,
the revision is plain text, like before this change.

Change-Id: If1a74707a10c76e15d3d25b8e6b0c302219fb91d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-23 14:33:31 +00:00
Christian Stenger
bf7b16d9ca Add Qt Marketplace plugin
Provides a simple integration into the welcome page.

Task-number: QTCREATORBUG-23452
Change-Id: I3e615dcd6dfd9e401159ea6d30b48737edb1e1f9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-23 14:29:36 +00:00
hjk
d08c0f31c4 De-Q_OBJECT-ify most DeviceFactories
WinRt is the odd one out.

Some were using setObjectName, but only used for debug reasons,
not really needed.

Change-Id: I4a370e4694443bc1c455fda4337ef3acfb9259b8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-23 13:32:12 +00:00