The Qbs build system uses an "option" and that overrides
a normal variable if there isn't already a cache variable.
So we need to write these variables to the cache.
Amends d07ce92d0d
Change-Id: I98a7e31f278d509f50e20537af9d574db71d2e9f
Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
qt_create_translation was introduced in Qt 5.15. But we also still
support older Qt versions, so we cannot use it unconditionally.
Fixes: QTCREATORBUG-25070
Change-Id: I81de7e19b42e0e8cb9cb23e14909e71c534dc0da
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
On Linux (Ubuntu 20.04) Qt Creator would use /usr/bin/g++ as
compiler for C++. CMake would pick /usr/bin/c++ as C++ compiler.
Both of them are symlinks to /usr/bin/x86_64-linux-gnu-g++-9
There is no need to create imported kits for something which
is the same compiler.
Fixes: QTCREATORBUG-25069
Change-Id: I90e0f7b1977ace3f7995ce09f4b3fcfa64d02b72
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Once we parsed the project initially, subsequent parses typically do not
change things in a major way, so we can expect e.g. run configurations to
stay intact.
It therefore makes sense to allow users to schedule an
application run not only during a build (see 4b92b7ac60), but also
during a parse. Arguably, this is even more relevant, as parsing is
usually not triggered directly by the user, but happens as a side effect
of editing a document or switching a branch. It is then annoying for
users to have to wait until the respective buttons get enabled again.
Fixes: QTCREATORBUG-24986
Change-Id: I1081ccde668eee794c39b96cd0bad5c3aaa580bc
Reviewed-by: hjk <hjk@qt.io>
put the process on the stack, so we don't need (and fail) to free it.
while at it, remove the pointless close() call.
amends f46099d2.
Change-Id: I4025691bebf2899efe006ee83012aefbb8797a64
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
there is no logical difference between a hung or crashed process and one
that exited non-zero.
blocking execution already behaved that way.
Change-Id: Ifb80d050f9771cb9ea4021329ffef8e646e43ac9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
QProcess is fully buffered, so there is no point in trying to feed it
chunk-wise.
amends 25264d9b.
Change-Id: Ie1a32a6ac56f8e21a452b26dfaca4237d3f08d9f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Parse qmlRegisterSingletonInstance to support types created this way in
QML.
Change-Id: I08440de52097faae5fd05ab32157279ee2ca2942
Reviewed-by: Kevin Funk <kevin.funk@kdab.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
the conditions on the waitForFinished() calls were inverted. the visible
effect of this was that 'Hang' was never reported.
Change-Id: I9937fce58189eebf891000840597158b4bffd028
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
one instance had drifted away from its relevant location, while another
instance was a bogus c&p.
Change-Id: I0148f08ca2741efd82bf10a042fe341bafcfc087
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It fixes the following warning:
Use Q_ENUM instead of Q_ENUMS [clazy-qenums]
In addition, it amends 8588cf268f
where WidgetStyle got removed.
Change-Id: I4d72dd762a2f18ba8886360b3581b4ef19bf4c5e
Reviewed-by: hjk <hjk@qt.io>
introduced by 9b8493314dd77f3e96b353187816bb7ef4dedbb5 from qtbase
This change does not address all usages of super data in the dumper, but
enables dumping children.
Task-number: QTCREATORBUG-24098
Change-Id: I813dacfa719dd6ca367e305fadcc8f2b8ee45425
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In addition, document the new option that
enables automatic kit creation for all the
available targets.
Change-Id: Ic9168f032472bdd98b9b026934476e606a9ab94e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Where possible, link to sections about QML types within the manual.
Task-number: QDS-2744
Change-Id: If12e8ce0261258c0c7e4b293e2cd45ad959c7882
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Case like 'template<typename T> using TVector = std::vector<T>'
end up only as 'TVector' in the debug info. This is unsuitable
as an id in our type info caching as this would only allow one
type layout for all specializations, which is not the case for
e.g. std::vector<bool>.
The solution is to mangle the target type into the id, as already
done for GDB.
This makes the Typedef2 dumper test pass.
Change-Id: I11538bbf6431f61a11c18366a2a2b4911cdc2e0e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This fixes the Internal2, EnumFlags and EnumInClass tests on Linux.
The values lose now the previously hand-crafted Class:: prefixes,
but the context is clear from the type column, and it's what LLDB
developers (and potentially users) consider normal.
Change-Id: I09e41f7b4fb4f078ef3f535fe650d06e7c2a0331
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Use the right variable name, and syntax for iterating the list.
Fix plugin configuration order, so targets are found.
Fix misspelled plugin name.
Also remove unused and wrong "EXPERIMENTAL" option.
Change-Id: I77cc5d12ebdaa8bcd0315dd830a9435c648b2ba3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
since this is set to null - indirectly from the showEvent of FormEditorWidget.
Use the instanceBoundingRect of the rootNode instead.
Fixes: QDS-3316
Change-Id: Ia156e5b675bc1c517c4b3f5c640b22d9c47bc117
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Strangely enough, this issue did not trigger with GDB for either
Python 3 or 2.
Change-Id: I0e5cf7ce0a8605f105bff549634aa014ef1f8403
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Enable/disable our own KSyntaxHighlighting by default
depending on the availability of KF5SyntaxHighlighting.
If that is available, it still is possible to turn the building
and using of our own KSyntaxHighlighting copy on by enabling
BUILD_LIBRARY_KSYNTAXHIGHLIGHTING.
Fixes: QTCREATORBUG-25076
Change-Id: I3545fc12d87572d7eb6f5977994b081ff7ea3880
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Was off by one, swallowing the first character of the message.
Change-Id: I736cadda2cb6d9e3703d276b631e574c498af874
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.
readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.
Change-Id: I004d6f7fab4375f9902f940f29b4a4f561fc7604
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Try to not save settings that weren't changed from their default, and
make it possible for defaults to change in the future.
Task-number: QTCREATORBUG-24762
Change-Id: If469b72573791bc92ed535edf00271ef09b55386
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It opens from Help > Technical Support.
Make the content more useful to QDS users and hide
the developer information from QDS Manual.
Fixes: QDS-3307
Change-Id: I01eec99b85ecd6d2f2d2c970370e560d6719ee75
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This is an attempt to handle output coming from
sanitizers appropriate.
Task-number: QTCREATORBUG-24328
Change-Id: Ifb22d465c9f99d767cc7702b9c459076ab39d567
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Timer was accessed before creation in this case.
Change-Id: I8817043f1a875cb4c7c6cf8a1f4b398f78058509
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In AutoTest, use the toolbar and menu variants accordingly.
Change-Id: I1405de1ace1efe6c3e51b17356a9e4dfb3b11dcd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Use a ValuePattern(.*) instead to specify an uninteresting/unchecked
value.
This allows using of TypePattern in the same check, allowing to fix
a part of CharArray test for LLDB.
Change-Id: I3b8b209318d663290c02ce466e2a198d3a66832f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Puppet reset is needed as changing shader makes no difference
if done after material initialization.
Change-Id: I67b0b4cca28b4636cc9acb1cd7446dfabc10e2ee
Fixes: QDS-3300
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Add QFutureSynchronizer for collecting all running
futures (including those already canceled, but not finished yet).
It could happen, that we cancel the future, while
the associated task still needs some time in order
to catch the cancel request. When a d'tor of synchronizer
is run it cancels and waits for all pending futures
to be finished.
Add extra check for isCanceled() after a call to
updateDependencyTable(). In case the cancel was detected
inside updateDependencyTable(), we should return immediately.
Don't leak CppClass object inside handleLookupItemMatch()
when the task was canceled.
Amends: c400923308
Change-Id: I709e14a0c8b563d522a8e8c32b087e5f83310b24
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
