Fixes after c21932163779bcfe4577ac2e3326b8c113884829
Change-Id: Ic72a76e824e68405bb1582c2b6b59bd59858212c
Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
As the comment for the 'm_parameters' member
in the 'BreakpointItem' class says, that member is
supposed to hold the "Parameters acknowledged by engine",
which the parameters newly set in the dialog are not
yet at this point in time.
Therefore, if a global breakpoint exists, apply the
new parameters there, so they are considered as pending
changes (also returned by 'Breakpoint::requestedParameters')
when 'BreakHandler::requestBreakpointUpdate' is
called a few lines below, and new values get applied
properly.
Task-number: QTCREATORBUG-25035
Change-Id: I8bfd9123785ee911ff180d8311fa2559b55be580
Reviewed-by: hjk <hjk@qt.io>
It is simpler to just recreate the timer than reuse the existing one.
Change-Id: I50a8507a69b83917ff522bb5ae472285135c351c
Fixes: QDS-3026
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Make API users explicitly choose the severity of what is posted, giving
the methods evocative names.
Document best practices.
The goal is to move all API users to the new API and then remove the old
one.
Task-number: QTCREATORBUG-24430
Change-Id: Ic095cc34b887694b5b5779f0c3daddfde40950f7
Reviewed-by: hjk <hjk@qt.io>
We should never actually write default values into the settings, because
- if the default value changes in a later Qt Creator version, the new
default should automatically take effect if the user didn't change the
value
- it senselessly grows the settings file
Add a QtcSettings class that extends QSettings by a
"setValueWithDefault" method, which does not write default values to the
settings, and actually removes the settingskey if the user switches back
to the default.
Use it at the places where we already do this manually.
Task-number: QTCREATORBUG-24762
Change-Id: Ia76414cb21e8521f3aeed1e37b43ae4fb3393ea3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Fix a warning: conversion from ‘size_t’ {aka ‘long unsigned int’}
to ‘uint’ {aka ‘unsigned int’} changes value
from ‘4939931809569846361’ to ‘3557831769’ [-Woverflow]
Task-number: QTCREATORBUG-24098
Change-Id: Ibc123d8e28c7072dd947a1f8058dc8561ff7f6df
Reviewed-by: hjk <hjk@qt.io>
Amends e6873b5b24. As on it fix handling for key, value
handling for Qt6.
Change-Id: Ie13b02f92fd56d9372150763a2d56df511185baf
Reviewed-by: David Schulz <david.schulz@qt.io>
This avoids checking the debugger engine on Windows
which may fail when using a wrong kit.
Change-Id: I427281f6749cbccc3d3d85f6bdafa0138e1d54f0
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Sometimes, clang_getCursor() erroneously returns an invalid cursor, in
which case we may be able to retrieve the real one via
clang_annotateTokens(). This is basically the reverse of the issue we
recently had, where we had to call clang_getCursor() to get information
missing from clang_annotateTokens().
Fixes: QTCREATORBUG-21194
Change-Id: Ie8c4767bca03bd1b27e3ef1f906378fc1d436b90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... in the MakeInstallStep.
See also d56e88d36a.
Fixes: QTCREATORBUG-25022
Change-Id: I0824355e0604cd4a7cc2ac9cdb4a55733cb0f706
Reviewed-by: hjk <hjk@qt.io>
You can now use CMake to build docs.
You also have an option to use the online style, which
enables you to check how the docs will look after release.
Change-Id: I63f573a58a2daf3aa05a2f0dd57f33f859e25bc2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Fixes opening a new project without existing build folder, changing
some configuration values, and pressing apply or choosing Run CMake.
extraCMakeArguments contains the arguments needed to apply any changes
done in e.g. the CMake configuration list in projects mode.
When pressing Apply, the build directory gets created, and CMake run
with REPARSE_FORCE_INITIAL_CONFIGURATION. But we may not remove
REPARSE_FORCE_EXTRA_CONFIGURATION which might even just have been added
a few lines above after asking the user via mustApplyExtraArguments().
Amends af4e74a972
Task-number: QTCREATORBUG-24936
Change-Id: I5e5547611262490ebdebb30dc1bfc690f1cdedde
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The additional parameters to pass to CMake are set in a
"extraCMakeArguments" property, but we had two places where this was
set, overwriting each other: from the list widget where the user makes
changes, and from the QML debugging option.
Combine the two code paths. This has the additional advantage that the
changing QML Debugging and Profiling option behaves the same as changing
variables in the list - the "Apply Configuration Changes" button gets
enabled when changing the option, and one can use it to apply the
change.
Task-number: QTCREATORBUG-24988
Change-Id: I785c6804c9597a9eba471f56babaae966ce84b17
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Syntactically, they do have an initializer, but they are not
initializations.
Change-Id: I0556b279ce2d173868585cbce085b803c1cff285
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... until the values have actually been set up.
Fixes: QTCREATORBUG-24971
Change-Id: Ia967fe95545eda1c9044faf8ab1ee885bf3d9e02
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
If the QtQuick import was less than 2.15 implicit dependencies
were not properly resolved.
For example if a type from a module derives from QtQml.QtObject.
Change-Id: I42a3320ee91496da0991de2018efcd124d56f6cd
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
The Controls Style "Default" that is currently by default in the
generated qtquickcontrols2.conf is not present in Qt 6. That leads to
QML runtime errors and aborting applications with Qt 6.
Let's switch the default to "Material" which is available since Qt 5.7
and present in Qt 6.
Fixes: QTCREATORBUG-25027
Change-Id: Ic8b631b771487624d7459a276d290b80c7ad8be0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This makes the use of '@' prefixes in split('{@QString}'...) etc
mandatory, thereby removing the guessing on whether namespaces apply
or not on the dumper 'core' side, and removes the guessing on
whether dropping the '@' 'works' on the individual dumper implementation
side.
Amends 1074c2ffce.
Change-Id: I44611eb09557638dec12d2e2f78cdaeac0bbd449
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Clicks on QPushButton margins are no longer detected as clicks, so
change the text alignment to be done with padding instead of margins.
See QTBUG-81452 and QTBUG-86587 for related issues.
Change-Id: I85971c4defc5d43f959095d4d8e4457804aae0f9
Fixes: QDS-3180
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In case a Type Hierarchy widget isn't visible,
the CppIncludeHierarchyWidget::perform() is called
twice when requested from "Open Type Hierarchy" context menu.
The instances of CppIncludeHierarchyWidget class
are created only when Type Hierarchy item is selected
form the combobox, and are destroyed when different item
is selected. A call to:
NavigationWidget::activateSubWidget(Constants::TYPE_HIERARCHY_ID,
Side::Left) may be ignored (in case Type Hierarchy widget was
visible) or may recreate the widget and invoke
CppTypeHierarchyWidget::perform() for the first time
(in case when Type Hierarchy wasn't visible).
Just after this we emit typeHierarchyRequested(), which in turn
invokes perform() one more time unconditionally.
In order to fix it, we emit the signal typeHierarchyRequested()
first (which will invoke perform() only when the Type Hierarchy
widget was visible), and later call activateSubWidget(), which
invoke perform only when we are recreating a widget.
This shorten the freeze time for calculating big hierarchies,
like for ExtensionSystem::IPlugin, by 50%.
We do the same for CppIncludeHierarchyWidget.
Change-Id: If58fba4ba1dc32999d106fc2faa712e05442caf3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Create a common directory for extra image files, and move the video
thumbnails there. This folder structure is required to work around
the fact that relative image paths passed to qhp.<project>.extraFiles
are not resolved correctly when loading the generated help project.
Change-Id: Iff5583a9a318670571b7f706182723e54e0ec466
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
The -b option turns on "pure batch mode", i.e. users won't get asked for
a password. This does not seem to be overridable. Therefore, we use
input file redirection instead.
Fixes: QTCREATORBUG-24979
Change-Id: Id1f703ffd61a7b8d194437ee89676770990d0efa
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Newer clang releases do not use the static tooling libs anymore.
Change-Id: Ia0766dce9ccf79266ec8a3fd0b0f9c638fc41ced
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
QString::begin/end may be null in Qt 6.
Fixes: QTCREATORBUG-25018
Change-Id: If50cb79c58096d5fa68e494e33bea131063968fb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
TextInput does not support rich text.
Task-number: QDS-2769
Change-Id: I6ae9862f65c866cce2975f7f53cb2683f41f0d9a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The links for the new sdk tools were using a different folder structure
in the zip archive which are different from the previous packages and
from what QC expects.
Fixes: QTCREATORBUG-25017
Change-Id: Id288d5cc59a3bad87ce2c795fba28b7ebfa027e5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
