Commit Graph

67787 Commits

Author SHA1 Message Date
Alessandro Portale
7b03e0701d Utils: Fix uneditable TextEditDisplay StringAspect
Change-Id: Ia3f912021b1d4d3cd407d191f8f452149a346c69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-20 11:18:58 +00:00
Aleksei German
181fd57cc4 QmlDesigner: Fix for rotation cursor
- Added new icons to icon font
 - Uses new drawing method for rotation cursor

Task: QDS-3131

Change-Id: Ifa8dda2630794694dd262396ca314a9b4e6675ad
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 10:49:52 +00:00
Eike Ziller
f38d7910fe Help: Make litehtml the default engine above all
If available prefer litehtml, even over QtWebEngine. But make the
default compile-time configurable with a CMake option
DEFAULT_HELPVIEWER_BACKEND.

Amends 5e73215a0a

Change-Id: I5bfadd3ec1dc21f3a94d04d0da51783223908e6d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2020-11-20 10:12:00 +00:00
hjk
ff3614ab5a Debugger: Don't use QApplication::alert too often
There's an ICore::raiseWindow() call already for spontaneous stops,
conditioned on boolSetting(RaiseOnInterrupt). This should be sufficient
for normal operation.

Task-number: QTCREATORBUG-12769
Change-Id: I33daad2579f9cfdb8fd121b9c9db73c05f9eccb7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 09:47:36 +00:00
Leena Miettinen
ec6b6f3671 Doc: Add link to Qbs attributions into toplevel Readme.md
Task-number: QTCREATORBUG-24622
Change-Id: Icff751b12fc03d18f5d1fd4f8dd191a344a9981b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 09:41:48 +00:00
Eike Ziller
d981485a89 Help: Remove Qt version check
We are requiring Qt 5.14 now

Change-Id: I2deb97dec4800ab10c25f7f6223a8c440a3a9c3f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-20 09:32:27 +00:00
Eike Ziller
1dcb7e5550 Help: Register at least one set of documentation per major Qt version
The default configuration only registers documentation files only once,
from the highest registered Qt version. This made sense within the Qt 5
series, since Qt documentation for the higher version included all items
from the lower versions.

With Qt 6 this changes - some API was removed in Qt 6. To make sure that
documentation of all Qt 5 API is still available, we have to register
the newest available documentation for Qt 5 and Qt 6, not only of Qt 6
(the overall newest available documentation).

Expands 3dfa188182

Change-Id: I8b2984b0be11dcc823ef4a206800c84887b632ca
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-20 09:18:40 +00:00
Christian Kandeler
f697a0d46c ClangCodeModel: Fix sorting of includes when auto-completing
... by treating the directory separator specially.

Fixes: QTCREATORBUG-21490
Change-Id: Iad6f51f39516a88bd14ba1eddcf2c6656490ee5b
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-11-20 08:43:41 +00:00
Jarek Kobus
b77d661152 Don't call virtual method from LocatorPopup's c'tor
Rename LocatorPopup::updateGeometry into doUpdateGeometry in order
to not clash with QWidget::updateGeometry.

Move a call to doUpdateGeometry from LocatorPopup's c'tor
into subclasses c'tors. Make subclasses final.

Change-Id: I601731e6c883631c3d484ed7f11d82a99bb1f731
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 08:23:45 +00:00
Leena Miettinen
95685898a5 Doc: Edit info about MCU support and add screenshot
The QML Types tab displays only the supported types, so
that will tell users which types are supported.

Change-Id: I49dd1f7d81401a84b8780fdc61f49870c58c3935
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-20 07:58:44 +00:00
Leena Miettinen
552a86f6b3 Doc: Link to Qbs licenses and attributions
Fixes: QTCREATORBUG-24622
Change-Id: Ieeb35e94f1409a849383bc88739047b3b30bbe26
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-20 07:57:21 +00:00
Eike Ziller
5c0ec9210c Fix initial directory when using konsole for Open Terminal Here
Fixes: QTCREATORBUG-24947
Change-Id: I14f5b47ba2ad71005653faadd5e78fda9570196e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-20 07:31:44 +00:00
Alessandro Portale
937850a292 CMakeProjectManager: Get rid of an unqualified friend
The latest libClang gives us following warning:

cmakebuildconfiguration.h:104:18: warning: unqualified friend
declaration referring to type outside of the nearest enclosing namespace
is a Microsoft extension; add a nested name specifier

Deleting is the right fix.

Change-Id: I4ccccf286044ca45ec78b0ea03a4ce8d979f06b4
Reviewed-by: hjk <hjk@qt.io>
2020-11-20 06:15:34 +00:00
Leander Schulten
993b614d94 CppEditor: Remove using namespace quickfix: Don't insert inline namespaces
Change-Id: If386d31de723ca928d3c50f55e32205c50937b0a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-19 18:35:05 +00:00
Leena Miettinen
bb9ca6227c Doc: Describe rotating items in Form Editor
Fixes: QDS-3067
Change-Id: Id97876edaccac0d567694a9fcf350701d9df926b
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 17:35:49 +00:00
Johanna Vanhatapio
253a758d89 Doc: Update Applying 3D Effects
Task-number: QDS-3087
Change-Id: I2e2f4e70f98fbb54b32d22ce64307f48a1c79832
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-19 16:34:09 +00:00
Leena Miettinen
3daf838cc3 Doc: Describe "Get Qt" option in Welcome mode
Update screenshot.

Change-Id: Ia209ba65a27f213c3248d4d2535eac6cebd03774
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-19 14:48:24 +00:00
Eike Ziller
5ca70bdcb3 Merge remote-tracking branch 'origin/4.14'
Change-Id: Iea84f23cf394de13e99a9ed777c8c113e4eff473
2020-11-19 15:38:13 +01:00
Marco Bubke
9b6944086b MultiLanguage: Add image generation for excel export
Change-Id: Ied15381d94c391c86438c66fe88f755421bb3492
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 13:22:44 +00:00
Thomas Hartmann
a369c5b10c StudioWelcome: Add option for UsageStatistic plugin
Change-Id: I865d4594ca8cd40390b561731259ddb51c83641c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 11:41:39 +00:00
Thomas Hartmann
3440baecd3 QmlDesigner: Allow building the fallback puppet in QDS
This allows supporting a puppet with Qt 6 built.
In later versions we should remove this again.

Change-Id: Ia5b0a34ab3fb071e895e88e5086749ba499ef63f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-19 11:27:46 +00:00
Leena Miettinen
095970a57b Doc: Describe MCU support for types and properties
Fixes: QDS-3072
Change-Id: I3050b706b597d6f9171932c0ab5884b7d8ee094c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-11-19 10:39:40 +00:00
hjk
a812bd7303 Debugger: Make qfloat16 dumper test pass with Qt 6
45.3 is represented as 45.28125 in Qt 5, but as 45.3125 in Qt 6.
Actually an improvement.

Task-number: QTCREATORBUG-24098
Change-Id: I779bfd8a2b4a2ae91f5e40dbe54ba75000531f4c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-19 10:23:27 +00:00
hjk
113fc9d060 Debugger: Adapt QStack dumper to Qt 6
Task-number: QTCREATORBUG-24098
Change-Id: Ibbe2f0c1faface1a1d6893eb0cb3987e5dff1b1a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-19 10:22:40 +00:00
Eike Ziller
bdc74ea2a0 cmake: Show errors for unsupported CMake versions
Show an error icon in the CMake settings, and instead running CMake with
unsupported parameters show an error in the Issues pane.

Arguably it should not be possible to select an unsupported CMake
version in the kit settings at all (neither manually nor automatically
when setting up kits), but this is the less intrusive change for now.

Fixes: QTCREATORBUG-24553
Change-Id: I32caa2ce93d28cbd9db90e2004d60da93d32c68c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 09:51:27 +00:00
Jarek Kobus
36d5e328e4 Fix listening to signals after library and linkage type changes
Change-Id: I437fbbcfde4c4781bf8b5b4711a597e64410c785
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 09:49:17 +00:00
Eike Ziller
86c8c2541e Fix overlapping accelerators
With the View menu.

Fixes: QTCREATORBUG-24614
Change-Id: I2814a3ccae0f10e5c49482534bce024fab68f271
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-19 09:49:05 +00:00
Jarek Kobus
2341609719 Avoid signal overloading
Choose a different name for them.

Change-Id: Ie2cc2c85dca72b7f7ff84c95fb0abd0a0e99a63d
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-19 09:48:38 +00:00
Jarek Kobus
b269066435 Use const iterator with std::find_if where possible
Make the resulting interator const.

Change-Id: I4aadcfff35f6b1015e506bc75bcfc2a1f1be4d65
Reviewed-by: hjk <hjk@qt.io>
2020-11-19 09:46:31 +00:00
Jarek Kobus
48c2afe157 Decorate some classes and methods with final keyword
This way we silence the clang warnings about calling
virtual methods from c'tor or from d'tor:
[clang-analyzer-optin.cplusplus.VirtualCall]

Change-Id: I8d6318b490152133da4833bda2ba28622bce30dd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 09:45:53 +00:00
Alessandro Portale
b2a766a79a Don't access static functions/fields via instance
Courtesy of readability-static-accessed-through-instance

Change-Id: I71f54244f1e091315dac2943d9e1bfad6efa56a9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-19 08:42:14 +00:00
Christian Stenger
f54784cbbe ClangSupport: Fix missing include
Amends 2ce783f96d.

Change-Id: Ib0fc37b146959ecdf9c329c45321f29cd7a18a0e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 08:17:39 +00:00
Jarek Kobus
eccebe41dc Fix a warning about calling virtual method from d'tor
Fix the following clang-tidy warning:
Call to virtual method 'IosRunner::stop' during destruction bypasses
virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

Remove the reimplementation of IosRunSupport::stop(), as it was
calling base implementation. Make base IosRunner::stop() a final
method.

Change-Id: I8e57a6dd6a44d2a6f00f5af96a11530f62c92429
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-19 07:41:56 +00:00
hjk
92cd7f3c06 Debugger: Adapt QMap and QMultiMap dumper to Qt6
Chicken out of the QStringList == QList<QString> in Qt 6 dilemma
by using QList<QString> everywhere, that's not important for the
QMap test. value/key vs first/second nevertheless needs adaptation.

Task-number: QTCREATORBUG-24098
Task-number: QTCREATORBUG-23806
Change-Id: I4bdb8222978de7e7f1596be380e0fedc8f9d1a06
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-11-19 07:24:26 +00:00
Eike Ziller
f99e46c148 cmake: Fix version information about unsupported cmake tool
When registering a CMake version without fileapi support and setting
that in a kit, the kit shows a warning about unsupported version. It
didn't show the version of the registered CMake though. Make CMake tools
without fileapi return their version number.

Change-Id: I388d3e0a17ff4145238c5c90109522665a6f6fac
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 07:06:38 +00:00
Eike Ziller
953db51a15 cmake: Remove unused variable
Change-Id: I17d373088c3f2085c52ebf9230b3ce2f0f64074a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-19 07:06:31 +00:00
Alessandro Portale
0c0347ce61 ClangTools: Improve menu icon of "Analyze Current File" action
The icons in menus should (depending on the theme) be colored
differently than the icons in toolbars.

This change assigns a menu-style icon to the "Analyze Current File"
action, and uses a ProxyAction to add the action with a toolbar-style
icon to the tool bar.

Change-Id: Ib423602adabe2c4e1322e0d8418c32e2fb70e478
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-18 23:57:07 +00:00
Alessandro Portale
871c8e3ffd Don't access static functions via Utils::HostOsInfo instance
Change-Id: Ic45b8f324cb7c6a4691545fc8d668eed69dfeced
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-11-18 22:08:42 +00:00
Christian Kandeler
7aec256087 QmlDesigner & friends: Fix various new warnings
Change-Id: Ia5e3d47e70e1881e70652f090ccc61543535df4e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
v4.14.0-beta2
2020-11-18 17:05:51 +00:00
Alessandro Portale
30aec82285 Add missing "final" to unexported/unshared classes
Change-Id: I84d5fc39d7ef5588a20545854d0cfd0b993db090
Reviewed-by: hjk <hjk@qt.io>
2020-11-18 15:40:29 +00:00
Alessandro Portale
a1ff9d170f CppTools: "CLANG-UPGRADE-CHECK: Update known language features macros."
Clang++ 11 has __cpp_constexpr_in_decltype

Change-Id: I450a79f2af8cd6aca51b95b11b3c06b9682c0418
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-18 15:40:15 +00:00
Eike Ziller
e755094480 Add option for globally changing the base environment for tools
Fixes: QTCREATORBUG-22123
Change-Id: I00a5bbdf92e5dab513cb12f3518a2abb1adbb9cd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-11-18 15:24:02 +00:00
Alessandro Portale
05dca6f09e QmlDesigner: Fix build
Change-Id: I3d46dce18c5c172499931e3bb8c647de674358f9
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-11-18 14:47:44 +00:00
Christian Kandeler
ccf5daa16d ProjectExplorer: Un-tighten the RunConfiguration::isConfigured() check
Only report a run configuration as unconfigured if it has a fundamental
problem that should inhibit automatic creation.
Adapt the potentially reported issue in QdbRunConfiguration accordingly.
The concrete reason is that for cmake projects, deployment information
is only available after deployment has happened, so the on-device
exutable is not known right away.

Task-number: QTCREATORBUG-24685
Change-Id: Ibe49649ebb001d3ba2b752c9c335687da9c08ce7
Reviewed-by: hjk <hjk@qt.io>
2020-11-18 14:37:19 +00:00
Alessandro Portale
97ed5ef910 Add missing "override" to functions of exported classes
...exported ones or "shared" by other means

Change-Id: Ic4cc7a71426845c46bf3994a62b73b4ab5da321e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-18 14:30:31 +00:00
Eike Ziller
4517edd894 Reduce clutter in System preferences
Vertically align some more things.

Change-Id: I6f106369252035e07a4b56e4b5b8f066b2338cb0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-18 13:55:05 +00:00
Eike Ziller
45429a3c44 iOS: Fix persistence of signing settings
The signing team / provisioning ID was saved in the settings, but while
restoring the state it was overwritten when restoring the "Automatic
Signing" state.

Fixes: QTCREATORBUG-24586
Change-Id: I46c4e89689c26aabad4831bf15da6223191e08b8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2020-11-18 13:46:01 +00:00
Johanna Vanhatapio
4e7665503f Doc: Update the Adding 3D Views topic
Task-number: QDS-3087
Change-Id: I8255064fcbf3cbfeb140ecdec8cbda9ca9342fe3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-11-18 13:43:37 +00:00
Alessandro Portale
caace5da7b TextEdtitor: Don't override SearchResultAlt1|2 in classic theme
Just use the defaults.

Change-Id: Iad655becbfc13dc793b336ea9d661ad861ef695a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-18 13:36:08 +00:00
Alessandro Portale
85e1e21dae TextEditor: Fix SearchResultAlt1|2 dark themes
Change-Id: Ie800352172a8dd31ccdb63de1904f46fcfe77d2f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-11-18 13:35:57 +00:00