Commit Graph

67787 Commits

Author SHA1 Message Date
Assam Boudjelthia
cb34bfc493 Android: add line breaks to new AVD warnings
Change-Id: Ie533c468717674959060c7732952892086f37640
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-03 15:10:00 +00:00
Assam Boudjelthia
54667ae51c Android: disable Ok button for new AVD dialog if there is error
Change-Id: I626e80f540e42d726f37cd4802a14a32fa46595d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-03 14:30:13 +00:00
Jarek Kobus
0dcdb43ddb Fix missing documentation when built with Qt 6
The default value for readOnly property of QHelpEngineCore
changed to true in Qt 6. We need to set it to false by hand.

Task-number: QTBUG-87783
Change-Id: I6b0d4f043797463b3437a6aef673eba8e1b9c3ad
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-11-03 12:10:49 +00:00
hjk
7add8a81db QmakeProjectManager: Use SelectionAspect in QmakeStep
For the Debug/Release combobox.

Change-Id: I494778c0f633a34a25a97217b94321ef1944e588
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-11-03 11:47:25 +00:00
Marco Bubke
c3873fcf40 Sqlite: Add change set iterator
Task-number: QDS-2998
Change-Id: I7bfa8af51d9d7e6122902ee132ad51019e20afb5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-03 09:19:54 +00:00
hjk
eedb702bb9 Meson: Make spacing and #include ordering a bit more consistent
Not 100%, but a step forward.

Change-Id: I6957edbd24c1652b228a96a68424b857603aae45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-03 09:18:10 +00:00
Leena Miettinen
3c7ab41e9e Doc: Update info about Android Manifest Editor
Describe package names, styling, screen orientation, and
screen resolution options in more detail.

Update and add screenshots.

Fixes: QTCREATORBUG-24863
Change-Id: Ie365f6c7c634e2035a50666fe35785df56e44596
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-11-03 09:18:00 +00:00
Alexis Jeandet
09eeab7737 Meson: partially clang-format all files
Change-Id: Ie621792417e89aa732311129f0cfa99a5147183a
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-03 07:24:17 +00:00
David Schulz
fc39cf18e1 Debugger: fix debugger in modified python environment
We do not want to pick up any python environment variables for the
cdbext python initialization which might change the module search path,
because we already contain the needed python modules in the zip file
next to the extension.

Fixes: QTCREATORBUG-24859
Change-Id: I0d597f42042d249529309263d71b0e740e903a48
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-03 05:01:15 +00:00
Eike Ziller
495dee98fc cmake build: Handle turning on/off libraries the same as plugins
Previously the library targets were added, but with EXCLUDE_FROM_ALL.
This had the effect that libraries were not compiled if nothing depends
on them, but lead to various issues: It wasn't possible to manually
control compilation, and it lead to the library targets still being
exported, leading to configuration errors when building external
plugins.

Implement the same mechanism with BUILD_LIBRARY_* as with plugins,
giving complete control.

Change-Id: Idea3371d130593c5c2fdceee374021b6923db0c9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-02 19:10:05 +00:00
Christian Kandeler
89644e4a06 CPlusPlus: Properly categorize usages in switch and case statements
Change-Id: Iafbbdcca23db38d82bbc5bb24a39dac2a6d0a764
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-02 16:03:28 +00:00
Christian Kandeler
e35dfd592f clangbackend: Fix highlighting for #include directives
These were falsely categorized as string literals. No one ever noticed,
because highlighting information for string literals was ignored until
baf25e4cdb.

Change-Id: Ib59fde04359aecb6da3995de1a9febbbf41b12c8
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-11-02 16:03:11 +00:00
hjk
9879820864 Debugger: Fix some instructions in manual tests
Compilers are getting better at removing unused code.

Task-number: QTCREATORBUG-24819
Change-Id: I8a677a4057312e9581e520ceae9ae63a2dc8bc43
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-02 13:44:49 +00:00
Thomas Hartmann
536bdef0c8 QmlDesigner.Rewriter: Fix regexp
Simply 'x' is a valid property.

Change-Id: Id18edeab60bbc45abcb9ae8937e0f4f4e938279c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-02 13:17:43 +00:00
Thomas Hartmann
9496732db5 QmlDesigner: Fix and cleanup tests
Change-Id: Id26c3447025744619e9bc80da202aaa49be9567b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-02 13:17:36 +00:00
Miikka Heikkinen
f166e18bfc QmlDesigner: Fix form editor occasionally failing to load content
It seems that form editor widget gets enabled when design mode is
opened, whether or not the form view is enabled. Therefore we need to
check the view's enable state in FormEditorWidget::showEvent rather
than widget's state to make the form editor content setup properly.

Change-Id: Ie865b98bb4c9f884f9297fe32fbf7ee02455e74e
Fixes: QDS-2926
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-02 12:55:35 +00:00
Miikka Heikkinen
b0984dada3 QmlDesigner: Show preview for more image and picture types
BorderImage, SafeRendererImage, and SafeRendererPicture items now show
their images in navigator preview image tooltip.

Change-Id: I52c2f2ab87b3489fdfbbabe52737c5b97b0cf3fe
Fixes: QDS-2921
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-02 12:55:22 +00:00
Miikka Heikkinen
798e0e623f QmlDesigner: Fix navigator preview tooltip issues
Immediately hide preview tooltip when hovered row changes.
Tooltip follows the cursor as it hovers over the same item.
Fixed the preview image label size.

Change-Id: I16aec577bd68735873517d04eb51d21b7975f2c6
Fixes: QDS-2908
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-11-02 12:55:07 +00:00
Miikka Heikkinen
95c27ea4c8 QmlDesigner: Remove "locked" auxiliary data instead of setting it false
Since absence of locked property implies it is not locked, simplify
the auxiliary data by just removing the locked property instead of
setting it to false.

Also remove unused private method ModelNode::removeLocked().

Task-number: QDS-2915
Change-Id: I27904514f168c28138b6311278f60565fc810f00
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-11-02 12:54:39 +00:00
Christian Stenger
873566d743 PerfProfiler: Fix test generated data
Amends 67c800af6e.

Change-Id: I8e8bda0373ec70bda94f2fef74710d6125dfcace
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-11-02 10:11:13 +00:00
Alessandro Portale
dca5cb4f14 Don't animate TreeView expansions
Some styles set a QStyle::SH_Widget_Animation_Duration. An animation
does not go well with just-in-time population of the expanded content.
This change avoids that for all TreeViews.

Fixes: QTCREATORBUG-24834
Change-Id: I16ca4c61733d8875e713d7349ed6b99ba37ecf74
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-11-02 09:28:49 +00:00
Christian Kandeler
76ae5780c4 CppTools: Fix function decl/def look-up
... in the presence of macros.
For instance, renaming a parameter of a function preceded by some sort
of DLL_EXPORT macro would not offer to apply the change to the definition,
because the macro gets expanded and the respective tokens have bogus
offsets derived from the place where the macro is defined.
Luckily, such tokens are marked as "generated" and we can skip them for
the purposes of retrieving the actual location of the function.

Fixes: QTCREATORBUG-24739
Change-Id: If5db355b1c301060a17a687c2b5582fa1ef17d3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-11-02 09:08:21 +00:00
Assam Boudjelthia
7b3accc78e Android: update ndk version
Update NDK version from 21.1.6352462 to 21.3.6528147, the most recent
one.

Change-Id: I0d5f33e78816464c6dab3303488aa353662bff47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-11-02 08:29:45 +00:00
Eike Ziller
8e69decd69 Revert "ClangFormat: Relax the clang format file a little bit"
That change does an experiment on the clang format file without
discussing the results before. It wasn't tested and discussed on a
larger code base, and ignores tests/manual/clang-format-for-qtc.

Individual ("pre-discussion") experiments with the clang-format file
should be done in a separate experimental version instead (e.g.
somewhere in dist/).

This reverts commit 009c2745e2.

Change-Id: I5f9fa50d2ccc63807218ae5d193a3a0718956576
Reviewed-by: hjk <hjk@qt.io>
2020-11-02 08:10:46 +00:00
Lukas Holecek
4e28aed405 FakeVim: Fix deleting selection on search command-line
Change-Id: Ie01dd84cf87db2d999c10352285c0ee8366aadc1
Reviewed-by: hjk <hjk@qt.io>
2020-11-02 07:56:56 +00:00
Eike Ziller
c135f4a253 cmake build: Fix documentation generation with Qt6
qhelpgenerator moved to a separate package "Tools" which doesn't exist in Qt5.

Task-number: QTCREATORBUG-24098
Change-Id: If7d0d638d6cee27f9154141ca415fb412745d1ee
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-11-02 07:09:40 +00:00
hjk
0f786153f0 Utils: Add docs for some StringAspect functions
Change-Id: I505de81e841db3efb49161cb90b7c60cc22aba8b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-30 15:30:25 +00:00
Eike Ziller
1cd87a05b5 Fix build with newest Qt6
Task-number: QTCREATORBUG-24098
Change-Id: I8ced79ecd590dbeeb3038054e75ee0632ca37462
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-30 15:17:15 +00:00
Eike Ziller
d54f7b0eb2 Fix building tests with Qt6
Task-number: QTCREATORBUG-24098
Change-Id: I192245125f04f8350597bbe481d80d3f8ba0cae0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-30 15:15:25 +00:00
Christian Kandeler
659771f09b Debugger: Provide keyboard shortcuts for "next" and "previous"
... to applicable analyzers.
Rather than inventing separate shortcut categories for all the
analyzers, we make use of the fact that only one analyzer view is active
at any given time, and make them use the same shortcuts for consistency.

Fixes: QTCREATORBUG-20659
Change-Id: Ifa60080def0e6b32395854cff588ab3af9ea33b9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-30 12:20:58 +00:00
Christiaan Janssen
9cd5fb927d McuSupport: generate kits automatically on plugin initialization
Fixes: QTCREATORBUG-24354
Change-Id: I26587102bd24d1678707ca1d9160c84149e77c8e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-10-30 11:07:27 +00:00
Orgad Shaneh
b7c72f8621 Debugger: Do not discard macros when clicking on source mapping
Fixes: QTCREATORBUG-24816
Change-Id: I7e541d3edb7601cf91064ba30059e4a8f0aa6064
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 10:15:23 +00:00
David Schulz
43b25e6d99 Debugger: Fix breakpoint enabling
Change-Id: I496d0b90dd572d4f4949c98d5abe035edfba8d19
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 09:51:12 +00:00
Eike Ziller
acd2aaa0f0 cmake build: Add missing rcc alias for Qt6
Change-Id: I353ded95f8ee8fd263d7a9f830cdcf662a250bd1
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-30 09:20:19 +00:00
Christian Kandeler
247a432f74 ProjectExplorer: Fix project window layout restore behavior
Steps to trigger the problem:
1) Start Creator with some fresh settings path.
2) Open an unconfigured project.
3) Observe a normal-looking target setup page.
4) Configure the project.
5) Close the project.
6) Remove the .user file.
7) Re-open the project.
8) Observe a target setup page whose left part takes up almost all the
   space, leaving the main project widget practically invisible.

Conclusion: The configure page does something to the widget state that
breaks the restored layout. I don't know what it is exactly.

Fix: Slightly delay restoring the widget layout.

Change-Id: Id88ea12267a7dd0fe54749c18b0761d0e873d646
Reviewed-by: hjk <hjk@qt.io>
2020-10-30 09:11:31 +00:00
Johanna Vanhatapio
18bd2314fb Doc: Reposition the All Topics link
Fixes: QDS-2961
Change-Id: Ic7f67336a3310c743c7d31ff90506ff4f6db7725
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-10-30 09:02:56 +00:00
Christian Kandeler
ee96c2d9fc ProjectExplorer: Fix assert in MakeStep
... when it's part of a deploy configuration.

Change-Id: I56340ea5553a267daa04b5fd89aff382ec1d27cd
Reviewed-by: hjk <hjk@qt.io>
2020-10-29 17:02:55 +00:00
Johanna Vanhatapio
77b91fd4a9 Doc: Describe Best Practices in QDS
Project files for the example scene will be added as a separate task.

Task-number: QDS-1243
Change-Id: I0bc9bd861d2b6a3c58372cedb2395deb3c78f590
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-10-29 15:32:40 +00:00
Eike Ziller
bf8879ee5c TextEditor: Add missing file to dev package
The public header "textdocumentlayout.h" includes "State" from
KSyntaxHighlighting, so we need to export that.
Since it doesn't have the ".h" extension, it doesn't get exported
automatically either. Add a generic function for adding such special
public header files.

Fixes: QTCREATORBUG-24413
Change-Id: I841e6d601df7e925f48eedcc2a28d6b43c00350e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-10-29 12:58:52 +00:00
David Schulz
f44c447874 ClangTools: enable goto actions for a single diagnostic
Usable nowadays since the action also opens the diagnostic location.

Change-Id: I24a0df606fec5d7e84a2f3450317864f62a4e118
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-10-29 11:44:53 +00:00
Eike Ziller
d5d5068009 Bump version to 4.14 beta2
Change-Id: Ife5666e272697da19e1ba1a96d93281943deb37e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-29 10:24:08 +00:00
Leena Miettinen
31b792a72f Doc: Add missing steps to tutorials
Streamline terminology and make some other changes
according to reviewer comments.

Change-Id: Ice84bd55fcb0ed549693c5c471827efc10a627d5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-29 09:30:08 +00:00
Leena Miettinen
03191936c4 Doc: Update information about using gradients
Describe setting properties for linear, radial, and conical
radients that are supported for Studio Components.

Add screenshots and a gif that illustrates adding and
removing gradient stops.

Change-Id: I9dfbee044b0ae37b217cc833c77f886c391292ba
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-29 09:28:31 +00:00
Eike Ziller
724fd58a3b Merge remote-tracking branch 'origin/4.14' into master
Conflicts:
	src/plugins/cppeditor/cppquickfix_test.cpp

Change-Id: I470ee35f54f883244d819531131c172bd25c0e3f
2020-10-29 09:18:31 +01:00
Henning Gruendl
c019860809 QmlDesigner: Update the Stack (z) context menu
* Rename arrange menu and items
* Remove the "Reset z property" item
* Add reverse item and functionality
* Fix some related typos and formatting

Task-number: QDS-2938
Change-Id: I0e706aefdaed99b28faae4b307146847a54a24ed
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 16:43:30 +00:00
Christian Kandeler
b30b2f481c ClangTools: Make "go to next/previous diagnostic" open an editor
It's very likely that the user will want to have the respective location
displayed in the editor.

Fixes: QTCREATORBUG-20658
Change-Id: I34128c6444208571df566725e2ad1675d4456853
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:28:24 +00:00
Leena Miettinen
652feacd5f Doc: Describe Positioner and Layout type properties
Move positioning to a separate topic.
The information in this topic is related not only to the
Library view, but also to the Properties and Form Editor
views.

Describe the properties of the Positioner and Layout types.


Change-Id: I9d00bc9498499f52ecf49463df7f651aaecf8f0e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-10-28 14:04:04 +00:00
Eike Ziller
ee1e6ca508 EditorManager: Avoid changing the editor in between when closing editors
Do not call setCurrentEditor(nullptr) since this sends a
currentEditorChanged signal which claims that no editor is active, which
can lead to unnecessary updates.
In the specific case, the git branch view was updating with the project
directory as a new repository, and then, after the actual new current
editor was set updated again with the repository of the editor.
This can be needlessly expensive if the previous and new editor are in
the same repository, but the project repository is something else, like
when having the Qt Creator super-repository open, or when editing files
unrelated to the project.

Change-Id: I515c3c40a86bfa2713ff13460ddfda974bc08c59
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-10-28 14:02:27 +00:00
Eike Ziller
30017685e7 build.py: add --add-module-path
Which prepends a path to CMAKE_MODULE_PATH which is required for branding.

Task-number: QTCREATORBUG-22488
Change-Id: I6b0015778d8ceec7183740e5b70eaafd220a3bdf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-28 13:57:59 +00:00
Eike Ziller
3476b8aa67 Consolidate some options for build.py and build_plugin.py
Change-Id: Ic745231ed68296f8052e3b0897893ee8fce53b16
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-10-28 13:57:53 +00:00