Instead of replacing them with "element" add a suffix.
Change-Id: Idc72ba9a8a7b4f48d4e325378b975cafeab88bd4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
We got the install command name wrong, which caused the installation to
fail. In addition, we forgot to add handling for the "protocol-error"
message from qbs, so the step was hanging, rather than aborting.
Finally, we triggered a number of assertions in
BuildStep::buildConfiguration().
This went all unnoticed for a while, because the install step is not
enabled by default these days.
Change-Id: I906e7e472563d4ad8fc7557bd706a7cb67f9f2ba
Reviewed-by: hjk <hjk@qt.io>
The installers are copied to the QtDesignStudio folder by the
Qt online installer.
Task-number: QDS-2542
Change-Id: Ib5e9bbb3c7a2cf03a4abd3e8b39759173a37ad5a
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Allow to set a default value for the PathChooser which will
be used on the one hand as placeHolderText and on the other
hand for the default validation if the underlying line edit
has no text set.
Change-Id: I49d2f773cf3933cb30b54ee6de82290b480e743d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This basically continues / amends work done
with e1c88116b3.
Change-Id: Ia8b3a4694e7fea4c15e344839f87c11fbe8fbbf4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
BuildStepConfigWidget with manual tweaks is good enough.
Also move AndroidDeployQtStepFactory to the usual place at the
end of the file.
Change-Id: I92af31ef77f986b6fcd84a14ac62b70e2da32ff2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
First step is to inline mesonbuildstepconfigwidget.ui.
As side effect, don't skip row 0 in the form layout and drop the intermediate
QFrame/QVBoxLayout level and insert the searchable wrapper directly.
Change-Id: Ibf2e348b2990ba48126ad7b92e98d0bcd8116196
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Next step towards NimbleTaskStep aspectification.
Change-Id: Ifdb7d942e29ab99da01c6797d1edddd68afc5e30
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
A step towards NimbleTaskStep aspectification.
Also remove the intermediate QFrame, QListWidget is-a QFrame itself.
Change-Id: I1e37dc28ef2c8a89aff7c4baff0c1bd82ff3306f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This was only used for setIgnoreReturnValue(), which can be done
directly and also does not need to be stored in the settings.
Change-Id: I7419efe66d164b223463e19c3daf2350b4a2bae4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
On all code paths, this was implicit in a ProcessParameters::setCommandLine()
which was on all code paths either called directly immediately before, or as
part of ProcessStep::setupProcessParameters().
With ProcessParameters::setCommandLine() as only user, this could be
inlined there. The effectiveWorkingDirectory() turned out to be out of
place and rather accidentally working there and was moved to
ProcessParameters::setWorkingDirectory().
Change-Id: I634f6086c2324e3cbecd3e5d50e22afc722abd3f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Special QbsInstallStepWidget can be dropped.
Change-Id: I9040bbaa59c9da201c66a60a6ce9285cd53cf607
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Align also after the leading asterisk.
Fixes: QTCREATORBUG-11749
Change-Id: Ic054598c80206bf38b74345aed20d88486f57cad
Reviewed-by: David Schulz <david.schulz@qt.io>
Each call to PluginManager::plugins() creates a new QVector object,
iterators are only comparable for iterators from the same vector.
It worked in practice because the underlying storage was the same
here as the QVector objects were only shallow copies.
Change-Id: I2e276535942bd949acf91e12873c7bdf9d5c34d6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There are Import and Export buttons in View > Workspaces > Manage.
Update screenshots and add one of New Workspace Name dialog.
Change-Id: I679b7952e498576a58ebb4134d08c21fe2555fc7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The getClangResourceDirAndVersion() function in ClangTools could return
the actual resource dir or the include dir, depending on the input. This
mistake happened because of misleading names spread all around the code.
Now the function returns what it says, and the other names are accurate
as well.
Change-Id: I0a8600857ee7b9fafb16256e0d1ad203ac3273d2
Reviewed-by: David Schulz <david.schulz@qt.io>
... so they show up in the project tree and search results.
Change-Id: I42ae1f0c2f96ea07952c7b23bd809cddd938c69f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Built-in compiler macros are normally not passed to the code model,
because of potential conflicts with clang. However, in the case of custom
toolchains, these macros are provided by the user for the explicit
purpose of making them known to the code model.
Another exception are the bare metal toolchains, for which we now make
sure we won't get out of sync when new ones are added.
Fixes: QTCREATORBUG-24367
Change-Id: I2a0458d9132fdff15eb9adfcb2c06d7ef72508bc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It's not an error that a build directory does not exist.
This reverts commit 2e4915bdb9.
Fixes: QTCREATORBUG-24503
Change-Id: I6138917885b6adbfaef6c49e54a3ea9900ed6b2e
Reviewed-by: hjk <hjk@qt.io>
... as replacement for OverrideMakeflagsAspect.
Change-Id: Id8a3ccde7bf3b7c62679e927a82ce7d6acd37e66
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This notification is only for debugging and breaks encapsulation.
Change-Id: I20faeb76d24cc42417b3cc2e289041c70edd6157
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Also describe that custom properties are visible in the
Properties view, where their values can be set.
Change-Id: Ie82975116ae4de0ebb92050e7e2190315521ff8b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Quick3D has some properties that are named same as default ids for
some other types, causing conflicts. Blacklist offending properties as
ids.
Task-number: QDS-2636
Change-Id: I988c69f61608ad7d80726dd74747917360827b84
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This restores using an additional icon for the
label, but limits it to common ones.
Change-Id: Ic9b1a419525d1fefb071b9f612e910b56a600edf
Reviewed-by: hjk <hjk@qt.io>
That is, also do function-specific magic on typing "/**<return>" in front
of a function if there is an access specifier such as "public:" in
between.
This use case is rather weird, but it's also pretty easy to support and
it should not hurt anyone.
Note that depending on the indentation of the access specifier, the
indentation of the inserted comment will probably not be what the user
expects, but this is not easily fixable.
Fixes: QTCREATORBUG-20311
Change-Id: Ie32a71eede91ef64a19381c8e379a183a91fd27d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Clean the paths before adding them to targets.
This prevents the code completion from showing multiple identical
entries when completing an #include.
It also removes ~2MB from build.ninja.
Task-number: QTCREATORBUG-24514
Change-Id: I19f3df400e65d8dfc4747415a8e14dae05d4b88c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Since external plugins are interacting with the puppet
we need them in the dev package.
Change-Id: I871629ad80583a09b842bb60cd5b6fab5b512fae
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
