Commit Graph

67787 Commits

Author SHA1 Message Date
Christian Kandeler
537e2e23ff CppEditor: Work around cmake bug
If you mention "Q_OBJECT" in a raw string literal, the cmake build
fails...

Change-Id: I9004184b48dea9a77b9303c3fd871cef747ade4c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 13:30:18 +00:00
Christian Stenger
a826267cd4 Tests: Fix nullptr access
Change-Id: I4e2bf36dfa6e16dfd9924c865bd9a997750243a2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-30 13:24:48 +00:00
Christian Stenger
394b3212bb Tests: Fix condition
Amends eb52982c9d.

Change-Id: I47b145b678eafab90f3569e4f6a785f272a87666
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-30 09:13:47 +00:00
hjk
efc39f971e Qt6: Workaround for ListModel iterators
Change-Id: I622b42b8aea4f06b62e8739f7e8abb234ed7d3b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 07:04:03 +00:00
hjk
5363256acd Qt6: Port some uses of QApplication::desktop()->availableGeometry()
Task-number: QTCREATORBUG-24098
Change-Id: I3bf911402084fb26110a89992cb5f1d61c2f46e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-30 05:56:00 +00:00
Christian Stenger
0950940c35 LanguageClient: Improve outline
For non-hierarchical symbols probably no difference,
but language servers providing hierarchical document
symbols will benefit.

Change-Id: Icab7ac74a7780ee72c556955867a0ad7da3d8a02
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-30 04:56:20 +00:00
hjk
6c590531b0 Small Qt 6 migration stuff
- qsizetype vs int
- QJsonValue vs QJsonValueRef
- #include for metatype system

Task-number: QTCREATORBUG-24098
Change-Id: I066d9e3d5c35766b8aa3adc1c5835b23feb20b37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 14:03:19 +00:00
Christian Kandeler
77d13f08ba CppEditor: Let users create implementations for all member functions
... in one go.

Fixes: QTCREATORBUG-12164
Change-Id: Ifc81c8b1caf4319ce57882375f513d72e4c0ea52
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 11:56:07 +00:00
hjk
120540f1db ProjectExplorer: Add BaseIntegerAspect::setToolTip()
Change-Id: I7a9fe0695b30c926d6b3e11302a4a8eaadfa2b16
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-29 11:18:16 +00:00
Christian Kandeler
5e2abd7181 Fix qbs build on macOS
Change-Id: I7d6e52092ac5bd597f9e8b87ceab665894b37e0b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 10:59:54 +00:00
Christian Kandeler
4e9951af3a CppEditor: Consider operators
... when looking for reimplemented member functions in the "Insert
virtual functions of base class" quickfix.

Fixes: QTCREATORBUG-12218
Change-Id: I6e37e28ab747a76dcc97df242bd6c6199fbc7e2e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-29 10:29:45 +00:00
Alessandro Portale
6c45c3fb1c CppTools: Bump TIDY_DOCUMENTATION_URL_TEMPLATE from 8.0.1 to 10.0.0
Change-Id: I198f805768984eb060b2a72f705e618e6a7a53ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-07-28 19:37:51 +00:00
hjk
c467ae6114 Android: Drop special AndroidPackageInstallationStepWidget
A base BuildStepConfigWidget with a summary updater are good enough
nowadays.

Change-Id: Ic8df7662cc28969786fd93171c53ec428a09db58
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 19:08:30 +00:00
Robert Loehning
0c26c3602d ProjectExplorer: Fix indentation
Change-Id: Ia38b19eb50f46917713766d3d1aa9308dcbe5a7c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 18:27:57 +00:00
Robert Loehning
fb17795a9f Android: Add missing full stop and fix message
sdk_definitions.json does not have to contain 'lldb;x.y' anymore
as this is part of the base installation nowadays.

Change-Id: I39bc988674a8e60b22cd852b890224ac1c87e8c8
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 17:46:17 +00:00
Christian Stenger
002b3907f6 QmlJSTools: Fix plugin unit test
Amends 58ea14aea7.

Change-Id: I27d68572cffd9d2e37b3dbf8c47c75633db5d806
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:43:29 +00:00
hjk
412ffe55bb ProjectExplorer: Move MakeStepConfigWidget::updateDetails()
... to MakeStep. Next step towards full aspectification.

Change-Id: I64763a96e549a557015ed42c82d7599604788c4f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:18:01 +00:00
Leander Schulten
755659e663 CppTools: Prevent SegFault in the ClangFormatIndenter
If you create a ClangFormatIndenter but do not set the
fileName, the indenter will SegFault while indenting.

Change-Id: I93a56d7916bc1a02da9ee21a116bd48b4405edb1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 14:17:54 +00:00
hjk
200d81d38c Nim: Aspectify NimbleBuildStep
Change-Id: I0f166e68590901568edfd590606df57e25111b9a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 13:38:54 +00:00
Christian Kandeler
cf20d44b4a qbs build: Make unittest work with sanitizers
Change-Id: Ie6153a4505f42a1c9754d6af951c72df0065ec1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-28 13:33:51 +00:00
Christian Kandeler
dfe5eb3b11 GCC parser: Recognize messages referring to scope
... such as "foo.cpp: In member function 'bar': ...".
These weren't caught at all, because the file name has no line number.
They did show up in the issues pane, because the ld parser accidentally
caught them, but they were not properly merged with their context.

Change-Id: I29a757879c21a051cb31c65497b3ad2bfff2315e
Reviewed-by: hjk <hjk@qt.io>
2020-07-28 13:31:08 +00:00
hjk
0e5cc282e6 ProjectExplorer: Small code cosmetics
Unused declaration, const, ..

Change-Id: I0de544ba9be36a291fec5d1ab187e038a4fcc464
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 11:59:22 +00:00
David Schulz
91e78936fe LSP: prevent nullptr access
Found by coverity scan

Change-Id: Ibc243abbb40cde8c670084c9486fdd2f47b137de
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-28 11:35:17 +00:00
Robert Loehning
cf183a898d Android: Clarify error message
Change-Id: Id85c6a96ec2ffcb3bfd027ffdcc99ff97e1dd8ac
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-28 10:40:58 +00:00
Leander Schulten
fdd70d898d CppEditor: Don't create 'namespace xyz{}' if there is 'using namespace xyz'
Change-Id: Idc08de5f44ccac0de8490158199c4e44f7efe79e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-28 09:53:48 +00:00
Assam Boudjelthia
88be337b0d Android: change openssl error dialog Ok to Cancel
Change-Id: Ib2be438e330c969a2ddb46db35c8f11e5cf94e9e
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-28 09:43:55 +00:00
Christian Kandeler
8469886ab8 Valgrind: Fix test failures
Change-Id: I4b8b69ecdf537f38d062dc62cf6c91ce92edcd8a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 14:26:01 +00:00
Christian Kandeler
3d718d3dae qbs build: Fix valgrind test failure
Change-Id: I563d9b61e0e281058dac46ed913b3102f70c4d90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 14:25:07 +00:00
Christian Kandeler
e34ff64196 qbs build: Add convenience properties for sanitizers
Change-Id: I8c0908ed482127712c1cf4052d7b792be5ba79ae
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:56:34 +00:00
Christian Kandeler
a54d24d497 VCS: Fix unit tests
... when building with cmake or qbs.

Change-Id: Ib3a04da6e145a21e60488dab80c5fde86eaaa06b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:56:14 +00:00
hjk
557d7723eb Debugger: Fix Qt6 QBitArray dumper
Task-number: QTCREATORBUG-23390
Change-Id: I8f233524d1daa7afe65b4414e5c9926dce9811e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:21:05 +00:00
hjk
4a434e14d5 Debugger: Fix QList dumper for Qt6 empty lists
Plus some cosmetics.

Task-number: QTCREATORBUG-23390
Change-Id: I959437902b74d234372c60055ef2f774f411850c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:20:57 +00:00
hjk
961560df6f Debugger: Fix Qt6 QString/QByteArray dumper
... for the fromRawData() case.

Task-number: QTCREATORBUG-23390
Change-Id: Ic603df428d03aa61f0fcde4e090d36231a7e05d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-27 13:16:54 +00:00
hjk
fca6eee65c ProjectExplorer: Make ArgumentsAspect resettable
Useful for NimbleBuildStep and similar to what WorkingDirectoryAspect
has.

Change-Id: Ibd88f84b5d150af7cbf74bda89a45494a4521998
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-27 12:18:15 +00:00
Eike Ziller
9dd28206cd Bump version to 4.13.0-rc1
Change-Id: Icc4b98903a16d05d978ad27c2aeffac8dbf22227
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-07-27 08:40:11 +00:00
Robert Loehning
dcbf15cf2e Core::OutputWindow: Use proper numerus form
Change-Id: I0c8da8a49a436ff9f8bcdcb02756be1734406df2
Reviewed-by: hjk <hjk@qt.io>
2020-07-27 08:03:41 +00:00
Alessandro Portale
7b6d44a90a Android: Introduce constants for Android ABIs
Avoiding string duplication prevents typo-related runtime errors and
allows an IDE to use find symbol rather than plain text search.

Change-Id: I7fba7c7c5cf90c0b371efce3b575537b2708dd0f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-07-26 05:49:49 +00:00
Richard Weickelt
a149ccd2d2 Update qbs submodule
To HEAD of 1.17 branch.

Change-Id: Ic9015ebc7bb77b2ae6d9a10fd93d1e4a5279ff1d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-24 14:25:23 +00:00
Andre Hartmann
e903f9e350 Git: Fix quoting of repository name
... in the "Uncommited Changes Found" dialog.

Change-Id: I7f987786f4aada47983b849419e2443311dec75f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-07-24 14:04:15 +00:00
Christian Kandeler
bed084bd74 qbs build: Fix meson autotests
Change-Id: If2f57ac6fd622dae69a736a89d90f76c7653eee0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 12:15:38 +00:00
Christian Kandeler
b484d770cd QML code model test: Show unexpected messages
The failure output is not very helpful without them.

Change-Id: I827876336c3ffdebb0b071f6d1a743c6766d92fb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 11:01:43 +00:00
Cristian Adam
3b8f51391b UnitTests: Re-enable CMake unittests
Ammeds 327bec26bf

Change-Id: I34b62532da424b3b4fb0290049150f6ba444283b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-24 10:05:45 +00:00
hjk
13d0930575 Debugger: Fix QVariant2 autotest
Amends eb52982c9d.

Change-Id: I8ca2e2b03d0d5755c97523292fa6b4fbe0882cb7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-24 08:15:47 +00:00
Tim Jenssen
49bce1d9e6 qmlpreview: fix compile
Change-Id: I7c9b82637217e45c6d239413df07cc9d62440603
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-07-23 17:05:29 +00:00
Robert Loehning
7ce989a306 VcsManager: Tell user which file is going to be deleted
Change-Id: I72a853cf65d0bd697379c1738657f098243b814d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
v4.13.0-beta2
2020-07-23 15:48:13 +00:00
Robert Loehning
5c0b3196ef ProjectExplorer: Fix iterating through files to remove
Change-Id: I680f8e40248dbbf4f4ee76765fad7a99944b0a5f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 15:47:39 +00:00
Robert Loehning
1203be0bc3 ProjectExplorer: Don't prompt user whether 0 files should be deleted
Change-Id: I893c8af5e2c0f0172dd397732275bdec9918bc44
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-07-23 15:47:10 +00:00
Assam Boudjelthia
7775334998 Android: regression fix for warning missing ANDROID_ABIS
Ammends 27514fa94d.

Task-number: QTCREATORBUG-23291
Change-Id: Iadf33f9c60a738c9ee4c810bb065667cab29aa92
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-07-23 15:16:03 +00:00
hjk
004e5ad83d Sqlite: Suppress deprecation warning when using C++17
Change-Id: I90f452230cd7a2975674e3d17bd6c930914f90d5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-07-23 13:27:45 +00:00
Christian Kandeler
73f3056c3e CppEditor: Add class member from member initialization
That is, if a class member being initialized is not yet declared, offer
to add the declaration.

Fixes: QTCREATORBUG-11842
Change-Id: I1d2a56ab99543e996e220aa26b7923023dd163f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-07-23 12:57:29 +00:00