Commit Graph

67787 Commits

Author SHA1 Message Date
Marco Bubke
4b7aeae749 Sqlite: Add check constraint
Change-Id: Ib4b909da40c7fe07dcb6a07c4650a720313391c2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-14 10:30:44 +00:00
Leena Miettinen
f51258a17c Doc: Move Qt Bridge product name macros to the common macros file
..from the Qt Design Studio Manual doc configuration file.

Change-Id: Iebbfb5404cae4ef277f05c867e7259997b19a27e
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2020-05-14 10:18:31 +00:00
Tim Jenssen
9936b92de3 fix visit from future using
Change-Id: I66387627c03de501a9effbb453c17a298437d8c1
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-05-14 09:58:28 +00:00
Marco Bubke
77c81aa8b0 ClangPchManager: Fix tests
Change-Id: Ide9adf326dda4b995636d629a6b2eed829f42b34
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-14 09:52:55 +00:00
David Schulz
8f5109b6ee LSP: Robustify open documents
Use Client::openDocument if you just want to open a document and
activate it if it is not already used in another client.

Use LanguageClientManager::openDocumentWithClient if you want to make
sure a document is opened _and_ activated for a specific client.

Change-Id: I6b790f15e17335ce2dc8981a04d2cd571b22b66b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-14 09:51:26 +00:00
David Schulz
f3407bb0ca LSP: fix codeassists running check
Since MessageId is always valid (needs to be fixed separately)
use an optional to store whether we have a request running.

Change-Id: I7a1f136a09d776b33509bc914247d11076abeaa5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-14 09:46:55 +00:00
David Schulz
32d29f5a11 LSP: do not create empty function hint proposal model
Fixes:
SOFT ASSERT: "d->m_totalHints != 0" in functionhintproposalwidget.cpp

Change-Id: Ibfda27bf1e02b60d624851995ce1f5f54f662182
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-14 09:46:37 +00:00
Denis Shienkov
98be9d4f6d BareMetal: Auto-detect IAR toolchain for AVR32 architecture
This patch implements auto-detection for the AVR32 toolchain,
provided by IAR Systems:

 * https://www.iar.com/iar-embedded-workbench/#!?architecture=AVR32

Change-Id: I6638a2b499586ed3212e6fcdf704164a0d1cc9d0
Reviewed-by: hjk <hjk@qt.io>
2020-05-14 09:28:08 +00:00
Eike Ziller
53cf4aa3c5 Fix availability of "Link with Qt" info bar
The info bar should never appear if the button is disabled,
for example because the Qt Creator directory is not accessible.

Fixes: QTCREATORBUG-23900
Change-Id: I819c87f5ca51f69f34bd462fca8e877be3544100
Reviewed-by: hjk <hjk@qt.io>
2020-05-14 09:21:26 +00:00
Marco Bubke
c4bbc74e37 Sqlite: Improve constraint support
Now you can add more than one constraint. And we added some
new constraints too.

Change-Id: I849d2d2ef6e44c897a65ff2bdfe8d172a345c991
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-14 09:15:00 +00:00
Marco Bubke
a86fd58e40 Sqlite: Improve LastChangedRowId
Sometimes we want not only the row id from one table but two or three.

Change-Id: I6d5444a71ecbfe6c1af8073be80b04932ea9268d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-14 09:14:35 +00:00
Nikolai Kosjar
567b61eee5 ClangTools: Fix placeholder in tr()
Change-Id: I90727287ebdbe12b8e422e7e91adc9f3e5abafbd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-14 08:41:54 +00:00
Christian Kandeler
b02f6b5d30 ProjectExplorer: Give the Task class an explicit summary
We'd like to create more useful tasks from compiler output, that is, try
harder to identify consecutive lines that refer to the same issue and
create one task for them, rather than one for each line. In such
"aggregate" tasks, the first line will not necessarily carry the main
information. Therefore, we make it explicit what this main information
is by introducing a dedicated summary member.
Also streamline the font handling for compile tasks.

Change-Id: I933f2643a13c710dab1ab548c56669b129026eb5
Reviewed-by: hjk <hjk@qt.io>
2020-05-14 08:23:59 +00:00
Denis Shienkov
e35f945758 BareMetal: Add AVR32 architecture to the ProjectExplorer::Abi
Change-Id: I2d70dda8d91bccc34b6e1c16c70bc5b3e0ca1b1f
Reviewed-by: hjk <hjk@qt.io>
2020-05-14 07:40:53 +00:00
hjk
776fd7961a FakeVim: Treat C-S-something as "not normal" in Input::is()
The problem triggering this change is that recently, C-S-s was not
handled (as "Save all") anymore when there was nothing to change,
and the keypress ended up in FakeVim. Now FakeVim filter for _exact_
C- modifier in Input::is(), letting C-S- pass as 'S-s' i.e. starting
replacement of the rest of the line.

Change-Id: I13499f5606c28fee148e410355bec7ffd6ed116a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-14 06:22:13 +00:00
Nikolai Kosjar
cdc97f523e Debugger: Fix warning about unused variable
Change-Id: Ib26f94d54f7e9570efa69cdfefa4253b640bc664
Reviewed-by: hjk <hjk@qt.io>
2020-05-14 06:17:54 +00:00
Nikolai Kosjar
2fb43e6e04 Clang: Fix typo in tests
Change-Id: I37ce70c06f98d6bc5f359f9fe34fd73a1cc51795
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-14 05:19:36 +00:00
Christian Kandeler
c563046145 ProjectExplorer: Fix possible crash in RunControl
There is not necessarily a run configuration.

Change-Id: I53e0a0ab322bcf1cbac2cbb6944602aeed933432
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2020-05-14 04:43:22 +00:00
Michael Brüning
b84025cd3a Fix build on macOS
Commit 0e7a1e6650 was missing an
include for QDebug.

Change-Id: I34421f634c40984750daeac31eed9191a9128f87
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-13 14:55:53 +00:00
Andre Hartmann
cbb70513bf Git: Allow colorful logs
Requires Git 2.3 or higher for RGB colors.

Can be enabled for the normal or graph log
with the "Color" tool button. For the diff
log, the old behavior is kept (highlighter
is used for the "normal" log, no colors at
all for the graph log)

Fixes: QTCREATORBUG-19624
Change-Id: I8a42a7ad0ebf99ceb459355310311d702dcf9977
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-13 14:03:46 +00:00
Nikolai Kosjar
3ddf93ba64 Clang: Remove dead code code path from tests
Change-Id: I75445ad849b701b648e53d120d4796f29092ba15
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-13 12:57:16 +00:00
Christian Kandeler
2c5d6de9b4 ProjectExplorer: Ensure that the session model stays sorted
Fixes: QTCREATORBUG-23996
Change-Id: I96c8c1b780f5b56cb064146de3de6a4c90f9147a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-13 12:48:04 +00:00
David Schulz
689fac8fe9 LSP: Fix wrong assert
Change-Id: If1015ba4f1d5519ac379e4c4b1cca8ffbf2c52ae
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-13 12:16:00 +00:00
Vikas Pachdha
f362304169 Add library export documentation for Sketch Qt-bridge
Task-number: QDS-2046
Change-Id: Idca24fdac106da1b6631518ddd9bb9fa7253a8c7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-05-13 11:45:46 +00:00
David Schulz
4749550fbc Debugger: use correct environment for the cdb process
Change-Id: I7027be25df7380810b7c8fbd0e9bc5b9abd67dc3
Reviewed-by: hjk <hjk@qt.io>
2020-05-13 10:59:10 +00:00
David Schulz
cdeac76df3 LSP: react on file list changed signal from project
Fixes opening projects that lazy load their file lists. For example
CMake projects open without a file list. This list will be generated
after a successful configuration of the project.

When a session is loaded that contains an open document from a project
the document and project open signal is triggered when there is still no
connection between these two. So recheck the project for documents after
the file list got updated.

Also add documents that are already opened before they are assigned to a
project.

Change-Id: I6f2bde0edf88a505116b05efe5564318f2cfb892
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-13 10:58:25 +00:00
Eike Ziller
172833bb1e CMake build: Allow files with relative paths in qtc_copy_to_builddir
Files with absolute paths still go directly into DESTINATION directory.
Follow-up of a9aa561234

Change-Id: I558616f78b3e49a8b3be4372791281f5ca9138c9
Reviewed-by: Alexis Murzeau <amubtdx@gmail.com>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-13 10:37:12 +00:00
Leena Miettinen
a12669292e Doc: Remove link to non-existing tutorial
Part 5 is still a work-in-progress.

Change-Id: I7c8cd07be3921b9fd36eeb913d9e393e6f15d895
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-13 09:49:50 +00:00
Thomas Hartmann
6839d2471e QmlDesigner: Change default canvas size to 40000
This is required for the FlowEditor and the canvas size
does not really have an impact.

Change-Id: I0d5c36ea9290144afe90b1bb254f3b36abc4f026
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-13 09:47:35 +00:00
Henning Gruendl
95475156e3 QmlDesigner: Add import/export of workspaces
* Add import/export functionality to the workspace manager
* Remove checkFormat functionality
* Add utility functions for workspace and file name conversion
* Use workspace file name extension from DockManager
* Fix a few DockManager comments

Task-number: QDS-1553
Change-Id: I1fa99d3ad85e282b3b11be2425faa4458d8a7778
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-13 09:39:27 +00:00
Christian Kandeler
6d36db78aa Core::OutputWindow: Pimpl remaining members
Apparently, these were forgotten when the d-pointer was added.

Change-Id: I508074361ee3fb1d07a49c883669e96649561a51
Reviewed-by: hjk <hjk@qt.io>
2020-05-13 09:13:58 +00:00
hjk
a6e1894274 Debugger: Report LLDB error if bridge could not attach to process
Change-Id: Id54c0e21d7d803505b45f92ecf0a208771d10b81
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-13 09:08:18 +00:00
hjk
6313489e2c Debugger: And possibility to modify debugger process environment
Might be useful to set ANDROID_SERIAL to get hold of the right device
when multiple are connected.

Change-Id: I8f1f02552a9f57ee8a9ed35ae696d137cc85fe52
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-13 09:07:58 +00:00
Ivan Komissarov
e41c440f64 qbs build: Add qmlpreviewplugin.qbs
The project file was missing from the build tree

Change-Id: I8f7d760700ec17ef9f46ef71b2378739e1f2ab18
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-13 08:49:19 +00:00
Leena Miettinen
bbddd60e03 Doc: Remove extra copies of images that were moved
They are now in doc/qtcreator/images. They seem to reappear
here during merges.

Change-Id: I7dc0b58997996601be7e54fb0a45898f0a5718a7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-05-13 08:06:15 +00:00
Nikolai Kosjar
7b1ea984a1 TextEditor: Remove wrong comment
Change-Id: I42883a4cdaa5c1fdd89f73ed73b8e25a550dbbec
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-13 04:26:05 +00:00
Alexis Murzeau
84b068d1b3 LSP: addDiagnosticsSelections should be static in Client.cpp
That function should really be static, it is not meant to be used
elsewhere.

Also, replace duplicate "uri.toFilePath()" with just set filePath
variable.

Change-Id: I11e6cd2133d8999b34ed24b774ab13036f2b9fc8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-12 22:28:44 +00:00
Robert Loehning
a90ec2809c Squish: Don't expect pastes to pastebin.com to appear in list
Change-Id: I02a73244e3aecad906f2c08b37d60ebe1880f534
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 20:29:02 +00:00
Henning Gruendl
d1728fbb6b QmlDesigner: Add transition item label
* Add label to transition item
* Change signature of drawArrow()

Task-number: QDS-2085
Change-Id: Ia719958ead404ea083a15fdee440a8e6a306ee62
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 18:10:41 +00:00
Leena Miettinen
b788c70b95 Doc: Update info about States view
Check terminology, restructure information, and update
screenshots.

Task-number: QDS-2056
Change-Id: Ieaa2d0856bf2d310f67d8c0d9f9376a48cf33534
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 15:06:15 +00:00
Leena Miettinen
b15e19ac12 Doc: Update screenshot of Properties view in Design mode
...and remove the numbers from the image and text, as one can
easily see the item type.

Task-number: QDS-2056
Change-Id: I821db7a0f3a4ff1999c58701f379ae3667821a0a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 15:04:43 +00:00
Leena Miettinen
795fb5f59d Doc: Update info about QML types supported by Qt Quick Designer
Update screenshots.

Change-Id: If079a93940dc103b4afa283f01c94825d895bfa3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 15:04:22 +00:00
Christian Kandeler
fcd8b1a8f0 ClangClParser: Adapt autotest to changes in master
The \r\n sequences are cleaned up centrally now.

Change-Id: I55ed60757433e9b800fe7a30a5fa77f9a0f382c0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 13:46:08 +00:00
Christian Kandeler
eb96f9900a Fix clang 10 warnings about unnecessary copies in range loops
Change-Id: I3b57869b5a04528518bc432b76768b01e3f53e81
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 13:45:43 +00:00
Andre Hartmann
9c1e8a99d8 VcsBaseEditor: Make link colors theme-aware
Change-Id: I5323e0cd236276a5a74e7c55f81d9d9c9795d295
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-12 13:36:42 +00:00
Marco Bubke
a4b00a7742 Sqlite: Add update hook and use it to get the last changed id
Sqlite has a function to get the last inserted rowid but very often you
want to get the updated rowid too.

Change-Id: Ie276a5039682813ad16597433996a2959f54d9ba
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-12 13:05:57 +00:00
Marco Bubke
fded815021 Utils: Use always std::strlen
std::strlen is computed at compile time if possible by the compiler. So
we don't need this optimization.

Change-Id: I31112219df9a3b42fe9d57cdd981f869e6f02dae
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-12 11:01:41 +00:00
Christian Kandeler
56a4865b2f QbsProjectManager: Fix potential null pointer access
We retrieved the watcher result from the wrong pointer.

Fixes: QTCREATORBUG-23924
Change-Id: I876d8adc0aef011deb3f5827f3e50c43a8d92dfc
Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 10:52:31 +00:00
Ivan Komissarov
f480cf2c44 qbs build: Add studiowelcome.qbs
The project file was missing from the build tree

Change-Id: If4d97774e63b0368a5b7bfbedd7425d4e871eef5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-12 10:29:31 +00:00
hjk
3d04efa0c8 Android: Determine debugger type from Kit settings
Change-Id: I7e83fa1df923fd2449eecfac9c9d82bae249e6c1
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-12 09:42:17 +00:00