Commit Graph

67787 Commits

Author SHA1 Message Date
David Schulz
8bde432dfe CodeAssist: Fix leaking asynchronous processors
Currently the ownership of the processor is unknown to the codeassist
when running an async operation. Move the ownership of the processor to
the assist and delete the processor after the proposal was completed.

Change-Id: I6a2e023c47cbc876669dba866bee12b481447cb7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 08:24:41 +00:00
Tim Jenssen
03a1282bdd Merge remote-tracking branch 'origin/qds-1.50' into qds-1.59
Change-Id: Ic0edcce1268b9cc47c91364eeb84e3b3f7dfe134
2020-05-12 10:04:10 +02:00
Tim Jenssen
c9b5671754 Merge remote-tracking branch 'origin/4.12' into qds-1.50
Change-Id: Iee9542b518367018b6e672ff920bfdb411639f8b
qds/v1.5.0-rc1
2020-05-12 09:59:55 +02:00
Christian Kandeler
8e1169f4bf qbs build: Take differences between clang and "apple clang" into account
In particular, clang with version number 10 is not really clang 10 on
macOS.

Change-Id: I8be489fa9cffd63c1ea8f13d181686ab1a575ec6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 07:31:39 +00:00
Marco Bubke
0e7a1e6650 QmlDesigner: Preview size is now changeable
You can now change the preview size with
rootModelNode.setAuxiliaryData("previewSize@Internal", size);
If size is null it will use the bounding box size.

Change-Id: Icbe747ccc5a2e26e79783825d2ed94ecc640012b
Reviewed-by: Michael Winkelmann <michael.winkelmann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 07:11:15 +00:00
Leena Miettinen
99b66f6238 Doc: Update info about managing item hierarchy in Design mode
Task-number: QDS-2056
Change-Id: I0786d01dcde48e056450ea70b498abcdd204e381
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-12 07:08:47 +00:00
Christian Stenger
da3b14faee ProjectExplorer: Fix release build
And compile on macOS. Amends c15e09e0fe.

Change-Id: I39395f341e8590104dd96348aa8fc12d437dbd28
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-05-12 06:47:15 +00:00
Christian Stenger
55f4c5ba8c AutoTest: Display benchmark results
When running benchmarks display them on the visual results
pane as well.
So far, they had been ignored and where visible only in
the text output.
Omitting some additional information present inside the xml
output to be closer on the default text display.

Change-Id: I9dbcad917ab522c12aaaa81704add59efedf7905
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-12 06:39:31 +00:00
hjk
ca862e3fff Debugger: Fix LLDB listing registers when no frame is selected
Change-Id: I6c3d193a2622ed07c34e68bf8b5780d55520e4f2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 05:52:08 +00:00
David Schulz
3559af69db TextEditor: move rename symbol action to text editor
Task-number: QTCREATORBUG-21578
Change-Id: I9a873dcd38bacb2287c45973b6be0091c3eb9480
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-12 04:28:19 +00:00
Alexis Murzeau
a9aa561234 CMake: copy clang and resource files only if necessary
Uses a timestamp file in the build directory to detect when the input
changes using DEPENDS from add_custom_command.

Total copied files size sum up to more than 260 MB. This was copied at every
incremental build, even if nothing changed.

This leads to faster build, especially when the copied files are not
cached in RAM or when not using a SSD.

Change-Id: I3a0b691b961e1d8591068bacf40ae2467c8637cf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-11 22:36:30 +00:00
Alexis Murzeau
95d9eafc8a LSP: CompletionRequest: set triggerCharacter when possible
When the completion request is triggered by an activation character,
set the triggerCharacter accordingly.
This can help the language server to propose more sensible items.

Detected while trying cmake language server. It was throwing an error
when triggerKind is TriggerCharacter and triggerCharacter is not present.

Change-Id: Ifde578e39f2eebfc5c6551f08985f4408f6c7933
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 22:34:40 +00:00
Alexis Murzeau
3268e5f0bc LSP: Add setting to provide initializationOptions to the language server
When the language server is initialized, the Initialize request can contain
user provided data in initializationOptions field.

Allow the user to set data inside. This can be required to let the
language server have some context.

Change-Id: Ib057fdb940c21b3fd032853fb84253d42ad1e321
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 22:33:45 +00:00
Alexis Murzeau
5868e15c30 LSP: Always override the assist providers if the server supports them
When the default assist provider is not DocumentContentCompletionProvider
because of some plugin that also provide an assist provider, this would
fail.

If the user has configured a language server, assume is prefer that and
always propose the server's assist providers when available.

This the case for CMake files but probably C/C++ files too if the CppEditor
plugin is configured to handle them.

Change-Id: I641d73466c8b520beb494dae8e6b274debd2881f
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 22:32:09 +00:00
Alexis Murzeau
2d5a981b9c LSP: allow non versioned text document in SemanticHighlightingParams
The proposal of SemanticHighlighting uses a versioned text document
identifier, but there is a suggestion to be more coherent with other
existing requests and use text document identifier instead (non versionned).
See here: https://github.com/microsoft/vscode-languageserver-node/pull/367/files#r225879268

The clangd language server implements the non versioned version.

Existing code was returning errors with clangd because
SemanticHighlightingParams::isValid would return false because of the
missing version field.

Change-Id: I1c36151342437adad2405118ca6b303db0936e41
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 22:30:49 +00:00
Christian Kandeler
c15e09e0fe ProjectExplorer: Generalize the concept of custom output parsers
They can now be created independently of any toolchains, and we expose
them in the build and run configurations, so that users can easily get
tasks for output that comes from custom tools or is otherwise specific
to the user's environment.

Fixes: QTCREATORBUG-23993
Change-Id: I405753b9b68508ffe5deb4fcac08d6b213c7554d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
2020-05-11 15:59:32 +00:00
Alessandro Portale
ed9918a41c McuSupport: Let user explicitly create or remove MCU target kits
So far, the user had to press "Apply" to generate a kit for the
currently selected target. The kit got silently added, there was no
immediate UI feedback that something happened.
Also, there was no possibility to remove a specific Qt for MCUs kit once
it was added, becoause it is under the "Auto-dected" kit category.

This change modifies the UI interaction so, that there is a specific
"Create Kit" button, and in case that the kit already exists, there is a
"Remove Kit" button.

Task-number: QTCREATORBUG-23929
Change-Id: I334ed75f86905ac762e0293bd3aa70b3433acf28
Reviewed-by: hjk <hjk@qt.io>
2020-05-11 14:45:47 +00:00
Leena Miettinen
d88d27e7cc Doc: Make Git ignore Qt Design Studio generated docs folder
The docs are still generated under doc/qtdesignstudio/doc/html.

Change-Id: I9916ccf8cdfa2541b632a680fb6b4f7103f6a1a5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-11 12:14:58 +00:00
Ivan Komissarov
c7973c7d35 qbs: update to the master branch and fix .pro files accordingly
Change-Id: I22a28c9d359340ba1fada04ec4eee525df8ecfca
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-11 11:20:26 +00:00
hjk
65935ce03c Debugger: Fix startup when Python's json module is missing
Task-number: QTCREATORBUG-24004
Change-Id: I1c0563868374263f13cec3a8f40138bce71338d6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 10:35:32 +00:00
Eike Ziller
20ef5c6de3 Merge remote-tracking branch 'origin/4.12'
Change-Id: Ibbf9f16677a58bdcdd3ce63701ffa34db6f44916
2020-05-11 11:36:22 +02:00
Christian Kandeler
050dec20dd qbs build: Fix excessive clang 10 warnings for qbs submodule
Change-Id: Ie1bb9833e00412d753b32c8267a9e9413aa66a7d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-11 09:33:01 +00:00
Leena Miettinen
c370d345f1 Doc: Remove obsolete \contentspage command
This prints a QDoc warning when building with QDoc 5.15.

Change-Id: Id6f4646738f3e09956a243dc0da639f5567470f3
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2020-05-11 08:43:31 +00:00
Christian Kandeler
b9e79f7852 Linux: Force release of unused memory
Apparently, glibc uses an overly aggressive caching strategy, causing
Creator to accumulate an unreasonable amount of resident memory over
time.
We deal with this by manually forcing glibc to free unused memory once a
minute, provided the application is actually in use.

Fixes: QTCREATORBUG-22832
Change-Id: I300eafd8714eb7e49774129758998db32ca1a1de
Reviewed-by: hjk <hjk@qt.io>
2020-05-11 08:33:14 +00:00
Andre Hartmann
6683dc1063 TextFileFormat: Fix typo in comment
Change-Id: Ifdf99136d5a31dc3fe55633ec1a5d1be69f0b2af
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-11 06:41:52 +00:00
Leena Miettinen
d86c2a1ba9 Doc: Remove obsolete info about selecting items with content
The button has been removed.

Task-number: QDS-2056
Change-Id: I7495107e68920f02effef0618461f5ed6c88bfa8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-11 06:36:24 +00:00
Leena Miettinen
c1781320f3 Doc: Describe using Alt and Shift modifiers in Form Editor
...when resizing items

Fixes: QDS-2034
Change-Id: I4b4589a19c3c0ca96d6f8a80c7e4a3cc03731690
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-11 06:35:59 +00:00
Leena Miettinen
993a628859 Doc: Describe setting initial root item size in Qt Quick Designer options
Task-number: QDS-2056
Change-Id: I82fc86b748d72b180e2e503a7d80754d61682abd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-11 06:35:01 +00:00
Andre Hartmann
d5cbdde11f Git: No else after return
Change-Id: I1c054bbb3b7a7060775e8015a74ee396cf84cca1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-09 18:09:13 +00:00
Andre Hartmann
c217b2c94a Git: Use multi-arg as recommended by clazy
Change-Id: I4be0341407a318bdd797744add4c6c94d5a4e01b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-09 18:08:44 +00:00
Thomas Hartmann
6ab2f93f18 QmlDesigner: Adjust list of effects
Change-Id: I7d69ce83e86cf39b58601487f5d634b9aece211d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 19:13:33 +00:00
Thomas Hartmann
a41bb573e8 QmlDesigner: Add action for selecting effect
Change-Id: I7b89eb688fb7b9a9cd1ad21afcdf67c1662fd110
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 19:13:14 +00:00
Sergey Belyashov
361ddf6ad5 Update Russian translation
Change-Id: I2753eb8bcbd25f6388088bdeabca1553f6e24410
Reviewed-by: Viacheslav Tertychnyi <tvk537@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
2020-05-07 17:04:55 +00:00
Cristian Adam
646d26b9cb CMake Build: Set BUID_WITH_PCH to OFF if CMake version less 3.16
Change-Id: I11a58cf2e67272b9d45a877dfa20c089706cfc2a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-05-07 16:29:13 +00:00
Christian Kandeler
27ea67728f qbs build: Suppress more warnings
Amends d08e5c33ff.

Change-Id: Ic842dda51b21427e1989190b44508d54aa1e7120
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 15:25:31 +00:00
hjk
9403c7c916 Debugger: Consolidate LLDB startup code a bit
Change-Id: I0c19a76ad6f1e7b4602b9bd2157cc6855e049402
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 15:12:33 +00:00
Marco Bubke
2e409f792c Sqlite: Remove unneeded file
FTS5 is proving it. So for full text search we should use FTS5.

Change-Id: Iac5abdfa9bc6fd9f9c2515c1f15ef04cf445baf4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-07 12:15:14 +00:00
Marco Bubke
f02934458e Sqlite: Add foreign key support
It is still only support references in columns but so far it is enough.

Change-Id: Iebb4866cf738d651270e54357b5e4a2837f05417
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-07 12:14:58 +00:00
Thomas Hartmann
149453941a QmlDesigner: Fix bounding rectangle in FlowEditor
Change-Id: I30c3a5d88bbbe2fce968a23c9f9acb17771366a9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 10:26:01 +00:00
Alessandro Portale
5c71772fd0 Themes: Undo theme duplication. Just change the ThemeName
Until, we have a mechanism to define a default/fallback in a read-
only setting, it is better to stick to old file names rather than to
create redundant entries.

Change-Id: Ifbc78160e9c57025c66a266efab2b43646ee477a
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 09:36:57 +00:00
Sebastian Verling
38e13e4216 add lower case a-f as address match
As the addresses were only matched against upper case letters
all registers with lower case characters were not correctly parsed
and had zero values

Change-Id: Idc3da0a33b9f075d7a209cad74768e81cced2d67
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
2020-05-07 09:34:48 +00:00
hjk
310c954779 Debugger: Make sure to not select frame -1 with LLDB
This can appear as (non-existing) preferred frame index in backtraces
consisting only of frames without debug info. Fall back to top most
frame in that case.

Change-Id: Id7bb941d5fc3080aff3853cebb7b92afdd0ba4ea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 09:04:28 +00:00
Eike Ziller
99c4e7c94f Add first changes file for 4.12.1
Change-Id: Ibd3ca94c588fd322d59dcf3d9ac13bbdb9ffc34c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-05-07 08:02:44 +00:00
hjk
54dd137902 Debugger: Make LLDB attach to local process work (again?)
Change-Id: I48ec7b5251db490d1c8e17affb3c1dc1ce22bece
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 08:02:44 +00:00
Christian Kandeler
83f213bb6a ClangClParser: Do not require two spaces before "error:" string
Presumably, this has changed in newer llvm.

Fixes: QTCREATORBUG-23992
Change-Id: I82aaae893e3cf159be7c43fb4d7762875d2be8a8
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-05-07 07:50:36 +00:00
Unseon Ryu
a2cedf76f2 fix scroll height of property editor
Fixes: QDS-2013
Change-Id: I43c3e6507f7f2052a86b0ccc485bd520c4dbabac
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-05-07 07:48:18 +00:00
hjk
e73f05253e Debugger: Simplify LLDB bridge startup
No need to start the debugger event loop if the engine setup fails

Change-Id: I6bdeda0d2609c79aa5fafff7bc4b373a0bf14fbd
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 07:39:29 +00:00
hjk
4744473555 Debugger: Start breakpoint manipulation syncronously
The original reason for this was gdb's inability to set certain
break point properties in one go (commands and  so parts of the setup are async
anyway, and using only async paths made the overall setup simpler.
The need to tweak some properties asyncronously still remains, but
for the caller side it's better when at least the initial round is
synchronous.

Change-Id: Ibe542533a6026c7f0f4e49f4244b7e9d2aea7062
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-07 07:12:57 +00:00
hjk
2dfa539b96 Debugger: Avoid race condition on setting initial LLDB breakpoints
Breakpoints inserting is async, so they did end up when the process
was running already.

This adds an extra roundtrip. Better, but more intrusive solution
might be to set the initial breakpoints synchronously, but that
would touch all engines.

Change-Id: Ia728a9c5ae8f1d6d29d3cc02b9e2d04952091fe9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-07 07:12:46 +00:00
Christian Stenger
a35b0858fb Marketplace: Hide progress indicator on error
This avoids appearing as there is still something happening.

Change-Id: I34c34e054a5454d1030234f482630e3d3fdd5a72
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-07 05:04:58 +00:00