Commit Graph

67787 Commits

Author SHA1 Message Date
hjk
4ba131bdd6 Debugger: Handle failed breakpoints as unclaimed
Change-Id: I02a44db5391b174e75fc326ce217b271ee73c464
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-24 06:12:35 +00:00
Christian Stenger
d02f5664e5 ClangTools: Avoid accessing deleted run worker
Change-Id: I74b977ede0d153ae4f8d85e03090dfc21facd04b
Reviewed-by: hjk <hjk@qt.io>
2020-04-24 04:33:23 +00:00
Denis Shienkov
91536ae781 BareMetal: Don't handle an empty SVD file selection in UVSC provider
Change-Id: Ic7fbf2c403f85d7d79f194a12f67e852ff0bdd80
Reviewed-by: hjk <hjk@qt.io>
2020-04-23 18:03:46 +00:00
Thomas Hartmann
bbed542ec3 QmlDesigner: Expose typeFilter property
Change-Id: Iaf0c6db67eb25b730bc31f87b52b0ec93ab15266
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 17:22:00 +00:00
Thomas Hartmann
ff211e57f4 QmlDesigner: Adjust icon size
The icons were scaled down and became really muddy on low dpi screens.
With Hennings additions we create high dpi versions behind the scene
in any case.

Change-Id: Iab94989b6cfae7b5cefcd7bcded4efa3a1d35a6f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 15:50:19 +00:00
Christian Kandeler
4c064c5f9b QmlDesigner: Fix warnings about unused lambda cpatures
Change-Id: I73e7aeed02527efd657df44232c13bb2e136f5ee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 15:33:18 +00:00
Christian Kandeler
69f7865c72 qml2puppet: Enhance qbs build
Add the optional QtQuick3D dependency that was so far only in the qmake
project file. Also fix annoying moc warnings for builds without
QtQuick3D.

Change-Id: Ic0f4f3de5b4a5d715332166d7390ad027dd377ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 14:40:02 +00:00
Christian Kandeler
e915cde44b QmlProfiler: Fix warning about unused lambda capture
Change-Id: I029497edaac5695d47a8930a304713fba48ded15
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 14:37:19 +00:00
Christian Kandeler
5ea2557125 Fix warnings about unused members in some clang-related classes
Change-Id: I564ac810ed8ae950e9ced54358929358379bfffb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 14:20:27 +00:00
Christian Kandeler
3f9e517754 DiffEditor: Fix clang warning about hidden overloads
Change-Id: Iad4cbe1f2e97b862626deeecbcec496fe3457370
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-04-23 13:49:37 +00:00
Christian Kandeler
785b184fb6 QmlDesigner: Fix warnings about unused variables and functions
Change-Id: Ib907db11dcdcef9cbbb91c8fd7af22ae420796b1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 13:49:04 +00:00
David Schulz
dee0997d38 QmlJSEditor: jump to file under cursor if it exists
Don't limit this functionality to files that are part of the snapshot,
but try to open all files. This will allow opening c++ files defined in
a qbs project file.

Fixes: QTCREATORBUG-22685
Change-Id: If2a2a2075e5d7113a7bb44625c0f29ef66138d3c
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-04-23 13:00:07 +00:00
David Schulz
e3a0fe71e4 CMake: fixup env if jom is missing
Add the applitcation dir path to the path environment variable
if jom cannot be found there. This should fix the cannot find
jom error for binary releases since we ship jom with qc.

Fixes: QTCREATORBUG-22645
Change-Id: Ia3b55f794d3ac4b5fd6d2e85cf19f00bd8cddd2c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-04-23 12:59:51 +00:00
David Schulz
2aac4cc07f CMake: honor use jom instead of nmake setting
Only search for the jom cmake generator if this setting is
enabled.

Change-Id: Id8eed91d47f1f6ca2375fe0d169b21168c5ca4ff
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-04-23 12:59:43 +00:00
Leena Miettinen
169c3bb30c Doc: Fix path to image files
Change-Id: I8f9395bd5d8c5ae02e1bb994577b02c80c4c2564
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-04-23 12:42:47 +00:00
Christian Kandeler
486a86558f Utils::ListView: Silence clang warning about hidden overload
Change-Id: I8702353b65355f9ab97c10001045250586b3f858
Reviewed-by: hjk <hjk@qt.io>
2020-04-23 12:10:58 +00:00
Tim Jenssen
a37b6ae5fc QmlDesigner: crash workaround
Disable the timer to be safe. The issue is bothering us for a
very long time and we were not able to find the real
cause.

Task-number: QDS-343
Task-number: QDS-1984
Task-number: QTCREATORBUG-20364
Change-Id: I5023f27be25ba7971db80990eeb9562fd63dc15d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 11:52:10 +00:00
Tim Jenssen
1f8fccea5c qmldesigner: no need to use QString
Change-Id: Ia60a0ef4d802a87cb8b7743b678d224c83ba2234
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 11:51:54 +00:00
Tim Jenssen
77c3e7d2d4 languageutils: improve ComponentVersion::toString
After benchmarking it on a i7 it was 20% faster in release.
(in debug even more)

Change-Id: Ibf4599813c2e3bc206ea77dea7fc972018554b09
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 11:51:44 +00:00
Tim Jenssen
23ce744407 QmlDesigner: cleanup ItemLibrary a bit
Change-Id: Ib3b35e68434e94a8dde10653881fc765e449beb1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-04-23 11:51:33 +00:00
Tim Jenssen
8d868d8bbb QmlDesigner: use setContextProperties
should be faster

Change-Id: I3f491237746856c00f13947dfa9e8464a2bd5c25
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 11:51:04 +00:00
Christian Stenger
3eb4a69b6f AutoTest: Remove some unused member
Change-Id: Iea332afc23c58aa0a3de1f3364eea519a422d524
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-04-23 11:09:21 +00:00
Christian Kandeler
925e6cb18e Remove unused members from some classes
Change-Id: I9b63bf32feaef36decc91d073eb82b2abfd2eabb
Reviewed-by: hjk <hjk@qt.io>
2020-04-23 10:41:48 +00:00
Christian Kandeler
6ad4cf4695 Debugger: Remove unused variable
Change-Id: Ib6e2c2078ff655ca2ca7c841e5f6415f0d63ef6c
Reviewed-by: hjk <hjk@qt.io>
2020-04-23 10:41:28 +00:00
Eike Ziller
49626f7ea9 CMake build: Fix devel package issues
Include paths and headers were missing for building a separator
Qt Quick Designer plugin.

Task-number: QTCREATORBUG-23778
Change-Id: Ib6ba96ad42a8b2b36e0ee2f0e3c51c27f3365d37
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-04-23 10:03:37 +00:00
Miikka Heikkinen
031d12cc5a QmlDesigner: Fix importing asset when open doc is in project subfolder
Change-Id: I9853dd9c6b919d2061e77bee12bfc6345848c846
Fixes: QDS-1823
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 09:54:33 +00:00
Miikka Heikkinen
d39f89d13b QmlDesigner: Reset quick3D importer between each file
Quick3D importer caches various things when it does the import, making
reusing the instance for multiple imports error prone.

Change-Id: I6e8e3dedf579683cdda58624172395a392f4e567
Fixes: QDS-1960
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 09:54:15 +00:00
Miikka Heikkinen
0cac09e757 QmlDesigner: Fix importing existing asset with different capitalization
In case sensitive file systems, revert to old capitalization
after reimporting existing asset with different capitalization.

Change-Id: If26443b34e408c84aeb12940262c8b9f696f0bbf
Fixes: QDS-1958
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 09:51:43 +00:00
Miikka Heikkinen
652596dc16 QmlDesigner: Update UI when an asset is reimported
Item library thumbnail and navigator icon are refreshed if asset is
reimported, and the puppet is restarted in case the asset is in use.

Change-Id: Ic5577eff3a24bcce87b504e9c059c29f6cb887a5
Fixes: QDS-1957
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 09:51:30 +00:00
hjk
2e8e30a7fa ProjectExplorer: Move build step name mapping to BuildManager
... and add some translation hints. Looks like a more natural
place to live in.

Change-Id: I3e8917d826baaa7277dde744f3843d5ab7fe0afd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-04-23 09:26:54 +00:00
Christian Kandeler
f4f9d9cdbb Android: Remove some unused variables
Change-Id: Id6d8f0735c410a331c406a3f3a094aac5f03f5a9
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-04-23 09:20:17 +00:00
Christian Kandeler
03fab2cdc0 Git: Fix clang warning
src/plugins/git/changeselectiondialog.h:72: warning:
'Git::Internal::ChangeSelectionDialog::accept' hides overloaded virtual
function [-Woverloaded-virtual]
    void accept(ChangeCommand command);
         ^

Change-Id: Ia0685c2347e943687e2c0ad34b4d456a30912d0a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-04-23 09:19:59 +00:00
Christian Kandeler
548223762d Autotest: Remove "#pragma once" from cpp file
Change-Id: I686701f3a0c3d391aa50d65f88e41241111cc3cb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 09:19:42 +00:00
Robert Loehning
43454c3fcd Squish: Update expected tree for qbs
Change-Id: I3ba303f0206db193d3e00ce52ac20f516823881c
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 09:14:08 +00:00
Eike Ziller
8984272769 Merge remote-tracking branch 'origin/4.12'
Change-Id: I296a61fe43aea134de9e7a6ee8042af3f45f5e99
2020-04-23 11:09:15 +02:00
Christian Kandeler
1c6e4fbd32 Merge output formatters and output parsers
Now only one piece of code needs to be written to both linkify output in
an output pane and create tasks for it in the issues pane.
The calling sites are also simplified. For instance, until now, build
steps had to feed their output parsers manually and then push the
created tasks up the signal stack in parallel with the actual output,
which the build manager relied upon for cross-linking the output pane
content. Afterwards, the output would get forwarded to the formatter
(and parsed for ANSI escape codes a second time). In contrast, a build
step now just forwards the process output, and task parsing as well as
output formatting is done centrally further up the stack.
Concrete user-visible improvements so far:
    - File paths in compiler/linker messages are clickable links now.
    - QtTest applications now create clickable links also when run
      as part of a build step, not just in the app output pane.

Task-number: QTCREATORBUG-22665
Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 08:47:08 +00:00
Christian Kandeler
2e4ed0696b CompilationDbProjectManager: Do not canonicalize file paths
In particular, we do not want to follow symbolic links, but see the file
names as they appear in the project file.

Fixes: QTCREATORBUG-23511
Change-Id: Ibf83ac143933fa0c9568dd4e3c0be825d8ba8f0b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-04-23 08:45:59 +00:00
Denis Shienkov
b7851eeb55 Debugger: Fix breakpoint insertion stalling for UVSC engine
The UVSC support the debugger commands execution feature
using the UVSC_DBG_EXEC_CMD function. This function non-blocks
if an command execution fails. So we can use this function to
execute a breakpoint insertion command:

* http://www.keil.com/support/man/docs/uv4/uv4_cm_breakset.htm

But, to get the properties of the inserted breakpoint we need to
enumerate all available breakpoints and to find the desired
breakpoint by its expression.

Besides, we need to fix and the 'expressionBuffer' field of the
BKRSP structure according to the original UVSC API.

Change-Id: I3c52e8955de28180aaafa1af9f6001ff6ee3b7fb
Reviewed-by: hjk <hjk@qt.io>
2020-04-23 06:57:36 +00:00
Leena Miettinen
7bf3024a56 Doc: Update info about the Timeline view and curve editors
- Remove information about enabling the Timeline view, because it
  is now enabled by default
- Update the screenshot to show the animation curve editor icon
- Show information about previewing, which is now enabled
- Fix UI text for the animation curve editor

Change-Id: I288b45f521945aadf76475871f422ccb41cd1ac1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-23 06:10:11 +00:00
hjk
252a0431d1 Debugger: Fix dumper for std::unique_ptr with custom deleter
Task-number: QTCREATORBUG-23885
Change-Id: Ifba6ef7233886d1c9341e7912d6924cd9afbc4eb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-23 06:08:12 +00:00
hjk
f781a72825 QmakeProjectManager: Add more detail do trace message
Change-Id: Ide8917d826baaa7277dde744f3843d5ab7fe0afd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-04-23 05:01:02 +00:00
Thiago Macieira
162ea716e6 Match use of int in operator>>
Change-Id: I9709abb1c3734e10a7defffd1607e743f6d662e2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-22 21:21:06 +00:00
Denis Shienkov
4c3bdd1f67 Debugger: Minimize stalling at break-points insertion in UVSC engine
Sometime the UVSC_DBG_CREATE_BP function stalls within 10 seconds
and then returns with the timeout error.

But this problem can be avoided by creating and then removing the
fake breakpoint before creating the original breakpoint. In this case,
we need to remove the line number from the expression of this fake
breakpoint.

Of course, it does not help when the breakpoint cannot be created
with the specified expression. In this case the UVSC_DBG_CREATE_BP
function will stall anyway within 10 seconds.

Change-Id: Ie8d39c545683d6bb3e29e5bb7c4ac0fd1e34222a
Reviewed-by: hjk <hjk@qt.io>
2020-04-22 19:35:37 +00:00
Leena Miettinen
4df0e1f4af Doc: Add missing dot
Change-Id: I20c6f4709eea0e9e7cbf04401b4499d403deaedb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-04-22 14:05:32 +00:00
Christian Kandeler
b7de4eb263 OutputFormatter factories: Handle the "no target" case
Amends d42920d372.

Change-Id: I302c4e54cbe2dcc2340deffa99237e909418939d
Reviewed-by: hjk <hjk@qt.io>
2020-04-22 13:25:34 +00:00
Tobias Hunger
bf1bbbac05 CMake: Remove some unnecessary code
The build directory going to get set up either in
doInitialize or in fromMap, both using magic hidden in
BuildConfiguration itself.

Change-Id: I1aeb59f56d63f0affd50b45cc937e606af6da7b4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-04-22 12:12:37 +00:00
Tobias Hunger
5bb5c7b904 CMake: Make sure a CMakeBuildConfiguration always has a CMakeBuildSystem
For this to work, we need to make sure no parsing is triggered before
the project is fully set up. Otherwise it would be QTCREATORBUG-23816
again...

Change-Id: If81f4c6b9c82283abdaa8a635f93ebe0bcaf8159
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-04-22 12:09:14 +00:00
Tobias Hunger
283763a3e2 CMake: Update documentation to require CMake 3.7 or later
Tealeaf mode has been removed, so update the documentation accordingly.

Change-Id: Ibecc2f127f3acb5d6813e4f670c3424db633cacb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-04-22 11:59:30 +00:00
Tobias Hunger
ca4c578532 CMake: Update minimum CMake version to 3.7
Tealeaf reader mode has been removed, so require at least
CMake version 3.7 (which comes with server-mode).

Change-Id: I1ce8cdd08f226446ccca5882d1cb2171019b3409
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-04-22 11:59:21 +00:00
Aleksei German
00f4145de8 QmlDesigner: Global Annotations Editor
Task: QDS-1904
Change-Id: I92682b235f9c69dd7069172807954f0a99a946b0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-04-22 11:28:35 +00:00