Commit Graph

76686 Commits

Author SHA1 Message Date
Marcus Tillmanns
b7ac02ab90 QtVersion: Optimize qtCorePaths() method for speed
This fix reduces the amount of paths returned from the dirEntries
calls.

Additionally it reduces the amount of calls to FilePath::isReadableFile
which for files in e.g. a docker container is quite expensive.

Change-Id: Ie1314e7257ea870de7823a019d9561f0873e0afd
Reviewed-by: hjk <hjk@qt.io>
2022-09-27 08:44:10 +00:00
Marcus Tillmanns
e9045c4962 Debugger: Delay restoration until Devices are restored
Change-Id: Ib3f63e84959518cd629cb98e3e348aea50979927
Reviewed-by: hjk <hjk@qt.io>
2022-09-27 08:35:58 +00:00
Marcus Tillmanns
0f4ba36008 FSEngine: Speed optimization
Change-Id: I1fdb61042df47941921a8f278d0626b440084ec4
Reviewed-by: hjk <hjk@qt.io>
2022-09-27 08:35:36 +00:00
Marcus Tillmanns
5d4bbd38d4 MainWindow: Disable TrimTimer on non Linux Host
Timers showed up a lot during cpu profiling on macOS.
This is one of them. Since its only used on Linux,
this patch makes sure that its only started there as well.

Change-Id: I0da35473b622c92e39a7e45677441f1cd8aa3344
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-27 08:24:43 +00:00
hjk
6465415bf5 Autotest: Remove some unneeded #include
Change-Id: Ifa54416fc52a2a404f052d3000b9fff4ffd3f7f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-27 08:19:47 +00:00
Jarek Kobus
31339b2e0d Compile fix
Amends fbbf0d9149

Change-Id: I0eeb25095ec82c77d48b5105520cd93da43208b2
Reviewed-by: hjk <hjk@qt.io>
2022-09-27 08:19:38 +00:00
Eike Ziller
7eaa36e6e5 Merge remote-tracking branch 'origin/8.0' into 9.0
Conflicts:
	src/plugins/qmldesigner/components/materialbrowser/materialbrowserview.cpp
	src/plugins/qmldesigner/designercore/imagecache/meshimagecachecollector.cpp

Change-Id: I38f196e8f42cf11f7b613e7a723745600e35c5e9
2022-09-27 10:03:37 +02:00
Christian Kandeler
70c5a7b631 ClangTools: Fix cmake project file for test project
It still referenced a file that was removed in
8987996500.
Also remove unneeded CMAKE_INCLUDE_CURRENT_DIR.

Change-Id: Id7bd305849a81bd30eafbc80d27c1bc6bf848e07
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-27 07:57:05 +00:00
Christian Kandeler
c1e6307545 ClangCodeModel: Catch exceptions in semantic highlighter
I've repeatedly encountered std::bad_alloc recently, and would like to
get more info about where it is triggered. The crash comes from Qt,
apparently after the original thread has alresdy finished, so the
original location is not found in the stack trace.

Change-Id: I7bbdcce6534ea0c846a69af33ad8634c3415572d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-27 07:55:49 +00:00
Christian Kandeler
9db286b3d6 CppEditor: Add actions for following a symbol to its type
Change-Id: I0b3913993b09b006e2d0431a68e98e21e8865898
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-27 07:55:21 +00:00
David Schulz
fbbf0d9149 LanguageClient: show only one inspector widget at a time
Change-Id: I72630c85e9420ae873a57919e2d5434c83a5626c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-27 07:53:11 +00:00
Aleksei German
4da6686705 QmlDesigner: Add Connections Shortcuts
Task-number: QDS-7641
Change-Id: I1cb8f10cb675cee7dd48481cb31e4807fc592dc3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-09-27 07:02:16 +00:00
Alessandro Portale
bbd64a2c94 Improve scripts/scrubts.py
List the same duplicates that lrelease shows. But better: all
occurrences with full filename:linenumber.

Change-Id: If0cf38183dbdb4118f2152e1ae86ec92bf0ae1cc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-27 06:55:06 +00:00
hjk
cbd5e5efea QbsPM: FilePath-ify QbsProjectImporter
Change-Id: Ia043dbfa9db401b5afa17f435eeaf4f4347290c2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-27 06:22:23 +00:00
hjk
a098f43b6e Squish: Suppress warnings on unused parameters
Amends 8cfbaa1da9.

Change-Id: I38a7b980e177f2e97d89162480d3ddbd80c996b8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-27 06:04:44 +00:00
hjk
21c5d3499b CMakeProjectManager: Compile fix
Amends bcadea228.

Change-Id: I4f85780ffa6c7c79c70c096b457065f95e96355f
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 16:15:11 +00:00
hjk
985c8b1a43 ProjectManager: Return FilePaths from ProjectImporter::importCandidates
Proliferates FilePath use a bit further. Actual changes to the
individual importers are left for further patches.

Change-Id: Ie7c6b2e3f4ac7d0eca6d2f56d30fb23354bb404b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-09-26 16:02:55 +00:00
hjk
bcadea2285 CMake: FilePath-ify CMakeProjectImporter
Change-Id: Ifffd3328afae60a4015d88e36b3e60b4ee492c3b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-09-26 15:16:36 +00:00
Christian Kandeler
7b9fec2aa8 Debugger: Remove CMAKE_INCLUDE_CURRENT_DIR from autotest project file
Not needed.

Change-Id: Ia75cd0b70f2976a03948e7d8569027f6c0242344
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 15:03:44 +00:00
Christian Kandeler
787de7eede Documentation: Remove CMAKE_INCLUDE_CURRENT_DIR from example
It's not needed.

Change-Id: If831963bc1b38545134254aba1b814f1d332fcdb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 14:55:13 +00:00
hjk
f05a97fce5 Translations: Remove duplicates for "No changes to apply"
Amends 2d203763e8.

Change-Id: Ifb4e18c2f8c63b264a16aa59aa588e44972b2c19
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 14:38:58 +00:00
hjk
f48a6bb826 Core: Inline finddialog.ui
Translations are left alone for now.

Change-Id: I8e88c33abcd8c79f158d8bdac030c68df16d462b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-26 14:28:11 +00:00
hjk
2d203763e8 Core: Inline externaltoolconfig.ui
Also collapse Core::ExternalToolConfig and Core::Internal::ExternalToolConfig
translation contexts.

Change-Id: I5764a85d8cdb33158a8ff770d5a769a752a051af
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-26 14:10:38 +00:00
Christian Kandeler
aed001650a Project wizards: Do not use CMAKE_INCLUDE_CURRENT_DIR
This is an anti-pattern that lets uneducated and/or careless developers
get away with using the wrong type of include, so we should not
encourage its use.
It's also not needed by the wizard-generated code.

Change-Id: Iae508025bcd6659ed5aeb546a3da5f8f72e75059
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 13:55:16 +00:00
hjk
eb1ad960a7 Core: Inline directoryfilter.ui
Change-Id: I4b9de0fb9943c4d05ffff0585d1452e472b1e0f8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 13:42:06 +00:00
Mahmoud Badri
d47e9772e0 QmlDesigner: Correct a method's camelCase naming
Change-Id: If9d4b750a09873fc0de8f85edcb41d220cbe5a41
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-09-26 13:32:25 +00:00
Cristian Adam
5bcb2e4c58 scripts: Remove clangbackend from deployqtHelper_mac.sh
Since we moved to clangd the file doesn't exist anymore.

When creating the dmg packaging the process would print
multiple errors pointing to the fact that the clangbackend
file doesn't exist.

Change-Id: I172cfa43e67ec4aa9e5e2f8b703e024b803c78a1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 13:25:50 +00:00
Mahmoud Badri
e31debc0e7 QmlDesigner: Move SearchBox to StudioControls
Fixes: QDS-7759
Change-Id: Idf33aa47f5e793c4053f825ae8a203b97c078bf1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-09-26 13:25:32 +00:00
Mahmoud Badri
57dc7f8468 QmlDesigner: Remove an external dependency from the SearchBox
Task-number: QDS-7784
Change-Id: Ibd1390398d9984c618da4052560706ac58fb5234
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-09-26 12:58:38 +00:00
Miikka Heikkinen
945e6fce31 QmlDesigner: Fix copying material property default values
When copying specific set of properties, old values need to be cleared
just like in case of copying all properties to ensure also default
values get copied.

Fixes: QDS-7522
Change-Id: I314ff70b6e611bec3f662b86f964d789618c1df7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-09-26 12:13:23 +00:00
Cristian Adam
5a156395c4 CMakePM: configure presets review fixes
Amends 2ab1e76ca9

Change-Id: Id10f0d4da6a60223d68af3cea6c5263f7c8c62f2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 12:04:37 +00:00
hjk
42f8e42927 Docker: Remove unused #include
Change-Id: I3dda02b6669e0baf0a2018229c0bc83c8bbbd00f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-26 11:30:09 +00:00
Christian Kandeler
813c6fbd81 ClangCodeModel: Implement following a symbol to its type
Making use of LSP's "Go To Type Definition".
Just the backend for now, UI to follow.

Change-Id: Id73b2cf701eab03913477f6d4d3093e257e80dbd
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-26 11:24:20 +00:00
Alessandro Portale
e3b67799d4 QtSupport: Fix gathering of feature flags
Amends: a917770053

Change-Id: I92555961f89ef4f23ac0e783e988e4e8d29fad12
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-26 10:27:13 +00:00
Henning Gruendl
db46d8d76f QmlDesigner: Avoid drag and drop faulty state
Avoid the issue described in QTBUG-106943 by reducing the animation
duration.

Change-Id: Ide2004885d945680fa80cb8d0f10968ae33c8611
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2022-09-26 10:05:59 +00:00
Henning Gruendl
9bde8dc3e8 QmlDesigner: Fix dragging while scrolling
Task-number: QDS-7744
Change-Id: I99de01a09ef939e506c07d411c42bd2b28a53c31
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2022-09-26 10:05:49 +00:00
Marcus Tillmanns
e42021bb09 DockerDevice: Do not change the containers entrypoint
Some containers may use their entrypoint to setup their environment.
Simply overwriting it from our side would disable such setup and
make the containers useless.

Change-Id: I3385858c49aa8217c3191acdb85343ffd6163cf9
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 09:49:58 +00:00
Marcus Tillmanns
090dfb7ca5 DockerDevice: Fix debug-dumpers not found
Since the dumper path was changed after the first "startContainer"
call, subsequent startContainer calls would set the wrong source
directory.

Change-Id: I6e8304c080b4b55fc67eda0a9544a1b8f34ab7a1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-26 09:49:44 +00:00
Marcus Tillmanns
33abca1c0b DockerDevice: Implements ensureReachable
Change-Id: I2c479b1cf7a61021f27222e2e936903a9f39e1d8
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 09:49:29 +00:00
Eike Ziller
e3f375925d Prefer project's Qt version for context help
To avoid additional dependencies, let the QtSupport plugin register a
function for filtering help URLs, and add information about the
originating file path to the help items created by the context help
handlers. The filter hook then finds out the corresponding project,
active target, and corresponding Qt version, and filters the help URLs
accordingly.

With the default setting in "Kits > Qt Versions > Register
documentation", only the highest versioned documentation set within a
major Qt version is registered, so context help now shows the highest
versioned help from Qt 5 or Qt 6 depending on active target. If that is
changed to "All", context help now shows documentation from exactly the
version that is currently used by the project.

Fixes: QTCREATORBUG-10331
Change-Id: I7d87793737cc5ab7d228ee4bfe568d7e8343ee7d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-26 09:24:55 +00:00
Marcus Tillmanns
bf6914a704 Docker: Don't directly access Private data in DockerDevice
Consolidating private data access

Change-Id: I8c8353bdd62606c3b0286d2ffaf3b5e634943b59
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 09:17:00 +00:00
Alessandro Portale
76fc1bddfa McuSupport: Fix some warnings
Change-Id: I301e3194248423323f15f0e1404535f6eff692da
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-26 09:15:35 +00:00
Marco Bubke
8de67a6850 QmlDesigner: Use new validation approach in form editor
Many validation tests can now be skipped.

Task-number: QDS-7454
Change-Id: Ia7b126611d2c7c72ff3b1c77565acd5a160d0d06
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-09-26 08:51:18 +00:00
Marco Bubke
1d9c7e071e QmlDesigner: Use new validation approach in material browser
Many validation tests can now be skipped.

Task-number: QDS-7454
Change-Id: I01c37ff9747260940400043d2a0e39bb2700ee5b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-09-26 08:50:36 +00:00
Marco Bubke
6659024dd3 QmlDesigner: Add sourceContextAndSourceId to SourcePathCache
Change-Id: I4f5eb784e80d3afc10aa007f3be1604f6e18e312
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-26 08:49:54 +00:00
Marco Bubke
0b47270be2 QmlDesigner: Use new validation approach in component core
Many validation tests can now be skipped.

Task-number: QDS-7454
Change-Id: I677fd75ed03dca49353b2eba68d2e470509c28ae
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-09-26 08:49:40 +00:00
hjk
23f26a45f5 Core: Inline filesystemfilter.ui
Change-Id: I6d7fb337a1700c78becb182d30c5967906b6d432
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-26 08:37:18 +00:00
Henning Gruendl
e32f585fda QmlDesigner: Fix drop incorrect place
* Fix drop incorrect place
* Improve overall drag smoothness

Task-number: QDS-7733
Change-Id: I70e23df54c0e52b423c21b883924c5daee955d0a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-09-26 08:27:31 +00:00
Jarek Kobus
141fe19e59 TextDocument: Make m_document a child of TextDocument
This is needed when moving TextDocument object between threads,
otherwise all objects that are not children of the TextDocument
(in terms of Qt's object hierarchy) will stay in the old thread.

Change-Id: If5cc0151a5e4c1c7b69cf949bbb9cad317a44d17
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 08:24:14 +00:00
Eike Ziller
4c13b7ca65 Fix duplicate translations
Amends 6bc77c7c37

Change-Id: I2623bfa2ca2640cde4b95e5617e3d2a0991f6b96
Reviewed-by: hjk <hjk@qt.io>
2022-09-26 07:43:59 +00:00