We have to unlock the model to revert the model to
the last correct state.
The unlock method is not supposed to be used elsewhere
and hidden in a private header.
Fixing miss leading warning in destructor.
Change-Id: Ia14aab2a8ffdc1cb9fa9b2968cdef38bfc84e5d5
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We define the background color in use and should not rely on
the palette of the theme to have a text color that is readable
on the background. Avoids having unreadable text.
Change-Id: I9c032639dc142ea4a9b00f272d06a279678e8045
Reviewed-by: David Schulz <david.schulz@qt.io>
It has visible: false so it is not in use,
but it produced some warnings.
Change-Id: I2fc9c5d1c06b14d0e9104f9e1507baeabdc5f4bc
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Since we are being connected to the same done() signal twice,
the order of slot invocations started to play a role.
We were connecting done() signal to
VcsBaseEditorWidget::reportCommandFinished() first
and to VcsBaseEditorWidget::setPlainText() afterwards,
so they were executed exactly in this order. However, this
order isn't desired, as we need to set text first and
jump to line afterwards.
In order to fix it so that we don't rely on connection
order we handle setting the content and jumping into
the default line in one common handler.
Amends c767f193ce
Change-Id: Iea17476cc25b54759457710ecb6b6de2f0f5caf7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Get rid of ClearCaseResponse struct.
Replace foreach with range-based for loops.
Change-Id: Id78e2ca3598c16ad16ebaeddae73a140e3473936
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Breaking dependencies for the model.
Change-Id: I231435b5d79fe201c589e75b2835dccea7e87937
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The use of 'auto' here is the simplest way out and should not be
taked a precedence for other code.
Change-Id: I4435e7211139bccfca4b10ed2407ba39afe0b400
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the input directory in VcsManager::findVersionControlForDirectory is
just "/", that slash gets chopped off by absoluteWithNoTrailingSlash,
and the resulting string is empty. So we need to handle that case.
Change-Id: I7970043a16e587c803e94c16b71bea481ea21c09
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The function is only called in the formeditor. So moving it to the
formeditor removes the dependency to the mcu manager.
Change-Id: I1a1d6f65b97340206ea0d485b24046c3661daf92
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
This fixes an issue of the formeditor which did not update properly if
components contain items that have one of zvalue, opacity or visibility
attributes animated.
Change-Id: I1b20f09177878419b2b18aaf94c84b6ae437be7d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This is not required to leads to a quadratic slow-down if there
are many properties.
There is still a slight lag if there are more than 20 properties,
but QDS stays fully usable.
Change-Id: Ife14e97d127b16a1ae59e97a8fa642f5a2479e53
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
For some reason we get nullValue for the functions
of animations like 'update', 'start', 'restart', 'stop', 'pause'.
Change-Id: I2301083d6d61e2f8f59e5878023cac0fcf711e61
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
When trying to find out whether a symbol refers to a local variable, we
first look up its definition. Afterwards, we need to check whether that
definition is located in the same file. This was forgotten, which lead to
seemingly random weirdness when trying to rename non-local symbols.
Change-Id: I505675a784fc69dc4f01105033608116fc7720c2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
When trying to find out whether a symbol refers to a local variable, we
first look up its definition. Afterwards, we need to check whether that
definition is located in the same file. This was forgotten, which lead to
seemingly random weirdness when trying to rename non-local symbols.
Change-Id: Icdcfd5583bf33346d8f0e3caf2751fd16f7d9602
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
... for a rename request.
Instead, simply finish the search normally, leading to a "no matches
found" message rather than the misleading "search canceled".
But do cancel the search on an actual error.
Change-Id: I10401466bb4d81d53d26b8dc08bfed91db86cd5a
Reviewed-by: David Schulz <david.schulz@qt.io>
For example the yaml highlighting file declares text/yaml as the
supported mime type, but that is not the canonical name, which is
application/x-yaml.
Change-Id: If9e3f5e31bc5593a82cbbdac916ef41b0d23de7c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
