Commit Graph

76686 Commits

Author SHA1 Message Date
David Schulz
591fc12ffa Python: remove static cast of client interface in client constructor
Change-Id: I475a2b79438b8392085f1d9bf2cdb8b7369efa68
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 13:11:31 +00:00
David Schulz
e74999cced Python: check for pyside tools after installation
Change-Id: Icf9ae0ec08a78efc51216daa3304e76f8e812d5f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 13:11:07 +00:00
David Schulz
ca47064020 Python: Fix scripts path to global/venv pyside installations
... when checking for pyside tools.

Change-Id: I1aaac9dd9da76f08ada031cc88761dba36c4e3b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 13:10:56 +00:00
Jarek Kobus
3b0add4b16 DeviceShell: Merge done() and errorOccurred() signals into one
Don't connect to QtcProcess::errorOccurred() signal, as it's going
to be removed soon. Rely on done() signal instead.

Change-Id: I28260f8eb77911a23de80512881cf7220f1bc1fc
Reviewed-by: hjk <hjk@qt.io>
2022-06-20 13:07:32 +00:00
hjk
44bb330128 ProjectExplorer: Split RunWorker::appendMessage overloads
... into separate functions. Makes the use of the parameter clearer
and is easier to connect too.

Change-Id: I061b0b5c847ae1e695afc75332e634ddf2576d6c
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 12:59:38 +00:00
Jarek Kobus
425a0c8835 AutoTest: Connect to done() signal instead of finished()
QtcProcess::done() is also emitted when process failed to start.

Change-Id: I08f6f104014d1c90c0f761de352dada620207d86
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 12:51:42 +00:00
hjk
5f53b983ff Valgrind: Simplify pid search in remote setup
We have first-hand information nowadays from the process itself.

Change-Id: I99cc61b9c8534740b0eb59a8fabed7e648eb2146
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-20 12:47:46 +00:00
hjk
ff6f3dc65d Valgrind: Consolidate message production and consumption
Change-Id: I779f97a658b55f3c79111df1946b8d72863ce513
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-20 12:47:29 +00:00
David Schulz
178d555151 LanguageClient: prevent assert in semantic highlighter
Do not send messages to server that are not reachable, but queue the
highlighting requests until the client is fully initialized.

Change-Id: I7da140ec33fb1974d3eaed03110ed85dc3a87594
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-20 12:43:46 +00:00
Christian Kandeler
c3f55f6b50 ClangCodeModel: Fix "switch decl/def" for free functions
Fixes: QTCREATORBUG-27731
Change-Id: Ibab872b9d4ecedba097c91ca44d279a1bb8208b6
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 12:36:28 +00:00
Jarek Kobus
9db4587db5 CdbEngine: Connect to done() signal
Instead of connecting to errorOccurred() and finished() signals.

Change-Id: Id5e92fbccd361c7bce7718704f33e221649ab47b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 12:33:51 +00:00
Christian Stenger
fcb2807efa Wizards: Make PySide6 default
Change-Id: I6d84261e56dafcd55b7842e140d9c09935df70a8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 12:26:03 +00:00
Christian Kandeler
0fa349237d ClangCodeModel: Special rendering for deprecated completion items
We add the attribute textually and show a warning icon.

Fixes: QTCREATORBUG-2325
Change-Id: Icc0305a703e26c84095167087b30fa3456f97614
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 12:12:05 +00:00
Christian Kandeler
79b8e5397d ClangCodeModel: Prevent surprisingly late "follow symbol" reactions
It can happen under certain circumstances (high system load, overworked
clangd, ...) that "follow symbol" requests get replied to very late,
with the user having manually navigated to the target document in the
mean time or started doing something else entirely. In such a situation,
it would be disruptive if we were to jump to a symbol suddenly, stealing
the cursor from the unsuspecting user.
We now prevent this by aborting the "follow symbol" procedure if the
user does something else with the document.

Fixes: QTCREATORBUG-20878
Change-Id: Iea52db661e8ba634951b18654a94e4b90580f001
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 12:11:29 +00:00
hjk
0ae2e48ff1 FakeVim: Fix crash with debug build of Qt 6
915be6606ead2 in Qt base introduced an assert that triggers
occasionally.

This here moves the original check to the fakevim side, without
changing (possibly wrong) functionality.

Change-Id: I435ea53ecc0ba1a905dee2f4e3f8feb3c6dc7db3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 12:06:13 +00:00
hjk
c3dcc1ee38 Debugger: Use new clipboard setting convenience
Change-Id: I4bbbff708287a0999c8009b6c2bd91967ee63808
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 12:05:36 +00:00
hjk
2f54c9a364 Use new convenience function for clipboard contents
Change-Id: I4a856fa53e66d42bc5f08ee79c40ad071d2841bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 12:05:28 +00:00
hjk
74e35d68a8 Utils: Add a convenience function to fill clipboard and selection
Relieves the user code side from repeated code which then tends to
get forgotten.

Change-Id: I079f97a658b55f3c79111df1946b8d72863ce513
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 12:05:17 +00:00
Jarek Kobus
a13a83b65d ExecuteFilter: Connect to done() signal instead of finished()
Change-Id: I36e8ed92fc57f67da51acc7712a939bf8d7a78c6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 11:37:55 +00:00
Christian Kandeler
6fee34887b Valgrind: Fix test build
Amends 25b1c59f74.

Change-Id: Ibbc2ab6aca74e8bffa97bca53909daf2240a3eab
Reviewed-by: hjk <hjk@qt.io>
2022-06-20 10:22:00 +00:00
Christian Kandeler
b6adaab3ea CompilationDatabaseProjectManager: Fix flags extraction
The code would blindly remove all "options" starting with /, which meant
that all file paths arguments got lost on Unix-like hosts.

Fixes: QTCREATORBUG-22949
Change-Id: I43e2b1e57ed0e9ced9da8fa46d98d9ac25f83d13
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 10:20:38 +00:00
Bartlomiej Moskal
917f0d151b Android: set release flag when signing apk
Currently, signing a package by androiddeployqt automatically implies
the --release option, but there is a fix that removes it from being set
by default. To prepare QtCreator for the upcoming change and not to
change its behavior, we need to manually add the --release option to the
argument list.

Change-Id: I31df1b8252a4444afde95a043848391590f4db82
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-06-20 08:47:30 +00:00
hjk
27ce8d6177 FakeVim: Simplify calling external processes
Change-Id: I5157e2e73654df8bef65d72b7209c487e8b0c881
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-20 08:42:51 +00:00
hjk
1bea5708b4 Debugger: Make one manual test deployable to remote linux
Change-Id: Ia61926353e93ae394d3eb2082bb92769967cd958
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-20 08:27:37 +00:00
hjk
d783b4d5ff ValgrindRunner: Remove ValgrindRunner::setDevice
The device can now be determined from the debuggee's file path.

Change-Id: I2b24d6e325f74826a644d02a9e418576c4e9b436
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-20 08:08:25 +00:00
Jarek Kobus
13c7513024 QueryRunner: Connect to done() signal
Instead of connecting to errorOccurred() and finished() signals.

Change-Id: I57adabc52b38be6b22a4d7380e6fbaaae3192201
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 08:00:59 +00:00
Jarek Kobus
1d67bf597f DocumentClangToolRunner: Remove no-op call to disconnect
A call to disconnect() prior to object destruction is no-op.

Change-Id: I719d84d5fde43038c80bd2fc164ffe5e0aab1fec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-20 07:52:48 +00:00
Christian Stenger
fd5bcea5f6 QmlJS: Enhance member lookup
Check for the alias when performing a member lookup on an
import.

Fixes: QTCREATORBUG-26714
Change-Id: If3febb7d6de9fa2663cdda0143d4aa3590312ca5
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-06-20 07:11:31 +00:00
hjk
e980d87b50 Debugger: Fix LLDB start on Ubuntu 22.04
The LLDB (14) installation on Ubuntu 22.04 is broken, see
https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1972855

Work around by using a corrected PYTHONPATH when starting LLDB.

Change-Id: I9bede8f146c32f60247ca3416a14cf9ccf4b0fb6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 06:55:57 +00:00
David Schulz
3b8b247f88 Python: ignore windows store redirectors
Change-Id: Ife5c13549d73156550a7ce4b5436f1e5a19503fa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-20 06:16:08 +00:00
Cristian Adam
498418bbc9 CMakePM: Treat .h files as compile group language header types
CMake splits sources files into groups "Source Files" and "Header
Files".

CMake also has compiler groups when source files are compiled
differently.

Qt Creator is mapping the compiler groups as RawProjectParts.

In order to get the header files as part of a RawProjectPart the target
sources (which contains all sources) is mapping the header files that
match the mime type of the compiler group language type.

.h header files were considered ambigous headers, and in this
commit we treat them as the compile group language header.

Fixes: QTCREATORBUG-27117
Change-Id: If68e847846cc270f06fc2231ec44a29ea6a987c1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-19 09:45:05 +00:00
Jarek Kobus
91d1ed25c2 LldbEngine: Connect to done() signal
Instead of connecting to errorOccurred() and finished() signals.

Change-Id: If82a7c79bba9bd3457d07fbc212f6b007699b0f0
Reviewed-by: hjk <hjk@qt.io>
2022-06-17 21:45:23 +00:00
Christian Kandeler
d4b8739653 qbs build: Fix building with MSVC and Qt >= 6.3
Change-Id: I59439217575bdcc170f38382129fa5f13edb23e2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-17 15:24:00 +00:00
Cristian Adam
cdedc71182 scripts: Do not deploly clang and clang-cl executables
They were used in debugging of the libclang code model, and having
only the compiler is not very useful.

Users can install complete LLVM toolchains from llvm.org

Change-Id: If19a0b75c8505ba7589b377292bd96f855e91c00
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-17 14:05:03 +00:00
David Schulz
153ff77a6b Utils: use cleaned stdout all over the place again
Amends 5ee880ce5e

Change-Id: Ie0202db7d8455372c3697087d9571db6706b45a1
Reviewed-by: hjk <hjk@qt.io>
2022-06-17 13:04:42 +00:00
hjk
dcd3d9e717 Docker: Simplify (unused) settings page code
Change-Id: I57496f1f3150b91681724878772227ef25b65789
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-17 12:40:51 +00:00
hjk
644b51a699 Utils: Add more correct comment to QtcProcess::cleanedStd{Out,Err}
Change-Id: I50202db7d8455372c3697087d9571db6706b45a1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-06-17 12:40:34 +00:00
hjk
eb411dfeb0 RemoteLinux: Fix rscync deploystep with multiple dirs
This was quoting them into a single argument, failing if there was more
than one.

Change-Id: Idc099970f3b747918adf7559b95e749940aad11a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-06-17 12:16:09 +00:00
hjk
6517e3bbe3 Valgrind: Simplify connection setup
It's static 1:1 nowadays.

Change-Id: I0bdc62bda4aade6753b04c42d95fbbdf70c37386
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-06-17 12:12:20 +00:00
Christian Kandeler
120f3872d2 CppEditor: Add an enum to the code style preview for braces settings
So the user gets feedback for all the checkboxes by default.

Fixes: QTCREATORBUG-27268
Change-Id: I3518a7693bf31ce6c48a12905b77713c591e1853
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-06-17 12:10:42 +00:00
Christian Stenger
7d69b5b208 Tests: Provide valgrind testapps in cmake build
Change-Id: I4ec94504e3d2265d066434e118ab2eae6279a42f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-17 11:49:55 +00:00
Christian Stenger
74a7e9f00c QmlDesigner: Fix test build
Amends 50aadacb6e.

Change-Id: If6cd7a1fc4df380693f3c4deee8791ed9863672a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-06-17 11:49:36 +00:00
Eike Ziller
6767b9b737 COIN/GitHub: Use Qt 6.3.1
Change-Id: I2485ef1ec0414d503a907d69fcc277f80d569286
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-17 11:20:41 +00:00
Eike Ziller
5f48066328 Bump version to 8.0.0-beta2
Change-Id: I02a09e916d11c7ce28b2d58ba7517e582e14be06
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-17 11:14:32 +00:00
hjk
8295714ff6 Utils: Shuffle PathChooser expansion responsibility around
Change-Id: Iaee0c21e8e1c99cc034bee5b892587d3137b5508
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-06-17 10:19:59 +00:00
Jarek Kobus
f1ff0a90e0 DocumentClangToolRunner: Delete later the old runner on runNext()
Don't delete the old ClangToolRunner directly from its signal
handler when calling runNext().

Change-Id: I55e72c1cced9ecbce492d00896d6fa161df02fd0
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-06-17 10:17:55 +00:00
Alessandro Portale
f873ad1cf0 Debugger: Ensure termination of lldb.exe
LLDB 12.0.8, which is included in NDK 23.1, hesitates to termiate when
being told to. Calling QtcProcess::stop() and using CtrlCStub on Windows
helps with that.

Amends: 17ff9317cd

Fixes: QTCREATORBUG-27723
Change-Id: Ie9d4ed23a833019f445c1517983c90ae899fbf39
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-06-17 10:13:47 +00:00
Eike Ziller
016321f0c8 Merge remote-tracking branch 'origin/8.0'
Change-Id: I9f41e115adb25c08acc01110b6027020eff1a1e7
2022-06-17 11:29:14 +02:00
Mahmoud Badri
d080e6331f QmlDesigner: Parse material library on model attach
Parsing has to happen so material in an old project are correctly
appearing in the material views. Using a timer to wait until it is ok
to create the material editor node. Otherwise errors happen.

Change-Id: I54b532211f8a865c5183fab0fd8c12e5f15b983a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-06-17 08:47:04 +00:00
Marcus Tillmanns
1e70973c32 qml-debug-doc: Inform the user that breakpoints are only available in block mode
Setting / triggering breakpoints is only possible
if the target application was started with the
"block" argument.

Fixes: QTCREATORBUG-27515
Change-Id: Idafdaa87c38c8c452771897d4d845c4398d55fc4
Reviewed-by: hjk <hjk@qt.io>
2022-06-17 08:37:58 +00:00