Commit Graph

76686 Commits

Author SHA1 Message Date
Mahmoud Badri
c250d31ca0 QmlDesigner: Enable dropping external assets to a specific folder
Fixes: QDS-6311
Change-Id: I25bccfa6788e3b5d47fc598decbf7e03a00399b4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-03-04 10:14:00 +00:00
Miikka Heikkinen
8da5a772fe QmlDesigner: Group also proxy actions of commands in Edit3DWidget
This fixes exclusion handling when actions are triggered via shortcuts.

Fixes: QDS-6301
Change-Id: Iedfaaed0c2f7d534fa77743a6daa093e334d001d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-04 08:29:29 +00:00
Robert Löhning
0fa5303916 Welcome: Replace search term when adding tags
Currently, both are mixed into one so neither of them works. When both
are separated with a space, the search term is ignored anyway so it's
better to just remove it.

Change-Id: I449b5d80dc50620f13f37c908e63877eb63b3c26
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-03 20:04:20 +00:00
Robert Löhning
50199cab93 Squish: Fix checkLastBuild() with python3
Change-Id: I25c02f91eab4a7cbf784ab726e0fe24210050a84
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-03 20:02:26 +00:00
Leena Miettinen
a61c39eb26 Doc: Update screenshots of New Project and New Wizard dialogs
Rename some screenshots and use them in several places.

Fixes: QTCREATORBUG-27139
Change-Id: I3986a3060710270b4d4400228d4917e83e3183da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-03 14:11:06 +00:00
Artem Sokolovskii
72991ea5c1 [ClangFormat] Fix bax with BasedOnStyle field
Behavior was: The field became "LLVM" after a change to another style.
Fixed behavior: BasedOnStyle field becomes and stays chosen style.

Change-Id: I0d41a216f7f06c5681cc20a52c736406307a3724
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 13:26:40 +00:00
Christian Kandeler
99f73bf37f Update qbs submodule
... to HEAD of 1.22 branch.

Change-Id: Id77d7265d226949cfce18124b4bee45b65c043f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:34:14 +00:00
Orgad Shaneh
c2cceee844 QmakePM: Fix potential null dereference
Reported by Coverity.

Change-Id: Ibdb47a711aca4989b22a7f94fd905deff86cb27c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 10:24:34 +00:00
Christian Kandeler
631e2c2a4a ProjectExplorer: Log some values to narrow down a bug
Task-number: QTCREATORBUG-26875
Change-Id: Ifad56dc711241a03d391328cae202adc338ee0eb
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:21:31 +00:00
Jarek Kobus
ac3aa805b9 QtcProcess: Ensure we set the data just after creating handle
...instead of ensuring in many functions that m_setup isn't null.
This amends 36c49cd2ea and
solves the issue for other functions like processId(),
exitCode(), etc...

Amends 36c49cd2ea

Change-Id: I986f7b30e90e5825ae2bb57b4bc2aa14f56e401f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-03-03 10:02:36 +00:00
Miikka Heikkinen
98673190ad QmlDesigner: Add visualization gizmo for ParticleEmitter3D
Particle emitters are now visualized in 3D edit view either by
a small sphere for point emitters or by a proper model for
model based emitters. The visualization model is rendered
transparent. The visualization models can be displayed either
always or only when the parent particle system is active
in editor.

Trail emitters are not visualized, as any visualization would
be misleading, since these emitters follow generated particles.

Fixes: QDS-6189
Change-Id: Idb6f12cadd9cea8110e5290cc18443aeb62c38d6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-03 09:34:57 +00:00
Eike Ziller
acd7445c6e Do not require CMake 3.18
Amends 46f6c5d005

Simply disable this safe-guard for < 3.18.

Change-Id: I0ae3b7520a913861c8c9f97ec7e01e5c9c00d362
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-03 09:33:05 +00:00
Cristian Adam
1b22558857 GitHub Actions: (re) Enable MinGW build
Both LLVM/Clang 14.0 and Qt 6.2.3 dependencies have been compiled
with MinGW 11.2.0

Change-Id: I14dc8b62d243f21dc31ba72605d5aa4b16085279
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-03 09:28:31 +00:00
Eike Ziller
ce400a4482 File System view: Fix persistence of Show Folders on Top
Fixes: QTCREATORBUG-27131
Change-Id: I0252cc2d9f026873c7a6a8e70e457a8d150ca1c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-03 08:51:04 +00:00
Christian Stenger
b78b7d065f McuSupport: Fix build with Qt5
Change-Id: Iec6008f1cafd46988003a473791bf7cf1e56caea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-03 05:32:16 +00:00
Thiago Macieira
46f6c5d005 CMake: require no undefined symbols
The ELF default is historical legacy. We should always require all
libraries and all plugins to link to their dependencies and not
accidentally forget something (like implementing a virtual function).

Change-Id: I5e00996d7f4b4a10bc98fffd1629f8bfcf0d1c8f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2022-03-02 20:03:46 +00:00
hjk
36c49cd2ea Utils: Prevent early crash on non-existent commands
Change-Id: Ib94920835396e34827e7b40c30f48d28660e5fcf
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 16:35:28 +00:00
Jarek Kobus
5dd616d243 SshDeviceProcess: Forward declare IDevice
Remove some other unneeded includes.

Change-Id: I9392a61c37fa689f004d1837b3e5f94181c8586a
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 15:55:56 +00:00
hjk
d439a7a25f ProjectExplorer: Dissolve DeviceProcess
Move remaining device member to subclasses where needed.

Change-Id: I1a872315579c7f6529e8937d57511a9e99e06926
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 15:36:02 +00:00
Jarek Kobus
a17374778a Introduce ProcessProxyInterface, enable data sharing
ProcessProxyInterface will be helpful when implementing
public subclasses of ProcessInterface, like
general ssh impl, linux specific impl, qnx specific, etc.

ProcessProxyInterface is sharing private data
between proxy and target.

Change-Id: I8350837bb5f770d6605b860b146604cba5e6b592
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 15:31:13 +00:00
Alexander Drozdov
771d0d67b9 RunControl: fix device passing to the doStart()
Brokken by the f1e973de79.

We must pass local `runnable` instead of runControl()->runnable(),
otherwise device member will be nullptr that breaks all non-Desktop run
configurations, like RemoteLinux one.

Change-Id: I0499008aee14cb3bbcc3e1ebda71c50533b6502e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 14:18:31 +00:00
Cristian Adam
8c00c4c34e CMakePM: Do not modify container in loop
Amends 2f77dc3415

Change-Id: Ida99d5c83eb1b30865b90d83583244728efb38a7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 13:36:09 +00:00
Jarek Kobus
8e0ae8ba96 QtcProcess: Limit the inclusion of qtcprocess.h
Move the rest of QtcProcess enums to processenums.h.
Move ExitCodeInterpreter into processenums.h.
Remove superfluous Utils:: prefix.

Change-Id: Iaa596f353d33d6930085a621b114cc15a35caa80
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 13:30:39 +00:00
Jarek Kobus
6ff1723c4c ProcessInterface: Move out default impl into separate class
Introduce private DefaultImpl class and base QProcessImpl
and ProcessLauncherImpl on it. Remove default impl specific
methods from ProcessInterface.

Change-Id: Iea964ab19cc0ea8401180f65351b6ef3f595703f
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 13:30:14 +00:00
Christian Kandeler
9735049e2c ClangCodeModel: Suppress "Unknown argument" error
Unknown compiler flags are an unsuppressable error in clang.
But we do not want to maintain a blacklist of unsupported GCC and MSVC
options or a whitelist of supported clang options, as both would
constantly go out of date.
As clangd seems to work fine despite the error message, we simply filter
out this type of diagnostic.

Fixes: QTCREATORBUG-27113
Change-Id: Ib32601831eded60daf80eb0ca5cf01bbd71493fa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:54 +00:00
Christian Kandeler
f8cec0a85a ClangCodeModel: Properly highlight static data members
C_STATIC_MEMBER is mutually exclusive with C_FIELD, so it must not be a
mix-in style.

Task-number: QTCREATORBUG-27111
Change-Id: If9e5f44790f1b7d124f4b2e9859f8c2223c0c424
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:22 +00:00
Eike Ziller
4c465ed654 Switch to new MIME database implementation
Can be switched to old implementation by configuring with
-DQTC_USE_NEW_MIMEDATABASE=NO

Change-Id: I0fdd104c422093381589f2e154ab2b093fe92ad9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 12:41:27 +00:00
Jarek Kobus
c24ff5ad19 Use const iterator for erase
Change-Id: Ibfbc19518ad6d7d28cf864f1f94125222ed62c28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 12:35:33 +00:00
Jarek Kobus
ff0ce27c1f ApplicationLauncher: Unify API
Make the API more similar to QtcProcess API.
Rename:
  processStarted() -> started()
  error() -> errorOccurred()
  processError() -> error()

Change-Id: I86d650d55a643f5999fc91e56b985f699e2d7245
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 12:34:06 +00:00
Jarek Kobus
14d39b871d SshRemoteProcess: Add missing override
At some point QtcProcess::start() started to be virtual,
so the intention is that SshRemoteProcess overrides it.

Amends 95c9579c58

Change-Id: Iff0c0984f07440c58c5f89a0f5e188503756d6d0
Reviewed-by: hjk <hjk@qt.io>
2022-03-02 11:39:22 +00:00
Christiaan Janssen
da6cf91432 McuSupport: Change Kit Aspects validation check CMake variables
Before QUL 2.0, path for tools used during compilation were passed as
environment variables. Starting with 2.0, they are passed as CMake
configuration arguments. So, in order to validate a kit, the
dependencies aspect now needs to validate the CMake configuration
aspects. As 1.9 will no longer be supported, starting with this version
of Qt Creator, the environment checking code is removed.

Change-Id: I24991063dcdf9b455bd8f20226756dc2b3637f6d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-02 11:37:53 +00:00
hjk
1ae012df94 ProjectExplorer: Fix undefined behavior
Amends 6942c58d65.

Change-Id: I8db8ab1fd1d52467aefdc93f639816bfa1379277
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-02 11:37:37 +00:00
Cristian Adam
1778008067 GitHub Actions: Update ccache to version 4.6
Change-Id: I112d3860c6e1b66be70d5cf2b11f026bafa624ad
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 10:06:50 +00:00
Cristian Adam
e1e5d2a68d GitHub Actions: Update LLVM/Clang to version 14.0
Change-Id: I168661c4a4c2a52e824b1cfaa8ed45db1d8682dc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 10:06:42 +00:00
Jarek Kobus
4bb4bc2a99 Use ProcessInfo instead of DeviceProcessItem
Remove DeviceProcessItem class.

Change-Id: I2fcac473dc12b47f50c329645f27d60619304e77
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 09:53:29 +00:00
Jarek Kobus
87154986d2 SshRemoteProcessRunner: Remove unimplemented method
Change-Id: I4c075da36bc4f50a35692fd1ae2a61504954a05d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:57 +00:00
Jarek Kobus
53095f666f SshRemoteProcessRunner: Unify API
Make the API more similar to QtcProcess API.
Rename signals to started() and finished().

Change-Id: I01f3a148749b666b8f145d8769222a234ccc9bce
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:47 +00:00
Jarek Kobus
b5cf3186a3 SshRemoteProcessRunner: Drop error string from processClosed()
Change-Id: I3d05fb253944d6fa47854693aa4ee21d36b35a32
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 09:52:33 +00:00
Jarek Kobus
d3c1632a0f SshRemoteProcessRunner: Unify API
Make the API more similar to QtcProcess API.
Drop process prefix for getters.

Change-Id: I21b99bb5b11956d923c0e526c08bbea9686e5c95
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-02 09:52:09 +00:00
Eike Ziller
b7abe6a6ac Mimetypes v3: Re-implement setGlobPatternsForMimeType
Allows setting the glob pattern in the MIME Type settings.
Not implemented for BinaryProvider, since we don't use that for Qt
Creator.

Re-implements part of afa2212f8d

Change-Id: Ib9ab06aac833cb7d81d894e0d502f6d169618710
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-02 08:03:05 +00:00
Eike Ziller
897907f401 ImageViewer: Handle invalid SVGs and GIFs nicely
Fail opening the file in the image viewer, like we do for other images,
so Qt Creator can offer a different editor (binary editor).

We have separate code paths/backends for SVGs and movies (including
GIFs), which didn't catch invalid images early.

Fixes: QTCREATORBUG-27121
Change-Id: I1bfbca70b7d76ee9cac3e0f35494b62e3856069e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 07:48:33 +00:00
Tim Jenssen
2dfa9f0882 qds: fix crash, if two or more projects be opened
Change-Id: I8b91f8ce0139334e765d6dd55e1afefbbe5366c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 20:18:15 +00:00
Thomas Hartmann
1ea773f187 Help: Show home page when activating index or content
Instead of showing the last page this will always show the home
page when activating index or content from the help menu.

Task-number: QDS-6392
Change-Id: Ic158d22ba3739f5db513e04ebde00fdadc24a9d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-01 19:25:39 +00:00
Thomas Hartmann
af24e428f2 Rename 'output pane' to simply 'output'
Change-Id: If45e053a32855bca68dc71cb5da22f981146e45b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-01 19:25:27 +00:00
Eike Ziller
58f6ceeac4 Mimetypes v3: Never detect anything as application/x-zerosize
- That mime type is pretty useless
- If there are two mime types that match a file by glob pattern, the
  mime database implementation will find the best matching mime type by
  data of *all* mime types and take that instead (this doesn't make
  sense btw).
  That means that if .h is matched by c-hdr and c++-hdr, empty .h files
  are detected as mime type application/x-zerosize, which is pretty
  useless

Re-applies 09716d64b3

Change-Id: I2c50719863bca0dd16f92b582062502568f36c5a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-01 13:17:06 +00:00
Eike Ziller
490568385f Mimetypes v3: Re-introduce regexp as MIME magic option
Re-implements d8055b62f4

This extends the freedesktop standard, which really is lacking in many
ways.
Adds a type "regexp", which interprets the "value" as a
QRegularExpression with MultilineOption and DotMatchesEverythingOption.
The range/offset is the range of the sub-string that is matched against
the regular expression. If the value for the end of the range is
omitted, or the same as the start, the whole string is matched against
the regular expression. The mask is ignored.

Can be chosen as the type when editing MIME magic in the MIME type settings.

Change-Id: I1690d43a83848ec0cf8aeea5be20b7cde7cdc27b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-03-01 12:51:18 +00:00
Tim Jenssen
d2b39c800f qds: add missing spaces to user visible text
task-number: QDS-6379
Change-Id: Ibe84b5526413e8294f13a46d4760101e18d0ab08
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-03-01 12:39:25 +00:00
Robert Löhning
a763f5d689 Squish: Port tst_SCOM04 to CMake
Change-Id: I71f8978a41b25b2ed5fffaac1be6ff77cb3099f4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-01 12:26:13 +00:00
Leena Miettinen
7e4ee37978 Doc: Fix "typos"
Change-Id: Ifc4f6295dad8263a53e4d8b7f1da44415d09b5fd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-03-01 12:08:24 +00:00
Mahmoud Badri
85eae98e6e QmlDesigner: Allow deleting multiple selected assets
Also small relevant cleanup to the code.

Fixes: QDS-6312
Change-Id: I31ed0204ad9ae541a822cc4b58ef303aa3da7a68
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-03-01 11:59:43 +00:00