The selector would sometimes be too high (if projects were removed),
and sometimes show vertical scrollbars (if projects were added). This
problem was limited to the first time that the widget was opened on
all platforms but on OS X, where it could be observed persistently
and where its lack potentially can cause problems due to ed5d10a.
Reviewed-by: con
Task-Number: QTCREATORBUG-1792
- Unexport Core::Internal::MainWindow and remove its includes.
- Move RssFetcher from Core::Internal to Core.
- Unexport CopyTaskHandler.
- Move TextEditor's completion support and Refactor Overlay
helper classes from TextEditor::Internal to TextEditor as they
are exported.
- Move internal BaseTextBlockSelection into private header.
- Unexport TextEditorOverlay as they are not used.
It's impossible to use very long names and some clipping
occurs due to incorrect size hints on QLabel.
- Made the popup minimum width depend on the longest
project name entered. (it will not shrink)
- The build and run labels have increased minimum size hints.
- Combobox tooltip will be set to the project name as to
make it possible to expand long names.
Task-number: QTCREATORBUG-1278
RevBy: joao
Implement a BuildConfigurationModel which does the sorting.
Extend the RunConfigurationModel to do sorting.
Make the mini target selector and project page use both of those models.
Task-Nr: QTCREATORBUG-1235
This stops projects with long project names from being displayed like
this:
Project:
longprojectName
Target: Something
Thanks to Roberto for the suggestion.
I modified the text margins, removed the inconsistent
"No project" label and made sure we fall back to
the default computer icon when no project is open.
This kills the event filter since it is not really neccessary.
Most combo boxes should be disabled by default now. I Removed
redundant focus widgets from the keyboard chain and I
indicate that the list has focus by saturation.
The problem is that on windows, mouse events are replayed
if you click outside a popup to close it. If you hit the
project selector button to toggle it, this will cause
the popup to reopen on mouse release. Which we do not want.
Hence we set the DontReplay flag on mouseClick.
A similar workaround can be found in QComboBox.
I added a new focus rect for combo boxes
with manhattan style. To reduce the visual
impact I follow the same policy we use on
windows where we do not show the focus rect
unless it is called upon by tabfocus.
The actualPixmapSize is different
from the resulting pixmap when using
svg icons. This seems to be a bug
in Qt, but using the resulting pixmap
is safe for now.
* Ease cross device development by introducing 'targets' which
group build- and runsettings that are valid for this one target
Most of the kudos for the code review go to dt. Con, thorbjorn,
ckandler and others did also review parts of this patch.
Reviewed-by: dt
- Improved icon and text positioning
- Improved readability and some gfx glitches on windows and mac
- Removed drop down functionality from Run/Debug/Build buttons
The project selector also allows to select targets.
However, this is not yet used, since the necessary
changes are still being stabilized.
Done-with: con