Commit Graph

53 Commits

Author SHA1 Message Date
Alessandro Portale
ea01867297 Themes: Add a theme flag for "default" or "flat" ProjectsMode
I'd like a "flat" style to have a "default" projects mode.
This patch introduces a FlatProjectsMode. The painting code of the
widgets in the project mode follow that instead of the
Theme::WidgetStyle.

In the course of it, DoubleTabWidget does not imitate the dummy toolbar
anymore, but calls the style painting code, instead. That makes the
theme color DoubleTabWidget1stEmptyAreaBackgroundColor obsolete, so that
key disappears from the Theme enum and also from the creatorthemes.

Change-Id: Ia1479c761f61753d6738a43bbde368bf0b8814b2
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-03-07 08:47:37 +00:00
Alessandro Portale
19bb4be20c "Dark Frame" Theme: Tweaks
Adjusting the splitter color and Info Area colors.

Change-Id: Icca320df917cd5df352c19f1be2a204d1250f17b
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-03-04 16:18:51 +00:00
Alessandro Portale
ef1106a27f Revert "Gathering feedback about flat mode icons"
Feedback gathered, thank you for the patience.

This reverts commit 9e9bae54c7c456584e26b3ca61cdadd3da25726c.

Change-Id: If5be24e9f97f172d9e6f170d80b2747cf3e9dc04
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-03-04 08:39:35 +00:00
Alessandro Portale
9bde122764 default.creatortheme: add dummy FancyToolBarSeparatorColor
Change-Id: I1d7a27bf7fb749e9b13f17584e1b57db0ea0acbd
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-03-03 14:50:38 +00:00
Alessandro Portale
b0c8a68aba Flat Theme: Final touches for tool bar separators
To properly support Diana's design, we need a dedicated theme color for
the separator. Also, the vertical separators have a certain margin.

Change-Id: I4d009342a9320848ec97f5c2d324bfb672650101
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-03-03 12:19:53 +00:00
Alessandro Portale
c43c0163a5 Add the "Dark frame" Qt Creator theme
http://blog.qt.io/blog/2015/02/09/qt-creator-flat-style-ui-design-new-light-theme/
defines a dark and a light theme. We start by implementing the dark one.

"Dark frame" stands for dark toolbar areas and light content areas.
The name is silly, and we need to find a proper one before the release
(we will most likely keep the silly name, though).

Since the existing "dark" theme is much darker and has a dark content
area, we don't want to simply replace that.

Change-Id: If2197c4a07ae1e374be4449b6ed0383cdbe314b3
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-03-01 18:28:50 +00:00
Alessandro Portale
2f735a126e Dark theme: Fix selected sidebar button background
One of my recent changes must have broken the selected background color.

Change-Id: I4ed79b29193bddb4423273f65562d20e54361f9a
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-02-26 13:22:12 +00:00
Alessandro Portale
d36716ae14 Themes: Fix UI recoloring for flat themes
Reduce the usage of half-transparent colors to just the Fancy* widgets.
Otherwise, we have side effects like QTCREATORBUG-15770 in other
widgets (e.g. search results pane).

Change-Id: I0e2b0155441c4f1a071bd3c1029577accb73d56b
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-02-26 11:54:13 +00:00
Alessandro Portale
02af5d80b6 Themes: Enable UI recoloring for flat themes
Change-Id: I1907c42a769124b7505bd7afaf6c4da910f3f407
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-02-18 11:37:28 +00:00
Alessandro Portale
698e56eda8 Default Theme (Flat Icon mode): Improve contrast between icon states
Increase the contrast between enabled and disabled icons. Reduce the
contrast beween enabled icons and enabled icons with custom colors:
stop, run, resume, warning, error, info.

Change-Id: If6ae0659fb0adbd28c121ec4718449b0ca9e3270
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-02-03 10:01:20 +00:00
Alessandro Portale
ccf57c3303 Icons: Use theme color for disabled icon state
The color role was already availabe in Utils::Theme, but
Utils::Icon didn't yet make use of it. That was a bug.

Change-Id: Ifb99e08567223c0999296fde34f61de21b764b14
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2016-02-03 09:47:41 +00:00
Alessandro Portale
8dd902cfa3 Default Theme: less aggressive stop red
Change-Id: I3b490766b8423b8e575dee0e9efa6c7f9a061b05
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-29 11:04:22 +00:00
Alessandro Portale
2ff75813b2 TextEditor: Define Color Scheme entry per Theme
The TextEditor settings do not remember a global Color Scheme setting,
anymore, but rather a Color Scheme ber Theme. A .creatortheme can define
a default TextEditor Color Scheme (overridable in the settings). This
makes switching of schemes more pleasant.

Taks-number: QTCREATORBUG-15229
Change-Id: I3bd36a4dfa23feea2254be2df50fce064e8fe2af
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
2016-01-29 08:22:38 +00:00
Alessandro Portale
ff7b8ffcbb Gathering feedback about flat mode icons
No worries, this is not supposed to stay as default. I just enabled falt
icons in the default theme in order to get feedback about technical
issues as-well as comments about the look-and-feel. Send feedback to the
patch author's email.

The plan so far is to revert this mid-February, and just have flat mode
icons enabled for some alternative themes.

Change-Id: I371f4ede432597ad7f1bc4b9ae661c9f2bc8df3e
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-01-29 07:54:22 +00:00
Alessandro Portale
dc6968d1b8 default.creatortheme: White flat & active icons
Looks better.

Change-Id: If7a243b5430dc510c7687bfe08e58c8c6ce26215
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-01-19 18:23:09 +00:00
Alessandro Portale
b327f1a78c MiniSplitter: Make it actually themable via SplitterColor
The CE_Splitter drawControl code in ManhattanStyle wasn't used. This
patch removes it, changes MiniPliter::onPaint to use the theme color,
and adjusts dark.creatortheme's SplitterColor so that actually nothing
changes visually.

Change-Id: I0b94bd2125fd037c2c21dad195f31d092332db43
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-10 11:33:02 +00:00
Alessandro Portale
09d03825fc Core: Better warning/error/info icons on non-toolbars
The warning/error/info with shadow and transparent mark work
well on our toolbars but not anywhere else.

This patch creates a separate set of these icons with better
contrast, filled marks and no shadow.

Change-Id: I96787753dffd80b325336f0adc8e3be054c34618
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-12-08 13:05:54 +00:00
Alessandro Portale
93a6ecfb07 Core: Improve themeing of LineEdit icons (search, clear, ...)
...by providing a specific theme color role PanelTextColorMid.
Also, this fixes the opacity of editclear.png and magnifier.png

Change-Id: I0293eaa397a0b64595ddd66f608bdfe9f7b8e705
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-07 16:48:25 +00:00
Alessandro Portale
37c1823974 Flat and themeable side bar icons
This patch adds flat side bar icons according to
http://blog.qt.io/blog/author/didesous/

The flat icons are supposed to be opt-in, via the theme flag
"FlatSideBarIcons=true". It is false by default for the default
theme for now.

Change-Id: I1cbe69d4e138d5d23c0172a374933ac7a4ce8a5b
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-12-03 11:30:50 +00:00
Alessandro Portale
1b6d97b27f Utils: New ThemeHelper class with icon handling tools
http://blog.qt.io/blog/author/didesous/ announced new designs/themes
for Qt Creator. This patch implements the helper functions for the
loading and theme-specific recoloring of icons.

Change-Id: Ie6e96eeecb70dccd6b95338c653a9d3b760557cc
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-10-23 16:08:32 +00:00
Marco Bubke
b711b3d6e7 Clang: Set diagnostic colors for text editor scrollbar
The colors are different from issus colors to give the user a better
impression.

Change-Id: I0f9bdae8d96434512851460d4eef05e94280ee8e
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
2015-09-23 16:11:16 +00:00
Mitch Curtis
f4a9eaf3a9 Dark theme: make application output error message text color readable.
It was a pure red, which is really hard to read against a dark
background. This patch makes it a pastel red, closer to the fatal
error text color.

Change-Id: If4b402b2887149f040a00a9493f550afb296382b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-08-29 19:53:41 +00:00
Orgad Shaneh
81272a9fdb Theming: Set color for disabled widgets
Task-number: QTCREATORBUG-14528
Change-Id: I06032491470c40cd325eb2821af71becbcdd1b8a
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-07-08 07:30:25 +00:00
David Schulz
c82d287cbf Editor: Highlight Search results in scrollbar.
Change-Id: I999ddeeedbd6bdd7abebf75405d7e9281a1893df
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-06-16 09:02:14 +00:00
David Schulz
92c902c70c TextMark: Adjust color for improved visibility in the scrollbar.
Change-Id: I62a5e055942838c340ec7db8cd62a0b4e685acc5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-06-16 09:02:00 +00:00
Orgad Shaneh
a3711ee207 Fix themes
Incomplete rename done

Change-Id: Ia792d15c3e0242f3e17479ff7bfbd9e7efa3a5ae
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-05-22 05:55:38 +00:00
David Schulz
ab2a0d74de TextEditor: Sort text marks in categories.
Also adding a color for each category.

Change-Id: I3627d13913951a95804b5a816f087a822c01bd86
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-05-21 08:23:16 +00:00
Alessandro Portale
828360d87a Dark theme: Light icons for build step actions
For a dark background we need light icons.

Change-Id: I86714598be70bff981f94fb6c4e4afd6acfbe96a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-05-18 09:35:13 +00:00
Eike Ziller
a7f48ac133 Merge remote-tracking branch 'origin/3.4' 2015-03-31 09:09:32 +02:00
Thorben Kroeger
e91e1a742c Theming: fix disabled menu items in dark theme
In the dark theme (fusion style under linux), disabled
menu items looked bad due to (1) SH_EtchDisabledText being enabled
and (2) a bright color for the etch effect.

This patch adds color values for normal and disabled text colors
for menu items. It also adds a color value "style" which indicates
that the color should just stay at the default of the style.
The default theme uses this value for the new menu item colors,
while the dark theme fixes the ugly colors.
The patch also disables etching for disabled text.

Task-number: QTCREATORBUG-13447
Change-Id: Ib54504693d28cf2c71f3fc5a88d3de014230b12b
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-03-30 13:02:20 +00:00
Thorben Kroeger
e2bca47bc4 Theme: make link color readable in dark theme
Task-number: QTCREATORBUG-14208
Change-Id: I50f76c3cf5c755ccd139bd6cfb924beb0379f506
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-03-30 07:52:00 +00:00
Orgad Shaneh
919e3c7261 Theming: Unify some duplicate color roles
Change-Id: Ic000abd9bd9381e20126d0ce56ce68a35a07efe2
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-03-30 07:51:57 +00:00
Eike Ziller
65cd5381d9 Merge remote-tracking branch 'origin/3.4' 2015-03-26 12:51:06 +01:00
Thorben Kroeger
797af15584 Theming: debugger
Theme the text colors of
- the debugger's log window
- the debugger's watch items

In particular, the watch items were hard to read (default color was
black, color for changed value was red).

For the dark theme, the default color for watch items is now white
(the text color), changed items appear red, and invalid items
appear grey.

Change-Id: I7f9534b054c44d635b106fa0e9ac70479c9fcac5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-03-24 14:44:13 +00:00
Eike Ziller
9790d8aa00 Merge remote-tracking branch 'origin/3.4' 2015-03-24 07:40:21 +01:00
Thorben Kroeger
a4bb572a3b Theming: theme compile output pane
Change-Id: Ic364457884765ea755d0dc6e3e35296d5bd36359
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2015-03-23 09:12:49 +00:00
Hugues Delorme
c185d06997 Vcs: colorize file items in submit editor
It's an eye-candy feature "à la" Tortoise client

Change-Id: I5f772f2d9b1278712aea690208b0b0d08de6a80a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2015-03-13 13:16:20 +00:00
Orgad Shaneh
5db2af5c80 Theming: Use a dark yellow color for info bar
Change-Id: I04a06d40c8b95ff90a138e47e21ef29cbac29e9a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-03-09 14:22:03 +00:00
Christian Kandeler
38609296d1 Find widget: Give feedback to user about whether search has succeeded.
Right now, the only way for a user to find out whether a search term was
found is to scan the editor window for marked strings, which is a drag
in the negative case. Also, an ongoing search is practically
indistinguishable from a failed one.
Therefore, color the search term red if the search has failed.

Change-Id: I57441c3804043e1dcfb33638844b4550abd5ac46
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-02-17 10:28:11 +00:00
Orgad Shaneh
ed7c287f50 Theming: Add a Color value for splitter
Used BackgroundColorSelected as a workaround in 3.3 in order to
maintain BC.

Change-Id: I1520deb8adcfed26b65aa7f4612218d15c310923
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2015-02-13 10:25:24 +00:00
Orgad Shaneh
e717a75e38 Theming: Sort Color enum values
Change-Id: I2c234e2217ab1aa5e150e6fb721818b6ed9d22a9
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2015-02-13 10:25:19 +00:00
Orgad Shaneh
3013c43cd1 Theming: Make focused buttons lighter
They're very hard to discover.

Change-Id: I995913866a8bdab4534da05e96c3713e927e955a
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2014-12-10 10:26:42 +01:00
Alessandro Portale
6f91d7772a WelcomeScreen theming: Fix button border color
This change adds an additional color role for the border color of a
pressed button.

Task-number: QTCREATORBUG-13356
Change-Id: Ibdbd330f60063961dbf27dbe2fb90f32089d7b34
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2014-11-12 09:23:18 +01:00
Orgad Shaneh
685ea30204 Theming: Enable theming info bar
Use same role for info bar and search result widget

Change-Id: Ibe1f226d4ea8edaafb3daa1cc629e23a48322cf2
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
2014-11-10 09:03:37 +01:00
Thorben Kroeger
c725271970 Theming: fix regression in search result bg color
Task-number: QTCREATORBUG-13309
Change-Id: I320f031a49f8ad2ef4eabd80597d8183f172aa78
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-11-09 14:40:51 +01:00
Thorben Kroeger
cf45c854e0 Theming: allow to override base style
Change-Id: I48e2d03b83fccf3d6eb4b508bd77912dbdaea1d0
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-11-06 08:40:57 +01:00
Thorben Kroeger
82bbc6f562 Theming: Allow to apply theme palette globally
Change-Id: I709bd6b6c566e016731af1fb94ddaef6326ef485
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-11-06 08:40:49 +01:00
Orgad Shaneh
6b4c254bf3 Theming: Fix light colored find widgets style
It is used when e.g. searching the environment widget.

Change-Id: I203b9f5e280a8f18f7a38f8e4d7b4540c79f932c
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-10-23 13:57:37 +02:00
Alessandro Portale
ca9ed45016 Theming: Remove IconOverlay section from default.creatortheme
IconOverlays are now defined in the Images section. Also,
default.creatortheme does not need to define these since they are
already defined in the cpp code as fallback.

See a18b067326

Change-Id: Id2cf616068b11c5aa8e43ee695369063e6a4ee0e
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-10-20 09:09:30 +02:00
Alessandro Portale
1c451c7a8a Theming: Small font color fix in default theme
Inactive doubleTabWidget tabs had a white color. This patch restores
that.

Change-Id: I775de6b4a647cc9a6f064e8658b7a675d5b605fc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-10-17 16:31:30 +02:00