forked from qt-creator/qt-creator
It was no longer showing any updates. At some point MaintenanceTool added <?xml...> headers to its responses, which broke our combine-and- parse hack, since such a header in the middle of XML is invalid. Add a hack that removes these headers first. This should be refactored without the use of ShellCommand in master, because that doesn't allow us to access the output of the two jobs separately. Change-Id: I7248b070a8edb1a45248b3531ed50bb0d94eef73 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
168 lines
6.4 KiB
C++
168 lines
6.4 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2022 the Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#pragma once
|
|
|
|
#include <utils/algorithm.h>
|
|
#include <utils/optional.h>
|
|
|
|
#include <QDomDocument>
|
|
#include <QList>
|
|
#include <QLoggingCategory>
|
|
#include <QRegularExpression>
|
|
#include <QVersionNumber>
|
|
|
|
#include <memory>
|
|
|
|
Q_DECLARE_LOGGING_CATEGORY(log)
|
|
|
|
std::unique_ptr<QDomDocument> documentForResponse(const QString &response)
|
|
{
|
|
// since the output can contain two toplevel items from the two separate MaintenanceTool runs,
|
|
// clean up any <?xml version="1.0"?> and surround with a toplevel element
|
|
QString responseWithoutHeader = response;
|
|
responseWithoutHeader.remove(QRegularExpression("<\\?xml.*\\?>"));
|
|
const QString xml = response.isEmpty() ? QString()
|
|
: ("<doc>" + responseWithoutHeader + "</doc>");
|
|
std::unique_ptr<QDomDocument> doc(new QDomDocument);
|
|
doc->setContent(xml);
|
|
return doc;
|
|
}
|
|
|
|
struct Update
|
|
{
|
|
QString name;
|
|
QString version;
|
|
|
|
bool operator==(const Update &other) const
|
|
{
|
|
return other.name == name && other.version == version;
|
|
};
|
|
};
|
|
|
|
QList<Update> availableUpdates(const QDomDocument &document)
|
|
{
|
|
if (document.isNull() || !document.firstChildElement().hasChildNodes())
|
|
return {};
|
|
QList<Update> result;
|
|
const QDomNodeList updates = document.firstChildElement().elementsByTagName("update");
|
|
for (int i = 0; i < updates.size(); ++i) {
|
|
const QDomNode node = updates.item(i);
|
|
if (node.isElement()) {
|
|
const QDomElement element = node.toElement();
|
|
if (element.hasAttribute("name"))
|
|
result.append({element.attribute("name"), element.attribute("version")});
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
struct QtPackage
|
|
{
|
|
QString displayName;
|
|
QVersionNumber version;
|
|
bool installed;
|
|
bool isPrerelease = false;
|
|
|
|
bool operator==(const QtPackage &other) const
|
|
{
|
|
return other.installed == installed && other.isPrerelease == isPrerelease
|
|
&& other.version == version && other.displayName == displayName;
|
|
}
|
|
};
|
|
|
|
QList<QtPackage> availableQtPackages(const QDomDocument &document)
|
|
{
|
|
if (document.isNull() || !document.firstChildElement().hasChildNodes())
|
|
return {};
|
|
QList<QtPackage> result;
|
|
const QDomNodeList packages = document.firstChildElement().elementsByTagName("package");
|
|
for (int i = 0; i < packages.size(); ++i) {
|
|
const QDomNode node = packages.item(i);
|
|
if (node.isElement()) {
|
|
const QDomElement element = node.toElement();
|
|
if (element.hasAttribute("displayname") && element.hasAttribute("name")
|
|
&& element.hasAttribute("version")) {
|
|
QtPackage package{element.attribute("displayname"),
|
|
QVersionNumber::fromString(element.attribute("version")),
|
|
element.hasAttribute("installedVersion")};
|
|
// Heuristic: Prerelease if the name is not "Qt x.y.z"
|
|
// (prereleases are named "Qt x.y.z-alpha" etc)
|
|
package.isPrerelease = package.displayName
|
|
!= QString("Qt %1").arg(package.version.toString());
|
|
result.append(package);
|
|
}
|
|
}
|
|
}
|
|
std::sort(result.begin(), result.end(), [](const QtPackage &p1, const QtPackage &p2) {
|
|
return p1.version > p2.version;
|
|
});
|
|
return result;
|
|
}
|
|
|
|
// Expects packages to be sorted, high version first.
|
|
Utils::optional<QtPackage> highestInstalledQt(const QList<QtPackage> &packages)
|
|
{
|
|
const auto highestInstalledIt = std::find_if(packages.cbegin(),
|
|
packages.cend(),
|
|
[](const QtPackage &p) { return p.installed; });
|
|
if (highestInstalledIt == packages.cend()) // Qt not installed
|
|
return {};
|
|
return *highestInstalledIt;
|
|
}
|
|
|
|
// Expects packages to be sorted, high version first.
|
|
Utils::optional<QtPackage> qtToNagAbout(const QList<QtPackage> &allPackages,
|
|
QVersionNumber *highestSeen)
|
|
{
|
|
// Filter out any Qt prereleases
|
|
const QList<QtPackage> packages = Utils::filtered(allPackages, [](const QtPackage &p) {
|
|
return !p.isPrerelease;
|
|
});
|
|
if (packages.isEmpty())
|
|
return {};
|
|
const QtPackage highest = packages.constFirst();
|
|
qCDebug(log) << "Highest available (non-prerelease) Qt:" << highest.version;
|
|
qCDebug(log) << "Highest previously seen (non-prerelease) Qt:" << *highestSeen;
|
|
// if the highestSeen version is null, we don't know if the Qt version is new, and better don't nag
|
|
const bool isNew = !highestSeen->isNull() && highest.version > *highestSeen;
|
|
if (highestSeen->isNull() || isNew)
|
|
*highestSeen = highest.version;
|
|
if (!isNew)
|
|
return {};
|
|
const Utils::optional<QtPackage> highestInstalled = highestInstalledQt(packages);
|
|
qCDebug(log) << "Highest installed Qt:"
|
|
<< qPrintable(highestInstalled ? highestInstalled->version.toString()
|
|
: QString("none"));
|
|
if (!highestInstalled) // don't nag if no Qt is installed at all
|
|
return {};
|
|
if (highestInstalled->version == highest.version)
|
|
return {};
|
|
return highest;
|
|
}
|
|
|
|
Q_DECLARE_METATYPE(Update)
|
|
Q_DECLARE_METATYPE(QtPackage)
|