forked from qt-creator/qt-creator
d52ac9a708
...with an extra parse.
Previously, the creation of an e.g. "Qt Widgets Application" from the
wizard could show code model errors in mainwindow.cpp. Depending on
timing issues, the first error is either
1. 'ui_mainwindow.h' file not found (QTCREATORBUG-15187)
The parse happened before the in-memory ui_mainwindow.h was
generated by uic. The file system watcher can't help here as the
#include was not resolved successfully. And libclang's reparse does
not handle this case (it would need to remember all failed #include
stats...).
==> Detect this case with the help of the include paths and trigger
a full parse.
2. or: allocation of incomplete type... (QTCREATORBUG-15187)
The parse happened after the generation of the in-memory
ui_mainwindow.h, but before the clangbackend received the unsaved
file.
==> Fix this by also writing the content of the unsaved file to our
behind-the-scenes-created ui_mainwindow.h.
Fixes: QTCREATORBUG-15187
Fixes: QTCREATORBUG-17002
Change-Id: I4f3a81adaa3d604746977a402c29f83fbc5b0e44
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
109 lines
4.0 KiB
C++
109 lines
4.0 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include "googletest.h"
|
|
|
|
#include <clangcodecompleteresults.h>
|
|
#include <clangdocument.h>
|
|
#include <clangfilepath.h>
|
|
#include <clangtranslationunitupdater.h>
|
|
#include <clangtranslationunit.h>
|
|
#include <clangdocuments.h>
|
|
#include <unsavedfiles.h>
|
|
#include <utf8string.h>
|
|
|
|
#include <clang-c/Index.h>
|
|
|
|
namespace {
|
|
|
|
using ClangBackEnd::ClangCodeCompleteResults;
|
|
using ClangBackEnd::FilePath;
|
|
using ClangBackEnd::Document;
|
|
using ClangBackEnd::UnsavedFiles;
|
|
|
|
static unsigned completionOptions()
|
|
{
|
|
return ClangBackEnd::TranslationUnitUpdater::defaultParseOptions()
|
|
& CXTranslationUnit_IncludeBriefCommentsInCodeCompletion
|
|
? CXCodeComplete_IncludeBriefComments
|
|
: 0;
|
|
}
|
|
|
|
TEST(ClangCodeCompleteResultsSlowTest, GetData)
|
|
{
|
|
ClangBackEnd::UnsavedFiles unsavedFiles;
|
|
ClangBackEnd::Documents documents{unsavedFiles};
|
|
Document document(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
|
|
{},
|
|
{},
|
|
documents);
|
|
Utf8String nativeFilePath = FilePath::toNativeSeparators(document.filePath());
|
|
document.parse();
|
|
CXCodeCompleteResults *cxCodeCompleteResults =
|
|
clang_codeCompleteAt(document.translationUnit().cxTranslationUnit(),
|
|
nativeFilePath.constData(),
|
|
49, 1, 0, 0,
|
|
completionOptions());
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
ASSERT_THAT(codeCompleteResults.data(), cxCodeCompleteResults);
|
|
}
|
|
|
|
TEST(ClangCodeCompleteResults, GetInvalidData)
|
|
{
|
|
CXCodeCompleteResults *cxCodeCompleteResults = clang_codeCompleteAt(nullptr, "file.cpp", 49, 1, 0, 0, 0);
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
ASSERT_THAT(codeCompleteResults.data(), cxCodeCompleteResults);
|
|
}
|
|
|
|
TEST(ClangCodeCompleteResultsSlowTest, MoveClangCodeCompleteResults)
|
|
{
|
|
ClangBackEnd::UnsavedFiles unsavedFiles;
|
|
ClangBackEnd::Documents documents{unsavedFiles};
|
|
Document document(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
|
|
{},
|
|
{},
|
|
documents);
|
|
Utf8String nativeFilePath = FilePath::toNativeSeparators(document.filePath());
|
|
document.parse();
|
|
CXCodeCompleteResults *cxCodeCompleteResults =
|
|
clang_codeCompleteAt(document.translationUnit().cxTranslationUnit(),
|
|
nativeFilePath.constData(),
|
|
49, 1, 0, 0,
|
|
completionOptions());
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
const ClangCodeCompleteResults codeCompleteResults2 = std::move(codeCompleteResults);
|
|
|
|
ASSERT_TRUE(codeCompleteResults.isNull());
|
|
ASSERT_FALSE(codeCompleteResults2.isNull());
|
|
}
|
|
|
|
}
|