feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
Files
2a8c48cb15d50b8686e5cb4f29a96f4431a0ec37
qt-creator/tests/auto/cplusplus/misc/tst_misc.cpp
Nikolai Kosjar 76006a1353 C++: Fix crash with invalid raw string literal 
While parsing a document Bind::asStringLiteral() Token::spell() was
called for a raw string literal token with a Token::literal nullptr.

This is due scanRawStringLiteral() not properly aborting for
invalid/incomplete code and that the code paths handling
multi-line-raw-strings were not limited to the highlighting case.

Address both cases.

Task-number: QTCREATORBUG-18941
Change-Id: I489d288ccbd7b59be396dada846613ff555436cf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-09-20 07:38:04 +00:00

284 lines
9.8 KiB
C++
Raw Blame History

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include <cplusplus/ASTPath.h>
#include <cplusplus/CppDocument.h>
#include <cplusplus/findcdbbreakpoint.h>
#include <QtTest>
#include <QDebug>
//TESTED_COMPONENT=src/libs/cplusplus
using namespace CPlusPlus;
class tst_Misc: public QObject
{
Q_OBJECT
private slots:
void diagnosticClient_error();
void diagnosticClient_warning();
void findBreakpoints();
void findBreakpoints2();
void findBreakpoints3();
void astPathOnGeneratedTokens();
void typeMatcher();
void doNotCrashForInvalidRawString();
};
void tst_Misc::diagnosticClient_error()
{
const QByteArray src("\n"
"class Foo {}\n"
);
Document::Ptr doc = Document::create("diagnosticClient_error");
QVERIFY(!doc.isNull());
doc->setUtf8Source(src);
bool success = doc->parse(Document::ParseTranlationUnit);
QVERIFY(success);
QList<Document::DiagnosticMessage> diagnostics = doc->diagnosticMessages();
QVERIFY(diagnostics.size() == 1);
const Document::DiagnosticMessage &msg = diagnostics.at(0);
QCOMPARE(msg.level(), (int) Document::DiagnosticMessage::Error);
QCOMPARE(msg.line(), 2U);
QCOMPARE(msg.column(), 1U);
}
void tst_Misc::diagnosticClient_warning()
{
const QByteArray src("\n"
"using namespace ;\n"
);
Document::Ptr doc = Document::create("diagnosticClient_warning");
QVERIFY(!doc.isNull());
doc->setUtf8Source(src);
bool success = doc->parse(Document::ParseTranlationUnit);
QVERIFY(success);
QList<Document::DiagnosticMessage> diagnostics = doc->diagnosticMessages();
QVERIFY(diagnostics.size() == 1);
const Document::DiagnosticMessage &msg = diagnostics.at(0);
QCOMPARE(msg.level(), (int) Document::DiagnosticMessage::Warning);
QCOMPARE(msg.line(), 1U);
QCOMPARE(msg.column(), 17U);
}
void tst_Misc::findBreakpoints()
{
const QByteArray src("\n" // line 0
"class C {\n"
" int a;\n"
" C():\n"
" a(0)\n" // line 4
" {\n" // line 5
" }\n"
" void empty()\n" // line 7
" {\n" // line 8
" }\n"
" void misc() \n"
" { \n" // line 11
" if ( \n" // line 12
" a \n" // line 13
" && \n" // line 14
" b \n" // line 15
" ) \n" // line 16
" { \n" // line 17
" } \n" // line 18
" while ( \n" // line 19
" a \n" // line 20
" && \n" // line 21
" b \n" // line 22
" ) \n" // line 23
" { \n" // line 24
" } \n" // line 25
" do { \n" // line 26
" } \n" // line 27
" while ( \n" // line 28
" a \n" // line 39
" && \n" // line 30
" b \n" // line 31
" ); \n" // line 32
" } \n"
"}; \n"
);
Document::Ptr doc = Document::create("findContstructorBreakpoint");
QVERIFY(!doc.isNull());
doc->setUtf8Source(src);
bool success = doc->parse();
QVERIFY(success);
QCOMPARE(doc->diagnosticMessages().size(), 0);
FindCdbBreakpoint findBreakpoint(doc->translationUnit());
QCOMPARE(findBreakpoint(0), 5U);
QCOMPARE(findBreakpoint(7), 8U);
QCOMPARE(findBreakpoint(11), 16U);
QCOMPARE(findBreakpoint(17), 23U);
QCOMPARE(findBreakpoint(18), 23U);
}
void tst_Misc::findBreakpoints2()
{
const QByteArray src("\n" // line 0
"void foo() {\n"
" int a = 2;\n" // line 2
" switch (x) {\n" // line 3
" case 1: {\n" // line 4
" int y = 2;\n" // line 5
" y++;\n"
" break;\n" // line 7
" }\n"
" }\n"
"}\n"
);
Document::Ptr doc = Document::create("findSwitchBreakpoint");
QVERIFY(!doc.isNull());
doc->setUtf8Source(src);
bool success = doc->parse();
QVERIFY(success);
QCOMPARE(doc->diagnosticMessages().size(), 0);
FindCdbBreakpoint findBreakpoint(doc->translationUnit());
QCOMPARE(findBreakpoint(0), 2U);
QCOMPARE(findBreakpoint(1), 2U);
QCOMPARE(findBreakpoint(2), 2U);
QCOMPARE(findBreakpoint(3), 3U);
QCOMPARE(findBreakpoint(4), 5U);
QCOMPARE(findBreakpoint(5), 5U);
QCOMPARE(findBreakpoint(6), 6U);
QCOMPARE(findBreakpoint(7), 7U);
}
void tst_Misc::findBreakpoints3()
{
const QByteArray src("\n" // line 0
"int foo() {\n"
" try {\n" // line 2
" bar();\n" // line 3
" } catch (Mooze &m) {\n" // line 4
" wooze();\n" // line 5
" }\n"
" return 0;\n" // line 7
"}\n"
);
Document::Ptr doc = Document::create("findCatchBreakpoint");
QVERIFY(!doc.isNull());
doc->setUtf8Source(src);
bool success = doc->parse();
QVERIFY(success);
QCOMPARE(doc->diagnosticMessages().size(), 0);
FindCdbBreakpoint findBreakpoint(doc->translationUnit());
QCOMPARE(findBreakpoint(2), 3U);
QCOMPARE(findBreakpoint(3), 3U);
QCOMPARE(findBreakpoint(4), 5U);
QCOMPARE(findBreakpoint(5), 5U);
QCOMPARE(findBreakpoint(7), 7U);
}
static Document::Ptr documentCreatedWithFastPreprocessor(const QByteArray source)
{
Snapshot snapshot;
auto document = snapshot.preprocessedDocument(source, QLatin1String("test.cpp"));
document->check();
return document;
}
void tst_Misc::astPathOnGeneratedTokens()
{
const QByteArray source =
"#define INT int\n"
"#define S ;\n"
"INT x S\n";
const auto document = documentCreatedWithFastPreprocessor(source);
ASTPath astPath(document);
// Check start
auto paths = astPath(3, 1);
QCOMPARE(paths.size(), 0);
// Check middle
paths = astPath(3, 5);
QCOMPARE(paths.size(), 5);
QVERIFY(paths.at(0)->asTranslationUnit());
QVERIFY(paths.at(1)->asSimpleDeclaration());
QVERIFY(paths.at(2)->asDeclarator());
QVERIFY(paths.at(3)->asDeclaratorId());
QVERIFY(paths.at(4)->asSimpleName());
// Check end
for (auto i : {7, 8, 9}) {
paths = astPath(3, i);
QCOMPARE(paths.size(), 2);
QVERIFY(paths.at(0)->asTranslationUnit());
QVERIFY(paths.at(1)->asSimpleDeclaration());
}
}
void tst_Misc::typeMatcher()
{
IntegerType dummyType(IntegerType::Int);
FullySpecifiedType type1(&dummyType);
FullySpecifiedType type2(&dummyType);
for (int i = 0; i < (1<<8); ++i) {
type1.setConst (i & (1 << 0));
type1.setVolatile(i & (1 << 1));
type1.setSigned (i & (1 << 2));
type1.setUnsigned(i & (1 << 3));
type2.setConst (i & (1 << 4));
type2.setVolatile(i & (1 << 5));
type2.setSigned (i & (1 << 6));
type2.setUnsigned(i & (1 << 7));
const unsigned type1Specifiers = (i & 0x0f);
const unsigned type2Specifiers = (i >> 4);
const bool sameSpecifiers = type1Specifiers == type2Specifiers;
QCOMPARE(type1.match(type2), sameSpecifiers);
QCOMPARE(type2.match(type1), sameSpecifiers);
}
}
void tst_Misc::doNotCrashForInvalidRawString()
{
const QByteArray src("\n"
"void f() { enum { Size = sizeof(R\"[^\\s]+([^]+)*\") }; }"
"}\n"
);
Document::Ptr doc = Document::create("crash");
doc->setUtf8Source(src);
doc->check();
}
QTEST_MAIN(tst_Misc)
#include "tst_misc.moc"
View Git Blame Copy Permalink