forked from qt-creator/qt-creator
		
	libclang 3.8 seems to be sensitive to file paths separators [1]. On Windows, this led to not updated document annotations and/or crashes after reparsing. When passing file paths to libclang, convert to native separators. When getting file paths from libclang, convert back. This handles: * main file path * file paths of the unsaved files * -I<DIR> arguments, the resource path (for builtins) and the paths to the wrapped qt headers * included header files from libclang * source locations from libclang Also, minimize the conversion in SourceLocation to a minimum by making filePath() lazy. [1] https://llvm.org/bugs/show_bug.cgi?id=28381 Change-Id: If5866f34a6fdc6b34b16c022d3988e8e6eae2a0a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
		
			
				
	
	
		
			240 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			240 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
/****************************************************************************
 | 
						|
**
 | 
						|
** Copyright (C) 2016 The Qt Company Ltd.
 | 
						|
** Contact: https://www.qt.io/licensing/
 | 
						|
**
 | 
						|
** This file is part of Qt Creator.
 | 
						|
**
 | 
						|
** Commercial License Usage
 | 
						|
** Licensees holding valid commercial Qt licenses may use this file in
 | 
						|
** accordance with the commercial license agreement provided with the
 | 
						|
** Software or, alternatively, in accordance with the terms contained in
 | 
						|
** a written agreement between you and The Qt Company. For licensing terms
 | 
						|
** and conditions see https://www.qt.io/terms-conditions. For further
 | 
						|
** information use the contact form at https://www.qt.io/contact-us.
 | 
						|
**
 | 
						|
** GNU General Public License Usage
 | 
						|
** Alternatively, this file may be used under the terms of the GNU
 | 
						|
** General Public License version 3 as published by the Free Software
 | 
						|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
 | 
						|
** included in the packaging of this file. Please review the following
 | 
						|
** information to ensure the GNU General Public License requirements will
 | 
						|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
 | 
						|
**
 | 
						|
****************************************************************************/
 | 
						|
 | 
						|
#include "gtest/gtest.h"
 | 
						|
#include "gmock/gmock-matchers.h"
 | 
						|
#include "gmock/gmock.h"
 | 
						|
#include "gtest-qt-printing.h"
 | 
						|
 | 
						|
#include <clangfilepath.h>
 | 
						|
#include <unsavedfile.h>
 | 
						|
#include <unsavedfiles.h>
 | 
						|
 | 
						|
using ClangBackEnd::FilePath;
 | 
						|
using ClangBackEnd::UnsavedFile;
 | 
						|
using ClangBackEnd::UnsavedFiles;
 | 
						|
 | 
						|
using ::testing::Eq;
 | 
						|
using ::testing::PrintToString;
 | 
						|
 | 
						|
namespace {
 | 
						|
 | 
						|
MATCHER_P3(IsUnsavedFile, fileName, contents, contentsLength,
 | 
						|
          std::string(negation ? "isn't" : "is")
 | 
						|
          + " file name " + PrintToString(fileName)
 | 
						|
          + ", contents " + PrintToString(contents)
 | 
						|
          + ", contents length " + PrintToString(contentsLength))
 | 
						|
{
 | 
						|
    CXUnsavedFile unsavedFile = arg.cxUnsavedFile;
 | 
						|
 | 
						|
    return fileName == unsavedFile.Filename
 | 
						|
        && contents == unsavedFile.Contents
 | 
						|
        && size_t(contentsLength) == unsavedFile.Length;
 | 
						|
}
 | 
						|
 | 
						|
class UnsavedFile : public ::testing::Test
 | 
						|
{
 | 
						|
protected:
 | 
						|
    Utf8String filePath = Utf8StringLiteral("path");
 | 
						|
    Utf8String fileContent = Utf8StringLiteral("content");
 | 
						|
 | 
						|
    Utf8String otherFilePath = Utf8StringLiteral("otherpath");
 | 
						|
    Utf8String otherFileContent = Utf8StringLiteral("othercontent");
 | 
						|
 | 
						|
    Utf8String absoluteFilePath = Utf8StringLiteral(TESTDATA_DIR"/file.cpp");
 | 
						|
 | 
						|
    uint aLength = 2;
 | 
						|
    Utf8String aReplacement = Utf8StringLiteral("replacement");
 | 
						|
};
 | 
						|
 | 
						|
TEST_F(UnsavedFile, Create)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
 | 
						|
    ASSERT_THAT(unsavedFile, IsUnsavedFile(filePath,
 | 
						|
                                           fileContent,
 | 
						|
                                           fileContent.byteSize()));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, Destruct)
 | 
						|
{
 | 
						|
    auto *unsavedFile = new ::UnsavedFile(filePath, fileContent);
 | 
						|
    unsavedFile->~UnsavedFile();
 | 
						|
 | 
						|
    ASSERT_THAT(*unsavedFile, IsUnsavedFile(nullptr, nullptr, 0UL));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, ConstructMoveToIsValid)
 | 
						|
{
 | 
						|
    ::UnsavedFile movedFrom(filePath, fileContent);
 | 
						|
 | 
						|
    ::UnsavedFile movedTo = std::move(movedFrom);
 | 
						|
 | 
						|
    ASSERT_THAT(movedTo, IsUnsavedFile(filePath,
 | 
						|
                                       fileContent,
 | 
						|
                                       fileContent.byteSize()));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, ConstructMoveFromIsNull)
 | 
						|
{
 | 
						|
    ::UnsavedFile movedFrom(filePath, fileContent);
 | 
						|
 | 
						|
    ::UnsavedFile movedTo = std::move(movedFrom);
 | 
						|
 | 
						|
    ASSERT_THAT(movedFrom, IsUnsavedFile(nullptr, nullptr, 0UL));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, AssignMoveToIsValid)
 | 
						|
{
 | 
						|
    ::UnsavedFile movedFrom(filePath, fileContent);
 | 
						|
    ::UnsavedFile movedTo(otherFilePath, otherFileContent);
 | 
						|
 | 
						|
    movedTo = std::move(movedFrom);
 | 
						|
 | 
						|
    ASSERT_THAT(movedTo, IsUnsavedFile(filePath,
 | 
						|
                                       fileContent,
 | 
						|
                                       fileContent.byteSize()));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, AssignMoveFromIsSwapped)
 | 
						|
{
 | 
						|
    ::UnsavedFile movedFrom(filePath, fileContent);
 | 
						|
    ::UnsavedFile movedTo(otherFilePath, otherFileContent);
 | 
						|
 | 
						|
    movedTo = std::move(movedFrom);
 | 
						|
 | 
						|
    ASSERT_THAT(movedFrom, IsUnsavedFile(otherFilePath,
 | 
						|
                                         otherFileContent,
 | 
						|
                                         otherFileContent.byteSize()));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, FilePath)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(absoluteFilePath, QStringLiteral(""));
 | 
						|
 | 
						|
    ASSERT_THAT(unsavedFile.filePath(), Eq(absoluteFilePath));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, NativeFilePath)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(absoluteFilePath, QStringLiteral(""));
 | 
						|
    const Utf8String nativeFilePath = FilePath::toNativeSeparators(absoluteFilePath);
 | 
						|
 | 
						|
    ASSERT_THAT(unsavedFile.nativeFilePath(), Eq(nativeFilePath));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, DoNotReplaceWithOffsetZeroInEmptyContent)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, QStringLiteral(""));
 | 
						|
 | 
						|
    ASSERT_FALSE(unsavedFile.replaceAt(0, aLength, aReplacement));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, DoNotReplaceWithOffsetOneInEmptyContent)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, QStringLiteral(""));
 | 
						|
 | 
						|
    ASSERT_FALSE(unsavedFile.replaceAt(1, aLength, aReplacement));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, Replace)
 | 
						|
{
 | 
						|
    const Utf8String expectedContent = Utf8StringLiteral("hello replacement!");
 | 
						|
    ::UnsavedFile unsavedFile(filePath, Utf8StringLiteral("hello world!"));
 | 
						|
 | 
						|
    const bool hasReplaced = unsavedFile.replaceAt(6, 5, aReplacement);
 | 
						|
 | 
						|
    ASSERT_TRUE(hasReplaced);
 | 
						|
    ASSERT_THAT(unsavedFile, IsUnsavedFile(filePath, expectedContent, expectedContent.byteSize()));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, ToUtf8PositionForValidLineColumn)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
    bool ok = false;
 | 
						|
 | 
						|
    const uint position = unsavedFile.toUtf8Position(1, 1, &ok);
 | 
						|
 | 
						|
    ASSERT_TRUE(ok);
 | 
						|
    ASSERT_THAT(position, Eq(0));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, ToUtf8PositionForInValidLineColumn)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
    bool ok = false;
 | 
						|
 | 
						|
    unsavedFile.toUtf8Position(2, 1, &ok);
 | 
						|
 | 
						|
    ASSERT_FALSE(ok);
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, ToUtf8PositionForDefaultConstructedUnsavedFile)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile;
 | 
						|
    bool ok = false;
 | 
						|
 | 
						|
    unsavedFile.toUtf8Position(1, 1, &ok);
 | 
						|
 | 
						|
    ASSERT_FALSE(ok);
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, HasNoCharacterForDefaultConstructedUnsavedFile)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile;
 | 
						|
 | 
						|
    ASSERT_FALSE(unsavedFile.hasCharacterAt(0, 'x'));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, HasNoCharacterForTooBigOffset)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
 | 
						|
    ASSERT_FALSE(unsavedFile.hasCharacterAt(100, 'x'));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, HasNoCharacterForWrongOffset)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
 | 
						|
    ASSERT_FALSE(unsavedFile.hasCharacterAt(0, 'x'));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, HasCharacterForCorrectOffset)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
 | 
						|
    ASSERT_TRUE(unsavedFile.hasCharacterAt(0, 'c'));
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(UnsavedFile, HasCharacterForLastLineColumn)
 | 
						|
{
 | 
						|
    ::UnsavedFile unsavedFile(filePath, fileContent);
 | 
						|
 | 
						|
    ASSERT_TRUE(unsavedFile.hasCharacterAt(1, 7, 't'));
 | 
						|
}
 | 
						|
 | 
						|
} // anonymous namespace
 |