Files
qt-creator/src/plugins/cmakeprojectmanager/cmakebuildstep.h
Aaron Barany d2e420bfe7 CMake: Don't change targets when parsing fails
When first loading a CMake project, if parsing fails all targets get reset
to the "all" target. Most commonly users will notice this when the "clean"
target gets reset to "all", and can often go unnoticed for a while. This
can become especially annoying when custom target configurations are used.
With this change the previous targets will be preserved upon failure.

Fixes: QTCREATORBUG-21617
Change-Id: I52a3a2c472c7b8d98bc016b1e55a202147fc091c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-01-25 18:48:18 +00:00

143 lines
4.0 KiB
C++

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#pragma once
#include <projectexplorer/abstractprocessstep.h>
#include <QRegExp>
QT_BEGIN_NAMESPACE
class QLineEdit;
class QListWidget;
class QListWidgetItem;
QT_END_NAMESPACE
namespace Utils { class PathChooser; }
namespace ProjectExplorer { class ToolChain; }
namespace CMakeProjectManager {
namespace Internal {
class CMakeBuildConfiguration;
class CMakeRunConfiguration;
class CMakeBuildStepFactory;
class CMakeBuildStep : public ProjectExplorer::AbstractProcessStep
{
Q_OBJECT
friend class CMakeBuildStepFactory;
public:
explicit CMakeBuildStep(ProjectExplorer::BuildStepList *bsl);
CMakeBuildConfiguration *cmakeBuildConfiguration() const;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
QString buildTarget() const;
bool buildsBuildTarget(const QString &target) const;
void setBuildTarget(const QString &target);
void clearBuildTargets();
QString toolArguments() const;
void setToolArguments(const QString &list);
QString allArguments(const CMakeRunConfiguration *rc) const;
QString cmakeCommand() const;
QVariantMap toMap() const override;
static QString cleanTarget();
static QString allTarget();
static QString installTarget();
static QString testTarget();
static QStringList specialTargets();
signals:
void cmakeCommandChanged();
void targetToBuildChanged();
void buildTargetsChanged();
protected:
void processStarted() override;
void processFinished(int exitCode, QProcess::ExitStatus status) override;
bool fromMap(const QVariantMap &map) override;
// For parsing [ 76%]
void stdOutput(const QString &line) override;
private:
void ctor(ProjectExplorer::BuildStepList *bsl);
void runImpl(QFutureInterface<bool> &fi);
void handleProjectWasParsed(QFutureInterface<bool> &fi, bool success);
void handleBuildTargetChanges(bool success);
CMakeRunConfiguration *targetsActiveRunConfiguration() const;
QMetaObject::Connection m_runTrigger;
QRegExp m_percentProgress;
QRegExp m_ninjaProgress;
QString m_ninjaProgressString;
QString m_buildTarget;
QString m_toolArguments;
bool m_useNinja = false;
};
class CMakeBuildStepConfigWidget : public ProjectExplorer::BuildStepConfigWidget
{
Q_OBJECT
public:
CMakeBuildStepConfigWidget(CMakeBuildStep *buildStep);
private:
void itemChanged(QListWidgetItem*);
void toolArgumentsEdited();
void updateDetails();
void buildTargetsChanged();
void selectedBuildTargetsChanged();
CMakeBuildStep *m_buildStep;
QLineEdit *m_toolArguments;
QListWidget *m_buildTargetsList;
};
class CMakeBuildStepFactory : public ProjectExplorer::BuildStepFactory
{
public:
CMakeBuildStepFactory();
};
} // namespace Internal
} // namespace CMakeProjectManager