forked from qt-creator/qt-creator
Remove SnapShot::{find,contains}(QString) overloads and fix fallout.
Change-Id: I50c415826939e09ac111f33def611c7478fa5d97
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
390 lines
14 KiB
C++
390 lines
14 KiB
C++
// Copyright (C) 2020 The Qt Company Ltd.
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0+ OR GPL-3.0 WITH Qt-GPL-exception-1.0
|
|
|
|
#include "documentclangtoolrunner.h"
|
|
|
|
#include "clangfileinfo.h"
|
|
#include "clangtidyclazyrunner.h"
|
|
#include "clangtoolruncontrol.h"
|
|
#include "clangtoolsconstants.h"
|
|
#include "clangtoolsprojectsettings.h"
|
|
#include "clangtoolsutils.h"
|
|
#include "diagnosticmark.h"
|
|
#include "executableinfo.h"
|
|
#include "virtualfilesystemoverlay.h"
|
|
|
|
#include <coreplugin/documentmanager.h>
|
|
#include <coreplugin/editormanager/editormanager.h>
|
|
#include <coreplugin/editormanager/ieditor.h>
|
|
|
|
#include <cppeditor/cppmodelmanager.h>
|
|
|
|
#include <projectexplorer/buildconfiguration.h>
|
|
#include <projectexplorer/buildtargettype.h>
|
|
#include <projectexplorer/session.h>
|
|
#include <projectexplorer/target.h>
|
|
|
|
#include <texteditor/textdocument.h>
|
|
#include <texteditor/texteditor.h>
|
|
#include <texteditor/textmark.h>
|
|
|
|
#include <utils/qtcassert.h>
|
|
#include <utils/utilsicons.h>
|
|
|
|
#include <QLoggingCategory>
|
|
|
|
static Q_LOGGING_CATEGORY(LOG, "qtc.clangtools.cftr", QtWarningMsg)
|
|
|
|
using namespace Core;
|
|
using namespace CppEditor;
|
|
using namespace ProjectExplorer;
|
|
using namespace Utils;
|
|
|
|
namespace ClangTools {
|
|
namespace Internal {
|
|
|
|
DocumentClangToolRunner::DocumentClangToolRunner(IDocument *document)
|
|
: QObject(document)
|
|
, m_document(document)
|
|
, m_temporaryDir("clangtools-single-XXXXXX")
|
|
{
|
|
|
|
m_runTimer.setInterval(500);
|
|
m_runTimer.setSingleShot(true);
|
|
|
|
connect(m_document,
|
|
&IDocument::contentsChanged,
|
|
this,
|
|
&DocumentClangToolRunner::scheduleRun);
|
|
connect(CppModelManager::instance(),
|
|
&CppModelManager::projectPartsUpdated,
|
|
this,
|
|
&DocumentClangToolRunner::scheduleRun);
|
|
connect(ClangToolsSettings::instance(),
|
|
&ClangToolsSettings::changed,
|
|
this,
|
|
&DocumentClangToolRunner::scheduleRun);
|
|
connect(&m_runTimer, &QTimer::timeout, this, &DocumentClangToolRunner::run);
|
|
run();
|
|
}
|
|
|
|
DocumentClangToolRunner::~DocumentClangToolRunner()
|
|
{
|
|
cancel();
|
|
qDeleteAll(m_marks);
|
|
}
|
|
|
|
FilePath DocumentClangToolRunner::filePath() const
|
|
{
|
|
return m_document->filePath();
|
|
}
|
|
|
|
Diagnostics DocumentClangToolRunner::diagnosticsAtLine(int lineNumber) const
|
|
{
|
|
Diagnostics diagnostics;
|
|
if (auto textDocument = qobject_cast<TextEditor::TextDocument *>(m_document)) {
|
|
for (auto mark : textDocument->marksAt(lineNumber)) {
|
|
if (mark->category() == Constants::DIAGNOSTIC_MARK_ID)
|
|
diagnostics << static_cast<DiagnosticMark *>(mark)->diagnostic();
|
|
}
|
|
}
|
|
return diagnostics;
|
|
}
|
|
|
|
static void removeClangToolRefactorMarkers(TextEditor::TextEditorWidget *editor)
|
|
{
|
|
if (!editor)
|
|
return;
|
|
editor->setRefactorMarkers(
|
|
TextEditor::RefactorMarker::filterOutType(editor->refactorMarkers(),
|
|
Constants::CLANG_TOOL_FIXIT_AVAILABLE_MARKER_ID));
|
|
}
|
|
|
|
void DocumentClangToolRunner::scheduleRun()
|
|
{
|
|
for (DiagnosticMark *mark : std::as_const(m_marks))
|
|
mark->disable();
|
|
for (TextEditor::TextEditorWidget *editor : std::as_const(m_editorsWithMarkers))
|
|
removeClangToolRefactorMarkers(editor);
|
|
m_runTimer.start();
|
|
}
|
|
|
|
static Project *findProject(const FilePath &file)
|
|
{
|
|
Project *project = SessionManager::projectForFile(file);
|
|
return project ? project : SessionManager::startupProject();
|
|
}
|
|
|
|
static VirtualFileSystemOverlay &vfso()
|
|
{
|
|
static VirtualFileSystemOverlay overlay("clangtools-vfso-XXXXXX");
|
|
return overlay;
|
|
}
|
|
|
|
static FileInfo getFileInfo(const FilePath &file, Project *project)
|
|
{
|
|
const ProjectInfo::ConstPtr projectInfo = CppModelManager::instance()->projectInfo(project);
|
|
if (!projectInfo)
|
|
return {};
|
|
|
|
FileInfo candidate;
|
|
for (const ProjectPart::ConstPtr &projectPart : projectInfo->projectParts()) {
|
|
QTC_ASSERT(projectPart, continue);
|
|
|
|
for (const ProjectFile &projectFile : std::as_const(projectPart->files)) {
|
|
QTC_ASSERT(projectFile.kind != ProjectFile::Unclassified, continue);
|
|
QTC_ASSERT(projectFile.kind != ProjectFile::Unsupported, continue);
|
|
if (projectFile.path == CppModelManager::configurationFileName().path())
|
|
continue;
|
|
const auto projectFilePath = FilePath::fromString(projectFile.path);
|
|
if (file != projectFilePath)
|
|
continue;
|
|
if (!projectFile.active)
|
|
continue;
|
|
// found the best candidate, early return
|
|
ProjectFile::Kind sourceKind = ProjectFile::sourceKind(projectFile.kind);
|
|
if (projectPart->buildTargetType != BuildTargetType::Unknown)
|
|
return FileInfo(projectFilePath, sourceKind, projectPart);
|
|
// found something but keep looking for better candidates
|
|
if (candidate.projectPart.isNull())
|
|
candidate = FileInfo(projectFilePath, sourceKind, projectPart);
|
|
}
|
|
}
|
|
|
|
return candidate;
|
|
}
|
|
|
|
static Environment projectBuildEnvironment(Project *project)
|
|
{
|
|
Environment env;
|
|
if (Target *target = project->activeTarget()) {
|
|
if (BuildConfiguration *buildConfig = target->activeBuildConfiguration())
|
|
env = buildConfig->environment();
|
|
}
|
|
if (!env.isValid())
|
|
env = Environment::systemEnvironment();
|
|
return env;
|
|
}
|
|
|
|
void DocumentClangToolRunner::run()
|
|
{
|
|
cancel();
|
|
auto isEditorForCurrentDocument = [this](const IEditor *editor) {
|
|
return editor->document() == m_document;
|
|
};
|
|
if (Utils::anyOf(EditorManager::visibleEditors(), isEditorForCurrentDocument)) {
|
|
const FilePath filePath = m_document->filePath();
|
|
if (Project *project = findProject(filePath)) {
|
|
m_fileInfo = getFileInfo(filePath, project);
|
|
if (m_fileInfo.file.exists()) {
|
|
const auto projectSettings = ClangToolsProjectSettings::getSettings(project);
|
|
|
|
const RunSettings &runSettings = projectSettings->useGlobalSettings()
|
|
? ClangToolsSettings::instance()->runSettings()
|
|
: projectSettings->runSettings();
|
|
|
|
m_suppressed = projectSettings->suppressedDiagnostics();
|
|
m_lastProjectDirectory = project->projectDirectory();
|
|
m_projectSettingsUpdate = connect(projectSettings.data(),
|
|
&ClangToolsProjectSettings::changed,
|
|
this,
|
|
&DocumentClangToolRunner::run);
|
|
|
|
if (runSettings.analyzeOpenFiles()) {
|
|
vfso().update();
|
|
|
|
ClangDiagnosticConfig config = diagnosticConfig(
|
|
runSettings.diagnosticConfigId());
|
|
|
|
Environment env = projectBuildEnvironment(project);
|
|
if (config.isClangTidyEnabled()) {
|
|
m_runnerCreators << [this, env, config]() {
|
|
return createRunner<ClangTidyRunner>(config, env);
|
|
};
|
|
}
|
|
if (config.isClazyEnabled()) {
|
|
m_runnerCreators << [this, env, config]() {
|
|
return createRunner<ClazyStandaloneRunner>(config, env);
|
|
};
|
|
}
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
deleteLater();
|
|
}
|
|
|
|
runNext();
|
|
}
|
|
|
|
QPair<FilePath, QString> getClangIncludeDirAndVersion(ClangToolRunner *runner)
|
|
{
|
|
static QMap<FilePath, QPair<FilePath, QString>> cache;
|
|
const FilePath tool = runner->executable();
|
|
auto it = cache.find(tool);
|
|
if (it == cache.end())
|
|
it = cache.insert(tool, getClangIncludeDirAndVersion(tool));
|
|
return it.value();
|
|
}
|
|
|
|
void DocumentClangToolRunner::runNext()
|
|
{
|
|
if (m_currentRunner)
|
|
m_currentRunner.release()->deleteLater();
|
|
m_currentRunner.reset(m_runnerCreators.isEmpty() ? nullptr : m_runnerCreators.takeFirst()());
|
|
if (m_currentRunner) {
|
|
auto [clangIncludeDir, clangVersion] = getClangIncludeDirAndVersion(m_currentRunner.get());
|
|
qCDebug(LOG) << Q_FUNC_INFO << m_currentRunner->executable() << clangIncludeDir
|
|
<< clangVersion << m_fileInfo.file;
|
|
if (m_currentRunner->executable().isEmpty() || clangIncludeDir.isEmpty() || clangVersion.isEmpty()
|
|
|| (m_document->isModified() && !m_currentRunner->supportsVFSOverlay())) {
|
|
runNext();
|
|
} else {
|
|
AnalyzeUnit unit(m_fileInfo, clangIncludeDir, clangVersion);
|
|
QTC_ASSERT(FilePath::fromString(unit.file).exists(), runNext(); return;);
|
|
m_currentRunner->setVFSOverlay(vfso().overlayFilePath().toString());
|
|
if (!m_currentRunner->run(unit.file, unit.arguments))
|
|
runNext();
|
|
}
|
|
} else {
|
|
finalize();
|
|
}
|
|
}
|
|
|
|
static void updateLocation(Debugger::DiagnosticLocation &location)
|
|
{
|
|
location.filePath = vfso().originalFilePath(location.filePath);
|
|
}
|
|
|
|
void DocumentClangToolRunner::onSuccess()
|
|
{
|
|
QString errorMessage;
|
|
FilePath mappedPath = vfso().autoSavedFilePath(m_document);
|
|
Diagnostics diagnostics = readExportedDiagnostics(
|
|
FilePath::fromString(m_currentRunner->outputFilePath()),
|
|
[&](const FilePath &path) { return path == mappedPath; },
|
|
&errorMessage);
|
|
|
|
for (Diagnostic &diag : diagnostics) {
|
|
updateLocation(diag.location);
|
|
for (ExplainingStep &explainingStep : diag.explainingSteps) {
|
|
updateLocation(explainingStep.location);
|
|
for (Debugger::DiagnosticLocation &rangeLocation : explainingStep.ranges)
|
|
updateLocation(rangeLocation);
|
|
}
|
|
}
|
|
|
|
// remove outdated marks of the current runner
|
|
auto [toDelete, newMarks] = Utils::partition(m_marks, [this](DiagnosticMark *mark) {
|
|
return mark->source == m_currentRunner->name();
|
|
});
|
|
m_marks = newMarks;
|
|
qDeleteAll(toDelete);
|
|
|
|
auto doc = qobject_cast<TextEditor::TextDocument *>(m_document);
|
|
|
|
TextEditor::RefactorMarkers markers;
|
|
|
|
for (const Diagnostic &diagnostic : diagnostics) {
|
|
if (isSuppressed(diagnostic))
|
|
continue;
|
|
|
|
auto mark = new DiagnosticMark(diagnostic);
|
|
mark->source = m_currentRunner->name();
|
|
|
|
if (doc && Utils::anyOf(diagnostic.explainingSteps, &ExplainingStep::isFixIt)) {
|
|
TextEditor::RefactorMarker marker;
|
|
marker.tooltip = diagnostic.description;
|
|
QTextCursor cursor(doc->document());
|
|
cursor.setPosition(Text::positionInText(doc->document(),
|
|
diagnostic.location.line,
|
|
diagnostic.location.column));
|
|
cursor.movePosition(QTextCursor::EndOfLine);
|
|
marker.cursor = cursor;
|
|
marker.type = Constants::CLANG_TOOL_FIXIT_AVAILABLE_MARKER_ID;
|
|
marker.callback = [marker](TextEditor::TextEditorWidget *editor) {
|
|
editor->setTextCursor(marker.cursor);
|
|
editor->invokeAssist(TextEditor::QuickFix);
|
|
};
|
|
markers << marker;
|
|
}
|
|
|
|
m_marks << mark;
|
|
}
|
|
|
|
for (auto editor : TextEditor::BaseTextEditor::textEditorsForDocument(doc)) {
|
|
if (TextEditor::TextEditorWidget *widget = editor->editorWidget()) {
|
|
widget->setRefactorMarkers(markers + widget->refactorMarkers());
|
|
if (!m_editorsWithMarkers.contains(widget))
|
|
m_editorsWithMarkers << widget;
|
|
}
|
|
}
|
|
|
|
runNext();
|
|
}
|
|
|
|
void DocumentClangToolRunner::onFailure(const QString &errorMessage, const QString &errorDetails)
|
|
{
|
|
qCDebug(LOG) << "Failed to analyze " << m_fileInfo.file << ":" << errorMessage << errorDetails;
|
|
runNext();
|
|
}
|
|
|
|
void DocumentClangToolRunner::finalize()
|
|
{
|
|
// remove all disabled textMarks
|
|
auto [newMarks, toDelete] = Utils::partition(m_marks, &DiagnosticMark::enabled);
|
|
m_marks = newMarks;
|
|
qDeleteAll(toDelete);
|
|
}
|
|
|
|
void DocumentClangToolRunner::cancel()
|
|
{
|
|
if (m_projectSettingsUpdate)
|
|
disconnect(m_projectSettingsUpdate);
|
|
m_runnerCreators.clear();
|
|
m_currentRunner.reset(nullptr);
|
|
}
|
|
|
|
bool DocumentClangToolRunner::isSuppressed(const Diagnostic &diagnostic) const
|
|
{
|
|
auto equalsSuppressed = [this, &diagnostic](const SuppressedDiagnostic &suppressed) {
|
|
if (suppressed.description != diagnostic.description)
|
|
return false;
|
|
FilePath filePath = suppressed.filePath;
|
|
if (filePath.toFileInfo().isRelative())
|
|
filePath = m_lastProjectDirectory.pathAppended(filePath.toString());
|
|
return filePath == diagnostic.location.filePath;
|
|
};
|
|
return Utils::anyOf(m_suppressed, equalsSuppressed);
|
|
}
|
|
|
|
const ClangDiagnosticConfig DocumentClangToolRunner::getDiagnosticConfig(Project *project)
|
|
{
|
|
const auto projectSettings = ClangToolsProjectSettings::getSettings(project);
|
|
m_projectSettingsUpdate = connect(projectSettings.data(),
|
|
&ClangToolsProjectSettings::changed,
|
|
this,
|
|
&DocumentClangToolRunner::run);
|
|
|
|
const Id id = projectSettings->useGlobalSettings()
|
|
? ClangToolsSettings::instance()->runSettings().diagnosticConfigId()
|
|
: projectSettings->runSettings().diagnosticConfigId();
|
|
return diagnosticConfig(id);
|
|
}
|
|
|
|
template<class T>
|
|
ClangToolRunner *DocumentClangToolRunner::createRunner(const ClangDiagnosticConfig &config,
|
|
const Environment &env)
|
|
{
|
|
auto runner = new T(config, this);
|
|
runner->init(m_temporaryDir.path(), env);
|
|
connect(runner, &ClangToolRunner::finishedWithSuccess,
|
|
this, &DocumentClangToolRunner::onSuccess);
|
|
connect(runner, &ClangToolRunner::finishedWithFailure,
|
|
this, &DocumentClangToolRunner::onFailure);
|
|
return runner;
|
|
}
|
|
|
|
} // namespace Internal
|
|
} // namespace ClangTools
|