forked from qt-creator/qt-creator
ProjectInfo, ProjectPart and ProjectUpdateInfo used to carry pointers to Project and/or Toolchain, even though they were used in contexts where these pointers were either unsafe to access or not guaranteed to be valid anymore, which made their use difficult and error-prone. We turn these classes into pure value types by copying in all relevant information before the first async operation takes place. Fixes: QTCREATORBUG-25678 Change-Id: I1914b0dbda6c7dfba6c95e5e92f2d69977755590 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
141 lines
4.4 KiB
C++
141 lines
4.4 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include "modelmanagertesthelper.h"
|
|
|
|
#include "cpptoolstestcase.h"
|
|
#include "cppworkingcopy.h"
|
|
#include "projectinfo.h"
|
|
|
|
#include <projectexplorer/session.h>
|
|
|
|
#include <QtTest>
|
|
|
|
#include <cassert>
|
|
|
|
using namespace CppTools::Internal;
|
|
using namespace CppTools::Tests;
|
|
|
|
TestProject::TestProject(const QString &name, QObject *parent, const Utils::FilePath &filePath) :
|
|
ProjectExplorer::Project("x-binary/foo", filePath),
|
|
m_name(name)
|
|
{
|
|
setParent(parent);
|
|
setId(Utils::Id::fromString(name));
|
|
setDisplayName(name);
|
|
qRegisterMetaType<QSet<QString> >();
|
|
}
|
|
|
|
ModelManagerTestHelper::ModelManagerTestHelper(QObject *parent,
|
|
bool testOnlyForCleanedProjects)
|
|
: QObject(parent)
|
|
, m_testOnlyForCleanedProjects(testOnlyForCleanedProjects)
|
|
|
|
{
|
|
CppModelManager *mm = CppModelManager::instance();
|
|
connect(this, &ModelManagerTestHelper::aboutToRemoveProject,
|
|
mm, &CppModelManager::onAboutToRemoveProject);
|
|
connect(this, &ModelManagerTestHelper::projectAdded,
|
|
mm, &CppModelManager::onProjectAdded);
|
|
connect(mm, &CppModelManager::sourceFilesRefreshed,
|
|
this, &ModelManagerTestHelper::sourceFilesRefreshed);
|
|
connect(mm, &CppModelManager::gcFinished,
|
|
this, &ModelManagerTestHelper::gcFinished);
|
|
|
|
cleanup();
|
|
QVERIFY(Tests::VerifyCleanCppModelManager::isClean(m_testOnlyForCleanedProjects));
|
|
}
|
|
|
|
ModelManagerTestHelper::~ModelManagerTestHelper()
|
|
{
|
|
cleanup();
|
|
QVERIFY(Tests::VerifyCleanCppModelManager::isClean(m_testOnlyForCleanedProjects));
|
|
}
|
|
|
|
void ModelManagerTestHelper::cleanup()
|
|
{
|
|
CppModelManager *mm = CppModelManager::instance();
|
|
QList<ProjectInfo::Ptr> pies = mm->projectInfos();
|
|
for (Project * const p : qAsConst(m_projects)) {
|
|
ProjectExplorer::SessionManager::removeProject(p);
|
|
emit aboutToRemoveProject(p);
|
|
}
|
|
|
|
if (!pies.isEmpty())
|
|
waitForFinishedGc();
|
|
}
|
|
|
|
ModelManagerTestHelper::Project *ModelManagerTestHelper::createProject(
|
|
const QString &name, const Utils::FilePath &filePath)
|
|
{
|
|
auto tp = new TestProject(name, this, filePath);
|
|
m_projects.push_back(tp);
|
|
ProjectExplorer::SessionManager::addProject(tp);
|
|
emit projectAdded(tp);
|
|
return tp;
|
|
}
|
|
|
|
QSet<QString> ModelManagerTestHelper::updateProjectInfo(
|
|
const CppTools::ProjectInfo::Ptr &projectInfo)
|
|
{
|
|
resetRefreshedSourceFiles();
|
|
CppModelManager::instance()->updateProjectInfo(projectInfo).waitForFinished();
|
|
QCoreApplication::processEvents();
|
|
return waitForRefreshedSourceFiles();
|
|
}
|
|
|
|
void ModelManagerTestHelper::resetRefreshedSourceFiles()
|
|
{
|
|
m_lastRefreshedSourceFiles.clear();
|
|
m_refreshHappened = false;
|
|
}
|
|
|
|
QSet<QString> ModelManagerTestHelper::waitForRefreshedSourceFiles()
|
|
{
|
|
while (!m_refreshHappened)
|
|
QCoreApplication::processEvents();
|
|
|
|
return m_lastRefreshedSourceFiles;
|
|
}
|
|
|
|
void ModelManagerTestHelper::waitForFinishedGc()
|
|
{
|
|
m_gcFinished = false;
|
|
|
|
while (!m_gcFinished)
|
|
QCoreApplication::processEvents();
|
|
}
|
|
|
|
void ModelManagerTestHelper::sourceFilesRefreshed(const QSet<QString> &files)
|
|
{
|
|
m_lastRefreshedSourceFiles = files;
|
|
m_refreshHappened = true;
|
|
}
|
|
|
|
void ModelManagerTestHelper::gcFinished()
|
|
{
|
|
m_gcFinished = true;
|
|
}
|