feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
Files
77270648e8687c00329dc0cba62d4befcb228d8c
qt-creator/src/plugins/cpptools
History
Nikolai Kosjar 77270648e8 CppTools: Fix dead lock on project unloading 
...with the clang code model.

In updateProjectInfo() we lock the project mutex and emit a signal.
However, the correspondig slot in the clang code model will call back
into a function that needs to lock the mutex, too:

    CppTools::CppModelManager::workingCopy // dead locks here
    CppTools::BaseEditorDocumentParser::InMemoryInfo::InMemoryInfo
    ClangCodeModel::Internal::ClangEditorDocumentProcessor::run
    ClangCodeModel::Internal::ModelManagerSupportClang::unregisterTranslationUnitsWithProjectParts
    ClangCodeModel::Internal::ModelManagerSupportClang::onProjectPartsRemoved
     ...
    CppTools::CppModelManager::projectPartsRemoved
    CppTools::CppModelManager::updateProjectInfo // emits here

Fixed by emitting the signal after releasing the mutex.

Change-Id: Id3f3cd22b0604f343ada56ea13c26f0dc1a75bd6
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
2015-10-14 10:10:47 +00:00
..
images
CppTools: Move setting category icon from Core to CppTools
2014-06-03 10:50:01 +02:00
abstracteditorsupport.cpp
Old-style wizards: Handle line continuation in license templates
2015-09-22 09:17:02 +00:00
abstracteditorsupport.h
CppTools: Remove unnecessary code from abstracteditorsupport
2015-09-14 10:26:31 +00:00
baseeditordocumentparser.cpp
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
baseeditordocumentparser.h
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
baseeditordocumentprocessor.cpp
Clang: Integrate clang's fixits as refactoring actions
2015-09-29 11:39:21 +00:00
baseeditordocumentprocessor.h
Clang: Integrate clang's fixits as refactoring actions
2015-09-29 11:39:21 +00:00
builtineditordocumentparser.cpp
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
builtineditordocumentparser.h
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
builtineditordocumentprocessor.cpp
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
builtineditordocumentprocessor.h
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
builtinindexingsupport.cpp
Remove unused function
2015-08-17 16:26:24 +00:00
builtinindexingsupport.h
CppTools: Remove separate indexing revision
2015-04-24 08:35:13 +00:00
commentssettings.cpp
Update License
2015-01-16 12:37:56 +01:00
commentssettings.h
Update License
2015-01-16 12:37:56 +01:00
completionsettingspage.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
completionsettingspage.h
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
completionsettingspage.ui
TextEditor: Make automatic completion timeout configurable
2014-12-15 15:24:37 +01:00
cppchecksymbols.cpp
CppTools: Fix highlighting and follow for template using argument
2015-06-09 11:31:40 +00:00
cppchecksymbols.h
C++: Rename ClassOrNamespace -> LookupScope
2015-04-20 14:51:56 +00:00
cppclassesfilter.cpp
Update License
2015-01-16 12:37:56 +01:00
cppclassesfilter.h
cpptools: s/Q_DECL_OVERRIDE/override/g
2015-06-04 12:25:51 +00:00
cppcodeformatter.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppcodeformatter.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcodegen_test.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppcodemodelinspectordumper.cpp
CppTools: Use project part ids instead of file paths
2015-07-20 09:49:14 +00:00
cppcodemodelinspectordumper.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcodemodelsettings.cpp
CppTools: Add CppModelManager::isManagedById
2015-08-31 15:02:11 +00:00
cppcodemodelsettings.h
CppTools: Add CppModelManager::isManagedById
2015-08-31 15:02:11 +00:00
cppcodemodelsettingspage.cpp
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppcodemodelsettingspage.h
Update License
2015-01-16 12:37:56 +01:00
cppcodemodelsettingspage.ui
C++: add header chooser to codemodel settings page.
2014-01-07 09:29:20 +01:00
cppcodestylepreferences.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppcodestylepreferences.h
Update License
2015-01-16 12:37:56 +01:00
cppcodestylepreferencesfactory.cpp
Update License
2015-01-16 12:37:56 +01:00
cppcodestylepreferencesfactory.h
Update License
2015-01-16 12:37:56 +01:00
cppcodestylesettings.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcodestylesettings.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcodestylesettingspage.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcodestylesettingspage.h
Update License
2015-01-16 12:37:56 +01:00
cppcodestylesettingspage.ui
Rename "[Mm]ethod(s)" to "[Ff]unction(s)"
2013-10-10 15:56:12 +02:00
cppcompletion_test.cpp
C++: Comment out a flaky test
2015-09-28 15:30:16 +00:00
cppcompletionassist.cpp
CppTools: Do not read language features from document in completer
2015-09-16 12:54:11 +00:00
cppcompletionassist.h
C++: Fix crash after triggering completion and closing editor
2015-09-02 12:37:23 +00:00
cppcompletionassistprocessor.cpp
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppcompletionassistprocessor.h
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppcompletionassistprovider.cpp
CppTools: Add basic completion support for qt5 style signals/slots
2015-02-17 13:47:38 +00:00
cppcompletionassistprovider.h
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppcurrentdocumentfilter.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppcurrentdocumentfilter.h
Update License
2015-01-16 12:37:56 +01:00
cppdoxygen.cpp
Update License
2015-01-16 12:37:56 +01:00
cppdoxygen.h
Update License
2015-01-16 12:37:56 +01:00
cppeditoroutline.cpp
Clean exported headers of the TextEditor plugin.
2015-02-26 13:15:29 +00:00
cppeditoroutline.h
CppTools: Remove some pointless declarations
2015-07-08 13:25:13 +00:00
cppfileiterationorder.cpp
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
cppfileiterationorder.h
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
cppfilesettingspage.cpp
LicenseTemplate: Use macro expansion
2015-09-22 09:16:48 +00:00
cppfilesettingspage.h
LicenseTemplate: Use macro expansion
2015-09-22 09:16:48 +00:00
cppfilesettingspage.ui
Fix layouts for OSX: Set the obligatory ExpandingFieldsGrow
2015-02-24 11:45:53 +00:00
cppfindreferences.cpp
CppEditor: Move static symbol finder instance to CppTools
2015-10-12 14:04:31 +00:00
cppfindreferences.h
Update License
2015-01-16 12:37:56 +01:00
cppfunctionsfilter.cpp
Update License
2015-01-16 12:37:56 +01:00
cppfunctionsfilter.h
cpptools: s/Q_DECL_OVERRIDE/override/g
2015-06-04 12:25:51 +00:00
cppheadersource_test.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppincludesfilter.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppincludesfilter.h
Add locator filter for all included files.
2015-01-12 15:06:20 +01:00
cppindexingsupport.cpp
Update License
2015-01-16 12:37:56 +01:00
cppindexingsupport.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cpplocalsymbols_test.cpp
Update License
2015-01-16 12:37:56 +01:00
cpplocalsymbols.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cpplocalsymbols.h
Update License
2015-01-16 12:37:56 +01:00
cpplocatordata.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cpplocatordata.h
Update License
2015-01-16 12:37:56 +01:00
cpplocatorfilter_test.cpp
CppTools: Tests: time out in waitForFileInGlobalSnapshot()
2015-02-18 12:16:29 +00:00
cpplocatorfilter.cpp
Clean exported headers of the TextEditor plugin.
2015-02-26 13:15:29 +00:00
cpplocatorfilter.h
Update License
2015-01-16 12:37:56 +01:00
cppmodelmanager_test.cpp
Fix changing "#include" lines after file renaming
2015-10-06 13:17:55 +00:00
cppmodelmanager.cpp
CppTools: Fix dead lock on project unloading
2015-10-14 10:10:47 +00:00
cppmodelmanager.h
CppEditor: Move static symbol finder instance to CppTools
2015-10-12 14:04:31 +00:00
cppmodelmanagersupport.cpp
Update License
2015-01-16 12:37:56 +01:00
cppmodelmanagersupport.h
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppmodelmanagersupportinternal.cpp
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cppmodelmanagersupportinternal.h
Clang: Use completion through backend process
2015-06-10 10:15:40 +00:00
cpppointerdeclarationformatter_test.cpp
Move "open" from IEditor to IDocument
2015-06-10 11:21:17 +00:00
cpppointerdeclarationformatter.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cpppointerdeclarationformatter.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppprojectfile.cpp
MimeDatabase: Remove bestMatch, which was broken beyond repair
2015-02-27 16:02:25 +00:00
cppprojectfile.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppprojects.cpp
Merge remote-tracking branch 'origin/3.5'
2015-08-04 13:16:03 +02:00
cppprojects.h
ToolChain: Get rid of type() in favor of typeId()
2015-07-14 14:40:03 +00:00
cppqtstyleindenter.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppqtstyleindenter.h
Update License
2015-01-16 12:37:56 +01:00
cpprefactoringchanges.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cpprefactoringchanges.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
cppsemanticinfo.cpp
Update License
2015-01-16 12:37:56 +01:00
cppsemanticinfo.h
Update License
2015-01-16 12:37:56 +01:00
cppsemanticinfoupdater.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cppsemanticinfoupdater.h
CppTools: Remove some pointless declarations
2015-07-08 13:25:13 +00:00
cppsourceprocessertesthelper.cpp
Update License
2015-01-16 12:37:56 +01:00
cppsourceprocessertesthelper.h
Update License
2015-01-16 12:37:56 +01:00
cppsourceprocessor_test.cpp
CppTools: Avoid unnecessary blocking of main thread
2015-07-10 14:04:07 +00:00
cppsourceprocessor.cpp
CppTools: Allow to limit the files to process by file size
2015-05-13 08:26:52 +00:00
cppsourceprocessor.h
cpptools: s/Q_DECL_OVERRIDE/override/g
2015-06-04 12:25:51 +00:00
cpptools_dependencies.pri
Merge remote-tracking branch 'origin/3.4'
2015-03-24 07:40:21 +01:00
cpptools_global.h
Update License
2015-01-16 12:37:56 +01:00
CppTools.json.in
Update License
2015-01-16 12:37:56 +01:00
cpptools.pro
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
cpptools.qbs
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
cpptools.qrc
CppTools: Move setting category icon from Core to CppTools
2014-06-03 10:50:01 +02:00
cpptoolsconstants.h
Preferences: Options pages need unique IDs
2015-08-10 11:55:01 +00:00
cpptoolsjsextension.cpp
Update License
2015-01-16 12:37:56 +01:00
cpptoolsjsextension.h
Update License
2015-01-16 12:37:56 +01:00
cpptoolsplugin.cpp
CppTools: SwitchHeaderSource file name case sensitivity
2015-09-23 11:39:11 +00:00
cpptoolsplugin.h
Fix changing "#include" lines after file renaming
2015-10-06 13:17:55 +00:00
cpptoolsreuse.cpp
CppTools: Fix comparing size for QTC_CPP_FILE_SIZE_LIMIT_MB
2015-09-24 09:03:02 +00:00
cpptoolsreuse.h
Clang: Do not call DocumentManager::modifiedDocuments() from worker thread
2015-07-10 14:04:19 +00:00
cpptoolssettings.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cpptoolssettings.h
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
cpptoolstestcase.cpp
Open Project: Don't show a error dialog for duplicated projects
2015-08-24 11:29:09 +00:00
cpptoolstestcase.h
CppTools: Avoid unnecessary blocking of main thread
2015-07-10 14:04:07 +00:00
cpptoolsunittestfiles.pri
Clang: Add revision and completion management
2015-09-28 15:46:15 +00:00
cppworkingcopy.cpp
Update License
2015-01-16 12:37:56 +01:00
cppworkingcopy.h
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
doxygengenerator.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
doxygengenerator.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
editordocumenthandle.cpp
Clang: Add UpdateTranslationUnitsForEditorMessage
2015-10-13 14:03:11 +00:00
editordocumenthandle.h
Clang: Add UpdateTranslationUnitsForEditorMessage
2015-10-13 14:03:11 +00:00
functionutils.cpp
CppTools: Fix misdetection of virtual function overloads
2015-06-17 13:00:30 +00:00
functionutils.h
Update License
2015-01-16 12:37:56 +01:00
includeutils.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
includeutils.h
Update License
2015-01-16 12:37:56 +01:00
indexitem.cpp
Update License
2015-01-16 12:37:56 +01:00
indexitem.h
Update License
2015-01-16 12:37:56 +01:00
insertionpointlocator.cpp
CppEditor: Fix added newlines for GenerateGetterSetter quick fix
2015-06-09 10:11:56 +00:00
insertionpointlocator.h
Update License
2015-01-16 12:37:56 +01:00
modelmanagertesthelper.cpp
CppTools: Tests: Allow to check only project relevant state
2015-06-03 09:15:39 +00:00
modelmanagertesthelper.h
CppTools: Tests: Allow to check only project relevant state
2015-06-03 09:15:39 +00:00
searchsymbols.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
searchsymbols.h
Update License
2015-01-16 12:37:56 +01:00
semantichighlighter.cpp
CppEditor: Fix semantic highlighting when zooming
2015-06-23 08:15:46 +00:00
semantichighlighter.h
CppTools: Remove some pointless declarations
2015-07-08 13:25:13 +00:00
senddocumenttracker.cpp
Clang: Add revision and completion management
2015-09-28 15:46:15 +00:00
senddocumenttracker.h
Clang: Add revision and completion management
2015-09-28 15:46:15 +00:00
stringtable.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
stringtable.h
Update License
2015-01-16 12:37:56 +01:00
symbolfinder.cpp
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
symbolfinder.h
CppTools: Make FollowSymbol respect projects
2015-10-12 15:08:24 +00:00
symbolsearcher_test.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
symbolsfindfilter.cpp
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
symbolsfindfilter.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00
typehierarchybuilder_test.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
typehierarchybuilder.cpp
Merge commit '3c85058694ee2e41658d17f524fb48f0b187d2fe'
2015-02-12 17:29:21 +01:00
typehierarchybuilder.h
Clean exported headers of the CppTools plugin.
2015-03-05 08:16:48 +00:00