Files
qt-creator/src/plugins/webassembly/webassemblyemsdk.cpp
hjk 3a8314f793 WebAssembly: Support emsdk path with spaces on Linux/macOS
The command passed to bash as argument needs to be quoted.

Task-number: QTCREATORBUG-29981
Change-Id: I0e91ab4c088f8cd4e5a2df82604ea86cf73369fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-12-12 15:19:54 +00:00

144 lines
4.9 KiB
C++

// Copyright (C) 2020 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include "webassemblyemsdk.h"
#include <coreplugin/icore.h>
#include <coreplugin/settingsdatabase.h>
#include <utils/environment.h>
#include <utils/process.h>
#include <utils/hostosinfo.h>
#include <QCache>
using namespace Utils;
namespace WebAssembly::Internal::WebAssemblyEmSdk {
const char emSdkEnvTSFileKey[] = "WebAssembly/emSdkEnvTimeStampFile";
const char emSdkEnvTSKey[] = "WebAssembly/emSdkEnvTimeStamp";
const char emSdkEnvOutputKey[] = "WebAssembly/emSdkEnvOutput1";
const char emSdkVersionTSFileKey[] = "WebAssembly/emSdkVersionTimeStampFile";
const char emSdkVersionTSKey[] = "WebAssembly/emSdkVersionTimeStamp";
const char emSdkVersionKey[] = "WebAssembly/emSdkVersion1";
const FilePath timeStampFile(const FilePath &sdkRoot)
{
return sdkRoot / ".emscripten";
}
static QString emSdkEnvOutput(const FilePath &sdkRoot)
{
const FilePath tsFile = timeStampFile(sdkRoot); // ts == Timestamp
if (!tsFile.exists())
return {};
const QDateTime ts = tsFile.lastModified();
namespace DB = Core::SettingsDatabase;
if (DB::value(emSdkEnvTSKey).toDateTime() == ts
&& FilePath::fromVariant(DB::value(emSdkEnvTSFileKey)) == tsFile
&& DB::contains(emSdkEnvOutputKey)) {
return DB::value(emSdkEnvOutputKey).toString();
}
const bool isWindows = sdkRoot.osType() == OsTypeWindows;
const FilePath scriptFile = sdkRoot.pathAppended(QLatin1String("emsdk_env") +
(isWindows ? ".bat" : ".sh"));
Process emSdkEnv;
if (isWindows) {
emSdkEnv.setCommand(CommandLine(scriptFile));
} else {
// File needs to be source'd, not executed.
CommandLine cmd{sdkRoot.withNewPath("bash"), {"-c"}};
cmd.addCommandLineAsSingleArg({".", {scriptFile.path()}});
emSdkEnv.setCommand(cmd);
}
emSdkEnv.runBlocking();
const QString result = emSdkEnv.allOutput();
DB::setValue(emSdkEnvTSFileKey, tsFile.toVariant());
DB::setValue(emSdkEnvTSKey, ts);
DB::setValue(emSdkEnvOutputKey, result);
return result;
}
void parseEmSdkEnvOutputAndAddToEnv(const QString &output, Environment &env)
{
const QStringList lines = output.split('\n');
for (const QString &line : lines) {
const QStringList prependParts = line.trimmed().split(" += ");
if (prependParts.count() == 2)
env.prependOrSetPath(FilePath::fromUserInput(prependParts.last()));
const QStringList setParts = line.trimmed().split(" = ");
if (setParts.count() == 2) {
if (setParts.first() != "PATH") // Path was already extended above
env.set(setParts.first(), setParts.last());
continue;
}
}
// QTCREATORBUG-26199: Wrapper scripts (e.g. emcc.bat) of older emsdks might not find python
const QString emsdkPython = env.value("EMSDK_PYTHON");
if (!emsdkPython.isEmpty())
env.appendOrSetPath(FilePath::fromUserInput(emsdkPython).parentDir());
}
bool isValid(const FilePath &sdkRoot)
{
return !version(sdkRoot).isNull();
}
void addToEnvironment(const FilePath &sdkRoot, Environment &env)
{
if (sdkRoot.exists())
parseEmSdkEnvOutputAndAddToEnv(emSdkEnvOutput(sdkRoot), env);
}
QVersionNumber version(const FilePath &sdkRoot)
{
const FilePath tsFile = timeStampFile(sdkRoot); // ts == Timestamp
if (!tsFile.exists())
return {};
const QDateTime ts = tsFile.lastModified();
namespace DB = Core::SettingsDatabase;
if (DB::value(emSdkVersionTSKey).toDateTime() == ts
&& FilePath::fromVariant(DB::value(emSdkVersionTSFileKey)) == tsFile
&& DB::contains(emSdkVersionKey)) {
return QVersionNumber::fromString(DB::value(emSdkVersionKey).toString());
}
Environment env = sdkRoot.deviceEnvironment();
addToEnvironment(sdkRoot, env);
QLatin1String scriptFile{sdkRoot.osType() == OsType::OsTypeWindows ? "emcc.bat" : "emcc"};
FilePath script = sdkRoot.withNewPath(scriptFile).searchInDirectories(env.path());
const CommandLine command(script, {"-dumpversion"});
Process emcc;
emcc.setCommand(command);
emcc.setEnvironment(env);
emcc.runBlocking();
const QString versionStr = emcc.cleanedStdOut();
const QVersionNumber result = QVersionNumber::fromString(versionStr);
DB::setValue(emSdkVersionTSFileKey, tsFile.toVariant());
DB::setValue(emSdkVersionTSKey, ts);
DB::setValue(emSdkVersionKey, result.toString());
return result;
}
void clearCaches()
{
namespace DB = Core::SettingsDatabase;
DB::remove(emSdkEnvTSFileKey);
DB::remove(emSdkEnvTSKey);
DB::remove(emSdkEnvOutputKey);
DB::remove(emSdkVersionTSFileKey);
DB::remove(emSdkVersionTSKey);
DB::remove(emSdkVersionKey);
}
} // namespace WebAssembly::Internal::WebAssemblyEmSdk