forked from qt-creator/qt-creator
169556db2f
Fix use-after-free for the following case:
1. Open an editor
2. Trigger a long processing completion
(e.g. simulate with QThread::msleep in
CppCompletionAssistInterface::getCppSpecifics)
3. ...and immediately close the editor (e.g. with Ctrl+W)
4. Wait until it crashes.
The completion thread relied on the BuiltinEditorDocumentParser object,
which is deleted once the editor is closed. Fixed by sharing the
ownership of that object between the *EditorDocumentProcessor and the
completion assist interface.
This case came up when doing tests for the bug report below.
Task-number: QTCREATORBUG-14991
Change-Id: I0b009229e68fc6b7838740858cdc41a32403fe6f
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
83 lines
3.2 KiB
C++
83 lines
3.2 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2015 The Qt Company Ltd.
|
|
** Contact: http://www.qt.io/licensing
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms and
|
|
** conditions see http://www.qt.io/terms-conditions. For further information
|
|
** use the contact form at http://www.qt.io/contact-us.
|
|
**
|
|
** GNU Lesser General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU Lesser
|
|
** General Public License version 2.1 or version 3 as published by the Free
|
|
** Software Foundation and appearing in the file LICENSE.LGPLv21 and
|
|
** LICENSE.LGPLv3 included in the packaging of this file. Please review the
|
|
** following information to ensure the GNU Lesser General Public License
|
|
** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
|
|
** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
|
|
**
|
|
** In addition, as a special exception, The Qt Company gives you certain additional
|
|
** rights. These rights are described in The Qt Company LGPL Exception
|
|
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#ifndef BUILTINEDITORDOCUMENTPROCESSOR_H
|
|
#define BUILTINEDITORDOCUMENTPROCESSOR_H
|
|
|
|
#include "baseeditordocumentprocessor.h"
|
|
#include "builtineditordocumentparser.h"
|
|
#include "cppsemanticinfoupdater.h"
|
|
#include "cpptools_global.h"
|
|
#include "semantichighlighter.h"
|
|
|
|
namespace CppTools {
|
|
|
|
class CPPTOOLS_EXPORT BuiltinEditorDocumentProcessor : public BaseEditorDocumentProcessor
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
BuiltinEditorDocumentProcessor(TextEditor::TextDocument *document,
|
|
bool enableSemanticHighlighter = true);
|
|
~BuiltinEditorDocumentProcessor();
|
|
|
|
// BaseEditorDocumentProcessor interface
|
|
void run() override;
|
|
void recalculateSemanticInfoDetached(bool force) override;
|
|
void semanticRehighlight() override;
|
|
CppTools::SemanticInfo recalculateSemanticInfo() override;
|
|
BaseEditorDocumentParser::Ptr parser() override;
|
|
CPlusPlus::Snapshot snapshot() override;
|
|
bool isParserRunning() const override;
|
|
|
|
private:
|
|
void onParserFinished(CPlusPlus::Document::Ptr document, CPlusPlus::Snapshot snapshot);
|
|
void onSemanticInfoUpdated(const CppTools::SemanticInfo semanticInfo);
|
|
void onCodeWarningsUpdated(CPlusPlus::Document::Ptr document,
|
|
const QList<CPlusPlus::Document::DiagnosticMessage> &codeWarnings);
|
|
|
|
SemanticInfo::Source createSemanticInfoSource(bool force) const;
|
|
|
|
private:
|
|
BuiltinEditorDocumentParser::Ptr m_parser;
|
|
QFuture<void> m_parserFuture;
|
|
|
|
CPlusPlus::Snapshot m_documentSnapshot;
|
|
QList<QTextEdit::ExtraSelection> m_codeWarnings;
|
|
bool m_codeWarningsUpdated;
|
|
|
|
SemanticInfoUpdater m_semanticInfoUpdater;
|
|
QScopedPointer<SemanticHighlighter> m_semanticHighlighter;
|
|
};
|
|
|
|
} // namespace CppTools
|
|
|
|
#endif // BUILTINEDITORDOCUMENTPROCESSOR_H
|