Files
qt-creator/src/plugins/qmldesigner/components/texteditor/texteditorwidget.h
Marco Bubke 86e2426ac6 QmlDesigner: Improve ownership of text editor
Handling raw pointer can easily lead to mistakes. So it's better to
remove unique pointer. In this case a deleteLater pointer is added.

The pointer has not be tested for null  because of:

23.11.1.2.2 unique_ptr destructor [unique.ptr.single.dtor]

2 Effects: If get() == nullptr there are no effects. Otherwise
get_deleter()(get()).

Change-Id: I97eeb86b7316fc93fbed89707644ab7dde7f89f6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-04-17 14:59:38 +00:00

66 lines
1.7 KiB
C++

// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#pragma once
#include <texteditor/texteditor.h>
#include <utils/uniqueobjectptr.h>
#include <QTimer>
#include <QVBoxLayout>
#include <QWidget>
#include <memory>
namespace Core {
class FindToolBarPlaceHolder;
}
namespace QmlDesigner {
class TextEditorView;
class TextEditorStatusBar;
class TextEditorWidget : public QWidget {
Q_OBJECT
public:
TextEditorWidget(TextEditorView *textEditorView);
void setTextEditor(Utils::UniqueObjectLatePtr<TextEditor::BaseTextEditor> textEditor);
TextEditor::BaseTextEditor *textEditor() const
{
return m_textEditor.get();
}
void contextHelp(const Core::IContext::HelpCallback &callback) const;
void jumpTextCursorToSelectedModelNode();
void gotoCursorPosition(int line, int column);
void setStatusText(const QString &text);
void clearStatusBar();
int currentLine() const;
void setBlockCursorSelectionSynchronisation(bool b);
protected:
bool eventFilter(QObject *object, QEvent *event) override;
void dragEnterEvent(QDragEnterEvent *dragEnterEvent) override;
void dropEvent(QDropEvent *dropEvent) override;
private:
void updateSelectionByCursorPosition();
Utils::UniqueObjectLatePtr<TextEditor::BaseTextEditor> m_textEditor;
QPointer<TextEditorView> m_textEditorView;
QTimer m_updateSelectionTimer;
TextEditorStatusBar *m_statusBar = nullptr;
Core::FindToolBarPlaceHolder *m_findToolBar = nullptr;
QVBoxLayout *m_layout = nullptr;
bool m_blockCursorSelectionSynchronisation = false;
bool m_blockRoundTrip = false;
};
} // namespace QmlDesigner