forked from qt-creator/qt-creator
9fc2fda07e
Before this change, we've invoked a custom clang binary that had clazy statically compiled into it. The invocation also ensured that the diagnostics were serialized to a file, so that libclang could be used afterwards to read them. As the clazy-standalone executable supports exporting diagnostics to a YAML file now (just as clang-tidy) and Qt Creator ships it already, rely on that executable alone instead of the clang/libclang combo. While we do not depend on any clang header or library at build-time now, the CompilerOptionsBuilder constructor still needs the CLANG_VERSION and CLANG_RESOURCE_DIR pieces from llvm-config. This dependency should be removed as next. Change-Id: I4fa5753ab09008fd24bc5247b28c4836b5e8ca45 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io>
130 lines
4.4 KiB
C++
130 lines
4.4 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include "clangtidyclazyrunner.h"
|
|
|
|
#include "clangtoolssettings.h"
|
|
#include "clangtoolsutils.h"
|
|
|
|
#include <coreplugin/icore.h>
|
|
|
|
#include <cpptools/clangdiagnosticconfigsmodel.h>
|
|
#include <cpptools/compileroptionsbuilder.h>
|
|
#include <cpptools/cpptoolsreuse.h>
|
|
|
|
#include <utils/synchronousprocess.h>
|
|
#include <utils/qtcassert.h>
|
|
|
|
#include <QDebug>
|
|
#include <QDir>
|
|
#include <QLoggingCategory>
|
|
|
|
static Q_LOGGING_CATEGORY(LOG, "qtc.clangtools.runner", QtWarningMsg)
|
|
|
|
using namespace CppTools;
|
|
|
|
namespace ClangTools {
|
|
namespace Internal {
|
|
|
|
static bool isClMode(const QStringList &options)
|
|
{
|
|
return options.contains("--driver-mode=cl");
|
|
}
|
|
|
|
static QStringList tidyChecksArguments(const ClangDiagnosticConfig diagnosticConfig)
|
|
{
|
|
const ClangDiagnosticConfig::TidyMode tidyMode = diagnosticConfig.clangTidyMode();
|
|
// The argument "-config={}" stops stating/evaluating the .clang-tidy file.
|
|
if (tidyMode == ClangDiagnosticConfig::TidyMode::UseDefaultChecks)
|
|
return {"-config={}"};
|
|
if (tidyMode == ClangDiagnosticConfig::TidyMode::UseCustomChecks)
|
|
return {"-config={}", "-checks=" + diagnosticConfig.clangTidyChecks()};
|
|
return {};
|
|
}
|
|
|
|
static QStringList clazyChecksArguments(const ClangDiagnosticConfig diagnosticConfig)
|
|
{
|
|
const QString clazyChecks = diagnosticConfig.clazyChecks();
|
|
if (!clazyChecks.isEmpty())
|
|
return {"-checks=" + diagnosticConfig.clazyChecks()};
|
|
return {};
|
|
}
|
|
|
|
static QStringList mainToolArguments(const QString &mainFilePath, const QString &outputFilePath)
|
|
{
|
|
return {
|
|
"-export-fixes=" + outputFilePath,
|
|
QDir::toNativeSeparators(mainFilePath),
|
|
};
|
|
}
|
|
|
|
static QStringList clangArguments(const ClangDiagnosticConfig &diagnosticConfig,
|
|
const QStringList &baseOptions)
|
|
{
|
|
QStringList arguments;
|
|
arguments << ClangDiagnosticConfigsModel::globalDiagnosticOptions()
|
|
<< (isClMode(baseOptions) ? CppTools::clangArgsForCl(diagnosticConfig.clangOptions())
|
|
: diagnosticConfig.clangOptions())
|
|
<< baseOptions;
|
|
|
|
if (LOG().isDebugEnabled())
|
|
arguments << QLatin1String("-v");
|
|
|
|
return arguments;
|
|
}
|
|
|
|
ClangTidyRunner::ClangTidyRunner(const ClangDiagnosticConfig &config, QObject *parent)
|
|
: ClangToolRunner(parent)
|
|
{
|
|
setName(tr("Clang-Tidy"));
|
|
setOutputFileFormat(OutputFileFormat::Yaml);
|
|
setExecutable(clangTidyExecutable());
|
|
setArgsCreator([this, config](const QStringList &baseOptions) {
|
|
return QStringList()
|
|
<< tidyChecksArguments(config)
|
|
<< mainToolArguments(fileToAnalyze(), outputFilePath())
|
|
<< "--"
|
|
<< clangArguments(config, baseOptions);
|
|
});
|
|
}
|
|
|
|
ClazyStandaloneRunner::ClazyStandaloneRunner(const ClangDiagnosticConfig &config, QObject *parent)
|
|
: ClangToolRunner(parent)
|
|
{
|
|
setName(tr("Clazy"));
|
|
setOutputFileFormat(OutputFileFormat::Yaml);
|
|
setExecutable(clazyStandaloneExecutable());
|
|
setArgsCreator([this, config](const QStringList &baseOptions) {
|
|
return QStringList()
|
|
<< clazyChecksArguments(config)
|
|
<< mainToolArguments(fileToAnalyze(), outputFilePath())
|
|
<< "--"
|
|
<< clangArguments(config, baseOptions);
|
|
});
|
|
}
|
|
|
|
} // namespace Internal
|
|
} // namespace ClangTools
|