Files
qt-creator/src/plugins/cpptools/cppfileiterationorder.cpp
Jarek Kobus 448cdb7bb5 Fix a crash when editing cpp file
std::mismach() overload taking 3 arg assumes, that
second string is at least as long as the first one.
We don't guarantee this, as somethimes filePath2 is
empty string. Use 4 arg overload instead, which
ensure we don't exceed the valid range.

Fixes: QTCREATORBUG-24970
Change-Id: I8b7b11d124f69c7c9cb3246ee969f134fa026e08
Reviewed-by: hjk <hjk@qt.io>
2020-11-30 12:43:54 +00:00

154 lines
5.1 KiB
C++

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "cppfileiterationorder.h"
#include <utils/qtcassert.h>
namespace CppTools {
FileIterationOrder::Entry::Entry(const QString &filePath,
const QString &projectPartId,
int commonPrefixLength,
int commonProjectPartPrefixLength)
: filePath(filePath)
, projectPartId(projectPartId)
, commonFilePathPrefixLength(commonPrefixLength)
, commonProjectPartPrefixLength(commonProjectPartPrefixLength)
{}
namespace {
bool cmpPrefixLengthAndText(int prefixLength1, int prefixLength2)
{
return prefixLength1 > prefixLength2;
}
bool cmpLessFilePath(const FileIterationOrder::Entry &first,
const FileIterationOrder::Entry &second)
{
return cmpPrefixLengthAndText(first.commonFilePathPrefixLength,
second.commonFilePathPrefixLength);
}
bool cmpLessProjectPartId(const FileIterationOrder::Entry &first,
const FileIterationOrder::Entry &second)
{
return cmpPrefixLengthAndText(first.commonProjectPartPrefixLength,
second.commonProjectPartPrefixLength);
}
bool hasProjectPart(const FileIterationOrder::Entry &entry)
{
return !entry.projectPartId.isEmpty();
}
} // anonymous namespace
bool operator<(const FileIterationOrder::Entry &first, const FileIterationOrder::Entry &second)
{
if (hasProjectPart(first)) {
if (hasProjectPart(second)) {
if (first.projectPartId == second.projectPartId)
return cmpLessFilePath(first, second);
else
return cmpLessProjectPartId(first, second);
} else {
return true;
}
} else {
if (hasProjectPart(second))
return false;
else
return cmpLessFilePath(first, second);
}
}
FileIterationOrder::FileIterationOrder() = default;
FileIterationOrder::FileIterationOrder(const QString &referenceFilePath,
const QString &referenceProjectPartId)
{
setReference(referenceFilePath, referenceProjectPartId);
}
void FileIterationOrder::setReference(const QString &filePath,
const QString &projectPartId)
{
m_referenceFilePath = filePath;
m_referenceProjectPartId = projectPartId;
}
bool FileIterationOrder::isValid() const
{
return !m_referenceFilePath.isEmpty();
}
static int commonPrefixLength(const QString &filePath1, const QString &filePath2)
{
const auto mismatches = std::mismatch(filePath1.begin(), filePath1.end(),
filePath2.begin(), filePath2.end());
return mismatches.first - filePath1.begin();
}
FileIterationOrder::Entry FileIterationOrder::createEntryFromFilePath(
const QString &filePath,
const QString &projectPartId) const
{
const int filePrefixLength = commonPrefixLength(m_referenceFilePath, filePath);
const int projectPartPrefixLength = commonPrefixLength(m_referenceProjectPartId, projectPartId);
return Entry(filePath, projectPartId, filePrefixLength, projectPartPrefixLength);
}
void FileIterationOrder::insert(const QString &filePath, const QString &projectPartId)
{
const Entry entry = createEntryFromFilePath(filePath, projectPartId);
m_set.insert(entry);
}
void FileIterationOrder::remove(const QString &filePath, const QString &projectPartId)
{
const auto needleElement = createEntryFromFilePath(filePath, projectPartId);
const auto range = m_set.equal_range(needleElement);
const auto toRemove = std::find_if(range.first, range.second, [filePath] (const Entry &entry) {
return entry.filePath == filePath;
});
QTC_ASSERT(toRemove != range.second, return);
m_set.erase(toRemove);
}
QStringList FileIterationOrder::toStringList() const
{
QStringList result;
for (const auto &entry : m_set)
result.append(entry.filePath);
return result;
}
} // namespace CppTools