Files
qt-creator/src/tools/clangbackend/ipcsource/sourcelocation.cpp
Nikolai Kosjar 36e7f4541f Clang: Pass on file paths with native separators
libclang 3.8 seems to be sensitive to file paths separators [1]. On Windows,
this led to not updated document annotations and/or crashes after reparsing.

When passing file paths to libclang, convert to native separators.
When getting file paths from libclang, convert back.

This handles:
 * main file path
 * file paths of the unsaved files
 * -I<DIR> arguments, the resource path (for builtins) and the paths to the
   wrapped qt headers
 * included header files from libclang
 * source locations from libclang

Also, minimize the conversion in SourceLocation to a minimum by making
filePath() lazy.

[1] https://llvm.org/bugs/show_bug.cgi?id=28381

Change-Id: If5866f34a6fdc6b34b16c022d3988e8e6eae2a0a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2016-07-04 13:08:03 +00:00

130 lines
3.7 KiB
C++

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "sourcelocation.h"
#include "clangfilepath.h"
#include "clangstring.h"
#include "clangtranslationunit.h"
#include <utf8string.h>
#include <ostream>
#include <sourcelocationcontainer.h>
namespace ClangBackEnd {
SourceLocation::SourceLocation()
: cxSourceLocation(clang_getNullLocation())
{
}
const Utf8String &SourceLocation::filePath() const
{
if (isFilePathNormalized_)
return filePath_;
isFilePathNormalized_ = true;
filePath_ = FilePath::fromNativeSeparators(filePath_);
return filePath_;
}
uint SourceLocation::line() const
{
return line_;
}
uint SourceLocation::column() const
{
return column_;
}
uint SourceLocation::offset() const
{
return offset_;
}
SourceLocationContainer SourceLocation::toSourceLocationContainer() const
{
return SourceLocationContainer(filePath(), line_, column_);
}
SourceLocation::SourceLocation(CXSourceLocation cxSourceLocation)
: cxSourceLocation(cxSourceLocation)
{
CXFile cxFile;
clang_getFileLocation(cxSourceLocation,
&cxFile,
&line_,
&column_,
&offset_);
filePath_ = ClangString(clang_getFileName(cxFile));
isFilePathNormalized_ = false;
}
SourceLocation::SourceLocation(CXTranslationUnit cxTranslationUnit,
const Utf8String &filePath,
uint line,
uint column)
: cxSourceLocation(clang_getLocation(cxTranslationUnit,
clang_getFile(cxTranslationUnit,
filePath.constData()),
line,
column)),
filePath_(filePath),
line_(line),
column_(column),
isFilePathNormalized_(true)
{
clang_getFileLocation(cxSourceLocation, 0, 0, 0, &offset_);
}
bool operator==(const SourceLocation &first, const SourceLocation &second)
{
return clang_equalLocations(first.cxSourceLocation, second.cxSourceLocation);
}
SourceLocation::operator CXSourceLocation() const
{
return cxSourceLocation;
}
void PrintTo(const SourceLocation &sourceLocation, std::ostream *os)
{
auto filePath = sourceLocation.filePath();
if (filePath.hasContent())
*os << filePath.constData() << ", ";
*os << "line: " << sourceLocation.line()
<< ", column: "<< sourceLocation.column()
<< ", offset: "<< sourceLocation.offset();
}
} // namespace ClangBackEnd