forked from qt-creator/qt-creator
c6f12991b0
...if new items are added to the model or if filter is used. When items were added, we have called ClangToolsDiagnosticModel::diagnostics() two times: * from DiagnosticFilterModel::filterAcceptsRow() * from ClangTidyClazyTool::handleStateUpdate() However, this does not scale since diagnostics() creates a temporary. Fix this by accessing the diagnostics or the count directly from the tree. Change-Id: I4c6a32e0076c1b4228ed1b1ff9222c9918f92c5c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
128 lines
3.8 KiB
C++
128 lines
3.8 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#pragma once
|
|
|
|
#include "clangfixitsrefactoringchanges.h"
|
|
#include "clangtoolsdiagnostic.h"
|
|
#include "clangtoolsprojectsettings.h"
|
|
|
|
#include <debugger/analyzer/detailederrorview.h>
|
|
#include <utils/fileutils.h>
|
|
#include <utils/treemodel.h>
|
|
|
|
#include <QPointer>
|
|
#include <QSortFilterProxyModel>
|
|
|
|
#include <functional>
|
|
|
|
namespace ProjectExplorer { class Project; }
|
|
|
|
namespace ClangTools {
|
|
namespace Internal {
|
|
|
|
enum class FixitStatus {
|
|
NotAvailable,
|
|
NotScheduled,
|
|
Scheduled,
|
|
Applied,
|
|
FailedToApply,
|
|
Invalidated,
|
|
};
|
|
|
|
class DiagnosticItem : public Utils::TreeItem
|
|
{
|
|
public:
|
|
using OnFixitStatusChanged = std::function<void(FixitStatus newStatus)>;
|
|
DiagnosticItem(const Diagnostic &diag, const OnFixitStatusChanged &onFixitStatusChanged);
|
|
~DiagnosticItem() override;
|
|
|
|
const Diagnostic &diagnostic() const { return m_diagnostic; }
|
|
|
|
FixitStatus fixItStatus() const { return m_fixitStatus; }
|
|
void setFixItStatus(const FixitStatus &status);
|
|
|
|
ReplacementOperations &fixitOperations() { return m_fixitOperations; }
|
|
void setFixitOperations(const ReplacementOperations &replacements);
|
|
|
|
private:
|
|
Qt::ItemFlags flags(int column) const override;
|
|
QVariant data(int column, int role) const override;
|
|
bool setData(int column, const QVariant &data, int role) override;
|
|
|
|
private:
|
|
const Diagnostic m_diagnostic;
|
|
OnFixitStatusChanged m_onFixitStatusChanged;
|
|
|
|
ReplacementOperations m_fixitOperations;
|
|
FixitStatus m_fixitStatus = FixitStatus::NotAvailable;
|
|
};
|
|
|
|
class ClangToolsDiagnosticModel : public Utils::TreeModel<>
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
ClangToolsDiagnosticModel(QObject *parent = nullptr);
|
|
|
|
virtual void addDiagnostics(const QList<Diagnostic> &diagnostics);
|
|
virtual QList<Diagnostic> diagnostics() const;
|
|
|
|
int diagnosticsCount() const;
|
|
|
|
enum ItemRole {
|
|
DiagnosticRole = Debugger::DetailedErrorView::FullTextRole + 1
|
|
};
|
|
|
|
signals:
|
|
void fixItsToApplyCountChanged(int count);
|
|
|
|
private:
|
|
int m_fixItsToApplyCount = 0;
|
|
};
|
|
|
|
class DiagnosticFilterModel : public QSortFilterProxyModel
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
DiagnosticFilterModel(QObject *parent = nullptr);
|
|
|
|
void setProject(ProjectExplorer::Project *project);
|
|
void addSuppressedDiagnostic(const SuppressedDiagnostic &diag);
|
|
ProjectExplorer::Project *project() const { return m_project; }
|
|
|
|
private:
|
|
bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const;
|
|
void handleSuppressedDiagnosticsChanged();
|
|
|
|
QPointer<ProjectExplorer::Project> m_project;
|
|
Utils::FileName m_lastProjectDirectory;
|
|
SuppressedDiagnosticsList m_suppressedDiagnostics;
|
|
};
|
|
|
|
} // namespace Internal
|
|
} // namespace ClangTools
|