Files
qt-creator/src/plugins/cppeditor/fileandtokenactions_test.cpp
hjk cc88302309 De-emphasize PluginManager::getObjects<Type>()
... by additionally keeping local (currently non-owning) pools per
"interesting" type.

Current situation:
  - The global object pool does not scale well for looking up
    objects, as iteration plus qobject_cast typically iterates
    over all pooled objects.
  - User code that can use typed results from the object
    pool need to have access to the full type definition anyway,
    i.e.  depend on the plugin of the target class anyway.

The patch here solves the scaling problem is to have local
type-specific pools to which objects register in their
constructors and deregister in their destructors.

This patch here does *not* change the ownership model of the
pooled objects, however, it opens the possibility to change
the ownership model per type (e.g. by not putting things into
the global pool at all anymore and make the local pool 'owning')
and the intent is to handle that in later patchs.

Even without the follow-up patches this here is a performance
improvement for the cases that access the local pools instead
the global one, i.e. "practically all".

Change-Id: Ib11a42df2c4ecf5e1155534730083a520dd1995b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-12-15 07:08:05 +00:00

554 lines
19 KiB
C++

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "cppeditor.h"
#include "cppeditorwidget.h"
#include "cppeditorplugin.h"
#include "cppeditortestcase.h"
#include "cppquickfix.h"
#include "cppquickfixassistant.h"
#include "cppquickfixes.h"
#include "cppinsertvirtualmethods.h"
#include <coreplugin/editormanager/editormanager.h>
#include <cpptools/cppmodelmanager.h>
#include <cpptools/cpptoolsreuse.h>
#include <cpptools/cppworkingcopy.h>
#include <cpptools/projectinfo.h>
#include <projectexplorer/project.h>
#include <projectexplorer/projectexplorer.h>
#include <texteditor/textdocument.h>
#include <cplusplus/CppDocument.h>
#include <cplusplus/TranslationUnit.h>
#include <utils/algorithm.h>
#include <QApplication>
#include <QDebug>
#include <QTextDocument>
#include <QtTest>
/*!
Tests for executing "test actions" for
(1) each file of each loaded project (file actions) or
e.g. "Switch Header/Source"
(2) each word/token of each file of each loaded project (token actions)
e.g. "Trigger and perform all Quick Fixes"
Purpose:
Detect corner cases for which Qt Creator crashes or outputs QTC_ASSERTS.
Correct behavior is *not* tested.
Prerequisites:
These tests depend on the projects that are loaded on startup of Qt Creator.
Make sure to load the test projects via command line or the session manager.
The test projects must be properly configured for a Kit.
*/
using namespace Core;
using namespace CPlusPlus;
using namespace CppTools;
using namespace TextEditor;
namespace CppEditor {
namespace Internal {
namespace {
class TestActionsTestCase : public Tests::TestCase
{
public:
class AbstractAction
{
public:
/// Every Action is expected to undo its changes.
virtual void run(CppEditorWidget *editorWidget) = 0;
virtual ~AbstractAction() {}
};
typedef QSharedPointer<AbstractAction> ActionPointer;
typedef QList<ActionPointer> Actions;
public:
/// Run the given fileActions for each file and the given tokenActions for each token.
/// The cursor is positioned on the very first character of each token.
TestActionsTestCase(const Actions &tokenActions = Actions(),
const Actions &fileActions = Actions());
/// Simulate pressing ESC, which will close popups, search results pane, etc...
/// This works only if the Qt Creator window is active.
static void escape();
/// Undoing changes
static void undoChangesInDocument(TextDocument *editorDocument);
static void undoChangesInAllEditorWidgets();
/// Execute actions for the current cursor position of editorWidget.
static void executeActionsOnEditorWidget(CppEditorWidget *editorWidget, Actions actions);
private:
/// Move word camel case wise from current cursor position until given token (not included)
/// and execute the tokenActions for each new position.
static void moveWordCamelCaseToToken(TranslationUnit *translationUnit, const Token &token,
CppEditor *editor, const Actions &tokenActions);
static void undoAllChangesAndCloseAllEditors();
};
typedef TestActionsTestCase::Actions Actions;
typedef TestActionsTestCase::ActionPointer ActionPointer;
Actions singleAction(const ActionPointer &action)
{
return Actions() << action;
}
static bool waitUntilAProjectIsLoaded(int timeOutInMs = 30000)
{
QElapsedTimer timer;
timer.start();
while (timer.elapsed() < timeOutInMs) {
if (!CppModelManager::instance()->projectInfos().isEmpty())
return true;
QCoreApplication::processEvents();
QThread::msleep(20);
}
return false;
}
TestActionsTestCase::TestActionsTestCase(const Actions &tokenActions, const Actions &fileActions)
: Tests::TestCase(/*runGarbageCollector=*/false)
{
QVERIFY(succeededSoFar());
if (qgetenv("QTC_TEST_WAIT_FOR_LOADED_PROJECT") != "1")
QSKIP("Environment variable QTC_TEST_WAIT_FOR_LOADED_PROJECT=1 not set.");
QVERIFY(waitUntilAProjectIsLoaded());
// Collect files to process
QStringList filesToOpen;
QList<QPointer<ProjectExplorer::Project> > projects;
const QList<ProjectInfo> projectInfos = m_modelManager->projectInfos();
foreach (const ProjectInfo &info, projectInfos) {
QPointer<ProjectExplorer::Project> project = info.project();
if (!projects.contains(project))
projects << project;
qDebug() << "Project" << info.project()->displayName() << "- files to process:"
<< info.sourceFiles().size();
foreach (const QString &sourceFile, info.sourceFiles())
filesToOpen << sourceFile;
}
Utils::sort(filesToOpen);
// Process all files from the projects
foreach (const QString filePath, filesToOpen) {
// Skip e.g. "<configuration>"
if (!QFileInfo::exists(filePath))
continue;
qDebug() << " --" << filePath;
// Clean up
undoAllChangesAndCloseAllEditors();
// Open editor
QCOMPARE(DocumentModel::openedDocuments().size(), 0);
CppEditor *editor;
CppEditorWidget *editorWidget;
QVERIFY(openCppEditor(filePath, &editor, &editorWidget));
QCOMPARE(DocumentModel::openedDocuments().size(), 1);
QVERIFY(m_modelManager->isCppEditor(editor));
QVERIFY(m_modelManager->workingCopy().contains(filePath));
// Rehighlight
waitForRehighlightedSemanticDocument(editorWidget);
// Run all file actions
executeActionsOnEditorWidget(editorWidget, fileActions);
if (tokenActions.empty())
continue;
const Snapshot snapshot = globalSnapshot();
Document::Ptr document = snapshot.preprocessedDocument(
editorWidget->document()->toPlainText().toUtf8(), filePath);
QVERIFY(document);
document->parse();
TranslationUnit *translationUnit = document->translationUnit();
QVERIFY(translationUnit);
QVERIFY(translationUnit->tokenCount() >= 2); // First invalid token included
// Move word camel case wise from the top until the first user visible token
editor->gotoLine(1);
const Token token = translationUnit->tokenAt(1);
moveWordCamelCaseToToken(translationUnit, token, editor, tokenActions);
// Move token wise through the document
// translationUnit->tokenAt(0) is the invalid token, so start with 1.
for (unsigned i = 1, ei = translationUnit->tokenCount(); i < ei; ++i) {
const Token token = translationUnit->tokenAt(i);
if (token.kind() == T_EOF_SYMBOL)
continue;
if (token.expanded()) {
// Move word camel case wise until first not expanded token
unsigned j = i + 1;
for (; translationUnit->tokenAt(j).expanded() && j < ei; ++j) ;
if (j == ei) {
if (j == i + 1)
break;
else // All tokens are expanded until end
j = j - 1;
}
const Token token = translationUnit->tokenAt(j);
moveWordCamelCaseToToken(translationUnit, token, editor, tokenActions);
i = j - 1; // Continue with next not expanded token
} else {
// Position the cursor on the token
unsigned line, column;
translationUnit->getPosition(token.utf16charsBegin(), &line, &column);
editor->gotoLine(line, column - 1);
QApplication::processEvents();
// Run all token actions
executeActionsOnEditorWidget(editorWidget, tokenActions);
}
} // for tokens
} // for files
// Clean up
undoAllChangesAndCloseAllEditors();
}
void TestActionsTestCase::escape()
{
if (QWidget *w = QApplication::focusWidget())
QTest::keyClick(w, Qt::Key_Escape);
}
void TestActionsTestCase::undoChangesInDocument(TextDocument *editorDocument)
{
QTextDocument * const document = editorDocument->document();
QVERIFY(document);
while (document->isUndoAvailable())
document->undo();
}
void TestActionsTestCase::undoChangesInAllEditorWidgets()
{
foreach (IDocument *document, DocumentModel::openedDocuments()) {
TextDocument *baseTextDocument = qobject_cast<TextDocument *>(document);
undoChangesInDocument(baseTextDocument);
}
}
void TestActionsTestCase::executeActionsOnEditorWidget(CppEditorWidget *editorWidget,
TestActionsTestCase::Actions actions)
{
foreach (const ActionPointer &action, actions)
action->run(editorWidget);
QApplication::processEvents();
}
void TestActionsTestCase::moveWordCamelCaseToToken(TranslationUnit *translationUnit,
const Token &token,
CppEditor *editor,
const Actions &tokenActions)
{
QVERIFY(translationUnit);
QVERIFY(editor);
CppEditorWidget *editorWidget = dynamic_cast<CppEditorWidget *>(editor->editorWidget());
QVERIFY(editorWidget);
unsigned line, column;
translationUnit->getPosition(token.utf16charsBegin(), &line, &column);
while (editor->currentLine() < (int) line
|| (editor->currentLine() == (int) line
&& editor->currentColumn() < (int) column)) {
editorWidget->gotoNextWordCamelCase();
QApplication::processEvents();
// Run all token actions
executeActionsOnEditorWidget(editorWidget, tokenActions);
}
}
void TestActionsTestCase::undoAllChangesAndCloseAllEditors()
{
undoChangesInAllEditorWidgets();
EditorManager::closeAllEditors(/*askAboutModifiedEditors =*/ false);
QApplication::processEvents();
QCOMPARE(DocumentModel::openedDocuments().size(), 0);
}
class NoOpTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Do nothing on each token
void run(CppEditorWidget *) {}
};
class FollowSymbolUnderCursorTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Follow symbol under cursor
/// Warning: May block if file does not exists (e.g. a not generated ui_* file).
void run(CppEditorWidget *editorWidget);
};
void FollowSymbolUnderCursorTokenAction::run(CppEditorWidget *editorWidget)
{
// Follow link
IEditor *editorBefore = EditorManager::currentEditor();
const int originalLine = editorBefore->currentLine();
const int originalColumn = editorBefore->currentColumn();
editorWidget->openLinkUnderCursor();
TestActionsTestCase::escape();
QApplication::processEvents();
// Go back
IEditor *editorAfter = EditorManager::currentEditor();
if (editorAfter != editorBefore)
EditorManager::goBackInNavigationHistory();
else
editorBefore->gotoLine(originalLine, originalColumn);
QApplication::processEvents();
}
class SwitchDeclarationDefinitionTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Switch Declaration/Definition on each token
void run(CppEditorWidget *);
};
void SwitchDeclarationDefinitionTokenAction::run(CppEditorWidget *)
{
// Switch Declaration/Definition
IEditor *editorBefore = EditorManager::currentEditor();
const int originalLine = editorBefore->currentLine();
const int originalColumn = editorBefore->currentColumn();
CppEditorPlugin::instance()->switchDeclarationDefinition();
QApplication::processEvents();
// Go back
IEditor *editorAfter = EditorManager::currentEditor();
if (editorAfter != editorBefore)
EditorManager::goBackInNavigationHistory();
else
editorBefore->gotoLine(originalLine, originalColumn);
QApplication::processEvents();
}
class FindUsagesTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Find Usages on each token
void run(CppEditorWidget *);
};
void FindUsagesTokenAction::run(CppEditorWidget *)
{
CppEditorPlugin::instance()->findUsages();
QApplication::processEvents();
}
class RenameSymbolUnderCursorTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Rename Symbol Under Cursor on each token (Renaming is not applied)
void run(CppEditorWidget *);
};
void RenameSymbolUnderCursorTokenAction::run(CppEditorWidget *)
{
CppEditorPlugin::instance()->renameSymbolUnderCursor();
QApplication::processEvents();
}
class OpenTypeHierarchyTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Open Type Hierarchy on each token
void run(CppEditorWidget *);
};
void OpenTypeHierarchyTokenAction::run(CppEditorWidget *)
{
CppEditorPlugin::instance()->openTypeHierarchy();
QApplication::processEvents();
}
class InvokeCompletionTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Invoke completion menu on each token.
/// Warning: May create tool tip artefacts if focus is lost.
void run(CppEditorWidget *editorWidget);
};
void InvokeCompletionTokenAction::run(CppEditorWidget *editorWidget)
{
// Invoke assistant and wait until it is finished
QEventLoop loop;
QObject::connect(editorWidget, &TextEditorWidget::assistFinished, &loop, &QEventLoop::quit);
editorWidget->invokeAssist(Completion);
loop.exec();
// Close the completion popup widget
QApplication::processEvents();
editorWidget->abortAssist();
// An alternative way to close the completion pop up is to give the editor widget the focus.
// This works only if the Qt Creator window is always the active window.
// editorWidget->setFocus();
QApplication::processEvents();
TestActionsTestCase::undoChangesInDocument(editorWidget->textDocument());
}
class RunAllQuickFixesTokenAction : public TestActionsTestCase::AbstractAction
{
public:
/// Trigger all Quick Fixes and apply the matching ones
void run(CppEditorWidget *editorWidget);
};
// TODO: Some QuickFixes operate on selections.
void RunAllQuickFixesTokenAction::run(CppEditorWidget *editorWidget)
{
// Calling editorWidget->invokeAssist(QuickFix) would be not enough
// since we also want to execute the ones that match.
CppQuickFixInterface qfi(editorWidget, ExplicitlyInvoked);
// This guard is important since the Quick Fixes expect to get a non-empty path().
if (qfi.path().isEmpty())
return;
for (QuickFixFactory *quickFixFactory : QuickFixFactory::allQuickFixFactories()) {
if (auto cppQuickFixFactory = qobject_cast<CppQuickFixFactory *>(quickFixFactory)) {
QuickFixOperations operations;
// Some Quick Fixes pop up a dialog and are therefore inappropriate for this test.
// Where possible, use a guiless version of the factory.
if (qobject_cast<InsertVirtualMethods *>(cppQuickFixFactory)) {
QScopedPointer<CppQuickFixFactory> factoryProducingGuiLessOperations;
factoryProducingGuiLessOperations.reset(InsertVirtualMethods::createTestFactory());
factoryProducingGuiLessOperations->match(qfi, operations);
} else {
cppQuickFixFactory->match(qfi, operations);
}
foreach (QuickFixOperation::Ptr operation, operations) {
qDebug() << " -- Performing Quick Fix" << operation->description();
operation->perform();
TestActionsTestCase::escape();
TestActionsTestCase::undoChangesInAllEditorWidgets();
QApplication::processEvents();
}
}
}
}
class SwitchHeaderSourceFileAction : public TestActionsTestCase::AbstractAction
{
public:
void run(CppEditorWidget *);
};
void SwitchHeaderSourceFileAction::run(CppEditorWidget *)
{
// Switch Header/Source
IEditor *editorBefore = EditorManager::currentEditor();
CppTools::switchHeaderSource();
QApplication::processEvents();
// Go back
IEditor *editorAfter = EditorManager::currentEditor();
if (editorAfter != editorBefore)
EditorManager::goBackInNavigationHistory();
QApplication::processEvents();
}
} // anonymous namespace
void CppEditorPlugin::test_openEachFile()
{
TestActionsTestCase();
}
void CppEditorPlugin::test_switchHeaderSourceOnEachFile()
{
TestActionsTestCase(Actions(), singleAction(ActionPointer(new SwitchHeaderSourceFileAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFile()
{
TestActionsTestCase(singleAction(ActionPointer(new NoOpTokenAction)));
}
/// May block if file does not exists (e.g. a not generated ui_* file).
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndFollowSymbol()
{
TestActionsTestCase(singleAction(ActionPointer(new FollowSymbolUnderCursorTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndSwitchDeclarationDefinition()
{
TestActionsTestCase(singleAction(ActionPointer(new SwitchDeclarationDefinitionTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndFindUsages()
{
TestActionsTestCase(singleAction(ActionPointer(new FindUsagesTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndRenameUsages()
{
TestActionsTestCase(singleAction(ActionPointer(new RenameSymbolUnderCursorTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndOpenTypeHierarchy()
{
TestActionsTestCase(singleAction(ActionPointer(new OpenTypeHierarchyTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndInvokeCompletion()
{
TestActionsTestCase(singleAction(ActionPointer(new InvokeCompletionTokenAction)));
}
void CppEditorPlugin::test_moveTokenWiseThroughEveryFileAndTriggerQuickFixes()
{
TestActionsTestCase(singleAction(ActionPointer(new RunAllQuickFixesTokenAction)));
}
} // namespace Internal
} // namespace CppEditor