forked from qt-creator/qt-creator
Auxiliary data so far used naming conventions to declare the kind of the data. Now an enumeration is used. The auxiliaryData(...) is returning an optional too so that it is known if a value exists. There is now auxiliaryDataWithDefault(...) which is returning an invalid QVariant instead. The instance cache is now disabled because there is not notification for information changes. So if we get the real data from the node instances there will be no information changes because nothing changed. So the form editor is a strange state of being reset but not all data arrived. Before this patch there were still changes happen because of some side effects that auxiliary properties were sent which were never intended to be sent. If we re-enable the cache we need to send information changes or every view must expect that the information is already there. Task-number: QDS-7338 Change-Id: I0cafd149c53df552c7c8442f1e8ba87f5451dbd1 Reviewed-by: Aleksei German <aleksei.german@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
157 lines
4.7 KiB
C++
157 lines
4.7 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include "propertyvaluecontainer.h"
|
|
|
|
#include <QtDebug>
|
|
|
|
namespace QmlDesigner {
|
|
|
|
PropertyValueContainer::PropertyValueContainer()
|
|
: m_instanceId(-1)
|
|
{
|
|
}
|
|
|
|
PropertyValueContainer::PropertyValueContainer(qint32 instanceId,
|
|
const PropertyName &name,
|
|
const QVariant &value,
|
|
const TypeName &dynamicTypeName,
|
|
AuxiliaryDataType auxiliaryDataType)
|
|
: m_instanceId(instanceId)
|
|
, m_name(name)
|
|
, m_value(value)
|
|
, m_dynamicTypeName(dynamicTypeName)
|
|
, m_auxiliaryDataType{auxiliaryDataType}
|
|
{
|
|
}
|
|
|
|
PropertyValueContainer::PropertyValueContainer(qint32 option)
|
|
: m_instanceId(option),
|
|
m_name("-option-")
|
|
{
|
|
// '-option-' is not a valid property name and indicates that we store the transaction option.
|
|
}
|
|
|
|
qint32 PropertyValueContainer::instanceId() const
|
|
{
|
|
return m_instanceId;
|
|
}
|
|
|
|
PropertyName PropertyValueContainer::name() const
|
|
{
|
|
return m_name;
|
|
}
|
|
|
|
QVariant PropertyValueContainer::value() const
|
|
{
|
|
return m_value;
|
|
}
|
|
|
|
bool PropertyValueContainer::isDynamic() const
|
|
{
|
|
return !m_dynamicTypeName.isEmpty();
|
|
}
|
|
|
|
TypeName PropertyValueContainer::dynamicTypeName() const
|
|
{
|
|
return m_dynamicTypeName;
|
|
}
|
|
|
|
// The reflection flag indicates that a property change notification
|
|
// is reflected. This means that the notification is the reaction to a
|
|
// property change original done by the puppet itself.
|
|
// In the Qt5InformationNodeInstanceServer such notification are
|
|
// therefore ignored.
|
|
|
|
void PropertyValueContainer::setReflectionFlag(bool b)
|
|
{
|
|
m_isReflected = b;
|
|
}
|
|
|
|
bool PropertyValueContainer::isReflected() const
|
|
{
|
|
return m_isReflected;
|
|
}
|
|
|
|
AuxiliaryDataType PropertyValueContainer::auxiliaryDataType() const
|
|
{
|
|
return m_auxiliaryDataType;
|
|
}
|
|
|
|
QDataStream &operator<<(QDataStream &out, const PropertyValueContainer &container)
|
|
{
|
|
out << container.m_instanceId;
|
|
out << container.m_name;
|
|
out << container.m_value;
|
|
out << container.m_dynamicTypeName;
|
|
out << container.m_isReflected;
|
|
out << container.m_auxiliaryDataType;
|
|
|
|
return out;
|
|
}
|
|
|
|
QDataStream &operator>>(QDataStream &in, PropertyValueContainer &container)
|
|
{
|
|
in >> container.m_instanceId;
|
|
in >> container.m_name;
|
|
in >> container.m_value;
|
|
in >> container.m_dynamicTypeName;
|
|
in >> container.m_isReflected;
|
|
in >> container.m_auxiliaryDataType;
|
|
|
|
return in;
|
|
}
|
|
|
|
bool operator ==(const PropertyValueContainer &first, const PropertyValueContainer &second)
|
|
{
|
|
return first.m_instanceId == second.m_instanceId && first.m_name == second.m_name
|
|
&& first.m_value == second.m_value && first.m_dynamicTypeName == second.m_dynamicTypeName
|
|
&& first.m_isReflected == second.m_isReflected
|
|
&& first.m_auxiliaryDataType == second.m_auxiliaryDataType;
|
|
}
|
|
|
|
bool operator <(const PropertyValueContainer &first, const PropertyValueContainer &second)
|
|
{
|
|
return (first.m_instanceId < second.m_instanceId)
|
|
|| (first.m_instanceId == second.m_instanceId && first.m_name < second.m_name);
|
|
}
|
|
|
|
QDebug operator <<(QDebug debug, const PropertyValueContainer &container)
|
|
{
|
|
debug.nospace() << "PropertyValueContainer("
|
|
<< "instanceId: " << container.instanceId() << ", "
|
|
<< "name: " << container.name() << ", "
|
|
<< "value: " << container.value();
|
|
|
|
if (!container.dynamicTypeName().isEmpty())
|
|
debug.nospace() << ", " << "dynamicTypeName: " << container.dynamicTypeName();
|
|
|
|
debug.nospace() << ")";
|
|
|
|
return debug;
|
|
}
|
|
|
|
} // namespace QmlDesigner
|