forked from qt-creator/qt-creator
36e7f4541f
libclang 3.8 seems to be sensitive to file paths separators [1]. On Windows, this led to not updated document annotations and/or crashes after reparsing. When passing file paths to libclang, convert to native separators. When getting file paths from libclang, convert back. This handles: * main file path * file paths of the unsaved files * -I<DIR> arguments, the resource path (for builtins) and the paths to the wrapped qt headers * included header files from libclang * source locations from libclang Also, minimize the conversion in SourceLocation to a minimum by making filePath() lazy. [1] https://llvm.org/bugs/show_bug.cgi?id=28381 Change-Id: If5866f34a6fdc6b34b16c022d3988e8e6eae2a0a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
99 lines
3.9 KiB
C++
99 lines
3.9 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include <clangcodecompleteresults.h>
|
|
#include <clangfilepath.h>
|
|
#include <projectpart.h>
|
|
#include <projects.h>
|
|
#include <clangtranslationunit.h>
|
|
#include <translationunits.h>
|
|
#include <unsavedfiles.h>
|
|
#include <utf8string.h>
|
|
|
|
#include <clang-c/Index.h>
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gmock/gmock-matchers.h>
|
|
#include <gtest/gtest.h>
|
|
#include "gtest-qt-printing.h"
|
|
|
|
namespace {
|
|
|
|
using ClangBackEnd::ClangCodeCompleteResults;
|
|
using ClangBackEnd::FilePath;
|
|
using ClangBackEnd::TranslationUnit;
|
|
using ClangBackEnd::UnsavedFiles;
|
|
using ClangBackEnd::ProjectPart;
|
|
|
|
TEST(ClangCodeCompleteResults, GetData)
|
|
{
|
|
ProjectPart projectPart(Utf8StringLiteral("projectPartId"));
|
|
ClangBackEnd::ProjectParts projects;
|
|
ClangBackEnd::UnsavedFiles unsavedFiles;
|
|
ClangBackEnd::TranslationUnits translationUnits{projects, unsavedFiles};
|
|
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
|
|
projectPart,
|
|
Utf8StringVector(),
|
|
translationUnits);
|
|
Utf8String nativeFilePath = FilePath::toNativeSeparators(translationUnit.filePath());
|
|
CXCodeCompleteResults *cxCodeCompleteResults = clang_codeCompleteAt(translationUnit.cxTranslationUnit(), nativeFilePath.constData(), 49, 1, 0, 0, 0);
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
ASSERT_THAT(codeCompleteResults.data(), cxCodeCompleteResults);
|
|
}
|
|
|
|
TEST(ClangCodeCompleteResults, GetInvalidData)
|
|
{
|
|
CXCodeCompleteResults *cxCodeCompleteResults = clang_codeCompleteAt(nullptr, "file.cpp", 49, 1, 0, 0, 0);
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
ASSERT_THAT(codeCompleteResults.data(), cxCodeCompleteResults);
|
|
}
|
|
|
|
TEST(ClangCodeCompleteResults, MoveClangCodeCompleteResults)
|
|
{
|
|
ProjectPart projectPart(Utf8StringLiteral("projectPartId"));
|
|
ClangBackEnd::ProjectParts projects;
|
|
ClangBackEnd::UnsavedFiles unsavedFiles;
|
|
ClangBackEnd::TranslationUnits translationUnits{projects, unsavedFiles};
|
|
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
|
|
projectPart,
|
|
Utf8StringVector(),
|
|
translationUnits);
|
|
Utf8String nativeFilePath = FilePath::toNativeSeparators(translationUnit.filePath());
|
|
CXCodeCompleteResults *cxCodeCompleteResults = clang_codeCompleteAt(translationUnit.cxTranslationUnit(), nativeFilePath.constData(), 49, 1, 0, 0, 0);
|
|
|
|
ClangCodeCompleteResults codeCompleteResults(cxCodeCompleteResults);
|
|
|
|
const ClangCodeCompleteResults codeCompleteResults2 = std::move(codeCompleteResults);
|
|
|
|
ASSERT_TRUE(codeCompleteResults.isNull());
|
|
ASSERT_FALSE(codeCompleteResults2.isNull());
|
|
}
|
|
|
|
}
|