forked from qt-creator/qt-creator
Set the path to clang-format after connecting with the path chooser,
otherwise setting the initial enabled state breaks.
Broke when inline the ui file.
Amends 4933697d9a
Fixes: QTCREATORBUG-28297
Change-Id: I4c6ff7c4515edf13569cf5cd125623005f2967ad
Reviewed-by: hjk <hjk@qt.io>
144 lines
4.8 KiB
C++
144 lines
4.8 KiB
C++
// Copyright (C) 2016 Lorenz Haas
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0+ OR GPL-3.0 WITH Qt-GPL-exception-1.0
|
|
|
|
#include "clangformatoptionspage.h"
|
|
|
|
#include "clangformatconstants.h"
|
|
#include "clangformatsettings.h"
|
|
|
|
#include "../beautifierconstants.h"
|
|
#include "../beautifierplugin.h"
|
|
#include "../configurationpanel.h"
|
|
|
|
#include <utils/layoutbuilder.h>
|
|
#include <utils/pathchooser.h>
|
|
|
|
#include <QComboBox>
|
|
#include <QGroupBox>
|
|
#include <QLabel>
|
|
#include <QLineEdit>
|
|
#include <QRadioButton>
|
|
#include <QSpacerItem>
|
|
|
|
namespace Beautifier::Internal {
|
|
|
|
class ClangFormatOptionsPageWidget : public Core::IOptionsPageWidget
|
|
{
|
|
Q_DECLARE_TR_FUNCTIONS(Beautifier::Internal::ClangFormat)
|
|
|
|
public:
|
|
explicit ClangFormatOptionsPageWidget(ClangFormatSettings *settings);
|
|
|
|
void apply() final;
|
|
|
|
private:
|
|
ClangFormatSettings *m_settings;
|
|
ConfigurationPanel *m_configurations;
|
|
QRadioButton *m_usePredefinedStyle;
|
|
QComboBox *m_predefinedStyle;
|
|
QComboBox *m_fallbackStyle;
|
|
Utils::PathChooser *m_command;
|
|
QLineEdit *m_mime;
|
|
};
|
|
|
|
ClangFormatOptionsPageWidget::ClangFormatOptionsPageWidget(ClangFormatSettings *settings)
|
|
: m_settings(settings)
|
|
{
|
|
auto options = new QGroupBox(tr("Options"));
|
|
options->setEnabled(false);
|
|
|
|
auto useCustomizedStyle = new QRadioButton(tr("Use customized style:"));
|
|
useCustomizedStyle->setAutoExclusive(true);
|
|
|
|
m_configurations = new ConfigurationPanel;
|
|
m_configurations->setSettings(m_settings);
|
|
m_configurations->setCurrentConfiguration(m_settings->customStyle());
|
|
|
|
m_usePredefinedStyle = new QRadioButton(tr("Use predefined style:"));
|
|
|
|
m_usePredefinedStyle->setChecked(true);
|
|
m_usePredefinedStyle->setAutoExclusive(true);
|
|
|
|
m_predefinedStyle = new QComboBox;
|
|
m_predefinedStyle->addItems(m_settings->predefinedStyles());
|
|
const int predefinedStyleIndex = m_predefinedStyle->findText(m_settings->predefinedStyle());
|
|
if (predefinedStyleIndex != -1)
|
|
m_predefinedStyle->setCurrentIndex(predefinedStyleIndex);
|
|
|
|
m_fallbackStyle = new QComboBox;
|
|
m_fallbackStyle->addItems(m_settings->fallbackStyles());
|
|
m_fallbackStyle->setEnabled(false);
|
|
const int fallbackStyleIndex = m_fallbackStyle->findText(m_settings->fallbackStyle());
|
|
if (fallbackStyleIndex != -1)
|
|
m_fallbackStyle->setCurrentIndex(fallbackStyleIndex);
|
|
|
|
m_mime = new QLineEdit(m_settings->supportedMimeTypesAsString());
|
|
|
|
m_command = new Utils::PathChooser;
|
|
m_command->setExpectedKind(Utils::PathChooser::ExistingCommand);
|
|
m_command->setCommandVersionArguments({"--version"});
|
|
m_command->setPromptDialogTitle(
|
|
BeautifierPlugin::msgCommandPromptDialogTitle("Clang Format"));
|
|
|
|
if (m_settings->usePredefinedStyle())
|
|
m_usePredefinedStyle->setChecked(true);
|
|
else
|
|
useCustomizedStyle->setChecked(true);
|
|
|
|
using namespace Utils::Layouting;
|
|
|
|
Form {
|
|
m_usePredefinedStyle, m_predefinedStyle, br,
|
|
empty, Row { tr("Fallback style:"), m_fallbackStyle }, br,
|
|
useCustomizedStyle, m_configurations, br,
|
|
}.attachTo(options);
|
|
|
|
Column {
|
|
Group {
|
|
title(tr("Configuration")),
|
|
Form {
|
|
tr("Clang Format command:"), m_command, br,
|
|
tr("Restrict to MIME types:"), m_mime
|
|
}
|
|
},
|
|
options,
|
|
st
|
|
}.attachTo(this);
|
|
|
|
connect(m_command, &Utils::PathChooser::validChanged, options, &QWidget::setEnabled);
|
|
connect(m_predefinedStyle, &QComboBox::currentTextChanged, this, [this](const QString &item) {
|
|
m_fallbackStyle->setEnabled(item == "File");
|
|
});
|
|
connect(m_usePredefinedStyle, &QRadioButton::toggled, this, [this](bool checked) {
|
|
m_fallbackStyle->setEnabled(checked && m_predefinedStyle->currentText() == "File");
|
|
m_predefinedStyle->setEnabled(checked);
|
|
});
|
|
|
|
// might trigger PathChooser::validChanged, so so after the connect above
|
|
m_command->setFilePath(m_settings->command());
|
|
}
|
|
|
|
void ClangFormatOptionsPageWidget::apply()
|
|
{
|
|
m_settings->setCommand(m_command->filePath().toString());
|
|
m_settings->setSupportedMimeTypes(m_mime->text());
|
|
m_settings->setUsePredefinedStyle(m_usePredefinedStyle->isChecked());
|
|
m_settings->setPredefinedStyle(m_predefinedStyle->currentText());
|
|
m_settings->setFallbackStyle(m_fallbackStyle->currentText());
|
|
m_settings->setCustomStyle(m_configurations->currentConfiguration());
|
|
m_settings->save();
|
|
|
|
// update since not all MIME types are accepted (invalids or duplicates)
|
|
m_mime->setText(m_settings->supportedMimeTypesAsString());
|
|
}
|
|
|
|
ClangFormatOptionsPage::ClangFormatOptionsPage(ClangFormatSettings *settings)
|
|
{
|
|
setId("ClangFormat");
|
|
setDisplayName(ClangFormatOptionsPageWidget::tr("Clang Format"));
|
|
setCategory(Constants::OPTION_CATEGORY);
|
|
setWidgetCreator([settings] { return new ClangFormatOptionsPageWidget(settings); });
|
|
}
|
|
|
|
} // Beautifier::Internal
|