feedc0de/scheincommander
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor improvements

Browse Source
This commit is contained in:
0xFEEDC0DE64
2023-02-18 21:42:50 +01:00
parent e56172f7de
commit a5bf5ec154
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
DevicesSettingsPage.qml
View File

@ -70,13 +70,13 @@ ColumnLayout {
SpinBox { SpinBox {
enabled: false enabled: false
Layout.fillWidth: true Layout.fillWidth: true
value: listView.currentData.id value: listView.currentData ? listView.currentData.id : -1
onValueModified: listView.currentData.id = value onValueModified: listView.currentData.id = value
} }
Label { text: qsTr("Name:") } Label { text: qsTr("Name:") }
TextField { TextField {
Layout.fillWidth: true Layout.fillWidth: true
text: listView.currentData.name text: listView.currentData ? listView.currentData.name : ''
onTextEdited: listView.currentData.name = text onTextEdited: listView.currentData.name = text
} }
Label { text: qsTr("DeviceType:") } Label { text: qsTr("DeviceType:") }
@ -92,12 +92,12 @@ ColumnLayout {
Label { text: qsTr("Address:") } Label { text: qsTr("Address:") }
SpinBox { SpinBox {
Layout.fillWidth: true Layout.fillWidth: true
value: listView.currentData.address value: listView.currentData ? listView.currentData.address : -1
onValueModified: listView.currentData.address = value onValueModified: listView.currentData.address = value
} }
Label { text: qsTr("Position:") } Label { text: qsTr("Position:") }
Vector3DField { Vector3DField {
id: test id: positionField
Layout.fillWidth: true Layout.fillWidth: true
onValueModified: listView.currentData.position = value; onValueModified: listView.currentData.position = value;
// TODO solve without onCurrentDataChanged // TODO solve without onCurrentDataChanged

2
RegistersSettingsItem.qml
View File

@ -31,7 +31,7 @@ Pane {
model: deviceTypeRegistersModel model: deviceTypeRegistersModel
onAddClicked: (index) => deviceTypeRegistersModel.insertRow(index < 0 ? 0 : index + 1); onAddClicked: (index) => { const newIndex = index < 0 ? 0 : index + 1; if (deviceTypeRegistersModel.insertRow(newIndex)) currentIndex = newIndex; else console.warn('failed'); }
onRemoveClicked: (index) => deviceTypeRegistersModel.removeRow(index) onRemoveClicked: (index) => deviceTypeRegistersModel.removeRow(index)
} }
} }