diff --git a/src/Proxy.cpp b/src/Proxy.cpp index 8a760ca..1b0c1db 100644 --- a/src/Proxy.cpp +++ b/src/Proxy.cpp @@ -120,7 +120,7 @@ PendingAsyncCall Proxy::callMethod(const MethodCall& message, async_reply_handle SDBUS_THROW_ERROR_IF(!message.isValid(), "Invalid async method call message provided", EINVAL); auto callback = (void*)&Proxy::sdbus_async_reply_handler; - auto callData = std::make_shared(AsyncCalls::CallData{*this, std::move(asyncReplyCallback), {}}); + auto callData = std::make_shared(AsyncCalls::CallData{*this, std::move(asyncReplyCallback), {}, AsyncCalls::CallData::State::RUNNING}); auto weakData = std::weak_ptr{callData}; callData->slot = message.send(callback, callData.get(), timeout); @@ -162,7 +162,7 @@ MethodReply Proxy::sendMethodCallMessageAndWaitForReply(const MethodCall& messag syncCallReplyData.sendMethodReplyToWaitingThread(reply, error); }; auto callback = (void*)&Proxy::sdbus_async_reply_handler; - AsyncCalls::CallData callData{*this, std::move(asyncReplyCallback), {}}; + AsyncCalls::CallData callData{*this, std::move(asyncReplyCallback), {}, AsyncCalls::CallData::State::NOT_ASYNC}; message.send(callback, &callData, timeout, floating_slot); @@ -275,14 +275,16 @@ int Proxy::sdbus_async_reply_handler(sd_bus_message *sdbusMessage, void *userDat assert(asyncCallData != nullptr); assert(asyncCallData->callback); auto& proxy = asyncCallData->proxy; + auto state = asyncCallData->state; // We are removing the CallData item at the complete scope exit, after the callback has been invoked. // We can't do it earlier (before callback invocation for example), because CallBack data (slot release) // is the synchronization point between callback invocation and Proxy::unregister. SCOPE_EXIT { - // Remove call meta-data if it's a real async call (a sync call done in terms of async has slot == nullptr) - proxy.pendingAsyncCalls_.removeCall(asyncCallData); + // Remove call meta-data if it's a real async call (a sync call done in terms of async has STATE_NOT_ASYNC) + if (state != AsyncCalls::CallData::State::NOT_ASYNC) + proxy.pendingAsyncCalls_.removeCall(asyncCallData); }; auto message = Message::Factory::create(sdbusMessage, &proxy.connection_->getSdBusInterface()); diff --git a/src/Proxy.h b/src/Proxy.h index f11f059..3208084 100644 --- a/src/Proxy.h +++ b/src/Proxy.h @@ -135,10 +135,16 @@ namespace sdbus::internal { public: struct CallData { + enum class State + { NOT_ASYNC + , RUNNING + , FINISHED + }; + Proxy& proxy; async_reply_handler callback; Slot slot; - bool finished { false }; + State state; }; ~AsyncCalls() @@ -149,14 +155,14 @@ namespace sdbus::internal { void addCall(std::shared_ptr asyncCallData) { std::lock_guard lock(mutex_); - if (!asyncCallData->finished) // The call may have finished in the mean time + if (asyncCallData->state != CallData::State::FINISHED) // The call may have finished in the meantime calls_.emplace_back(std::move(asyncCallData)); } void removeCall(CallData* data) { std::unique_lock lock(mutex_); - data->finished = true; + data->state = CallData::State::FINISHED; if (auto it = std::find_if(calls_.begin(), calls_.end(), [data](auto const& entry){ return entry.get() == data; }); it != calls_.end()) { auto callData = std::move(*it);