From 9da18aec25a6a5d84cb145f0201793452abb0cd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanislav=20Angelovi=C4=8D?= Date: Tue, 31 Oct 2023 15:54:49 +0100 Subject: [PATCH] chore: remove obsolete TODO comments --- include/sdbus-c++/Types.h | 2 +- src/Proxy.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sdbus-c++/Types.h b/include/sdbus-c++/Types.h index 6d25c28..9633f73 100644 --- a/include/sdbus-c++/Types.h +++ b/include/sdbus-c++/Types.h @@ -56,7 +56,7 @@ namespace sdbus { Variant(); template - /*explicit*/ Variant(const _ValueType& value) // TODO: Mark explicit in new major version so we don't break client code within v1 + Variant(const _ValueType& value) : Variant() { msg_.openVariant(signature_of<_ValueType>::str()); diff --git a/src/Proxy.cpp b/src/Proxy.cpp index 1b0c1db..983cffe 100644 --- a/src/Proxy.cpp +++ b/src/Proxy.cpp @@ -143,7 +143,7 @@ std::future Proxy::callMethod(const MethodCall& message, uint64_t t async_reply_handler asyncReplyCallback = [promise = std::move(promise)](MethodReply& reply, const Error* error) noexcept { if (error == nullptr) - promise->set_value(reply); // TODO: std::move? Can't move now because currently processed message. TODO: Refactor + promise->set_value(reply); else promise->set_exception(std::make_exception_ptr(*error)); };