feedc0de/sdbus-cpp
1
0
Fork 0
forked from Kistler-Group/sdbus-cpp
Code Pull Requests Activity

Fix potential data race in Proxy's condition variable

Browse Source
This commit is contained in:
Stanislav Angelovic
2020-06-16 17:43:29 +02:00
committed by Stanislav Angelovič
parent a0dadcc6fe
commit c137dfa213
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Proxy.cpp
View File

@ -127,8 +127,8 @@ MethodReply Proxy::sendMethodCallMessageAndWaitForReply(const MethodCall& messag
void Proxy::SyncCallReplyData::sendMethodReplyToWaitingThread(MethodReply& reply, const Error* error) void Proxy::SyncCallReplyData::sendMethodReplyToWaitingThread(MethodReply& reply, const Error* error)
{ {
SCOPE_EXIT{ cond_.notify_one(); };
std::unique_lock lock{mutex_}; std::unique_lock lock{mutex_};
SCOPE_EXIT{ cond_.notify_one(); }; // This must happen before unlocking the mutex to avoid potential data race on spurious wakeup in the waiting thread
SCOPE_EXIT{ arrived_ = true; }; SCOPE_EXIT{ arrived_ = true; };
//error_ = nullptr; // Necessary if SyncCallReplyData instance is thread_local //error_ = nullptr; // Necessary if SyncCallReplyData instance is thread_local