This makes the library more robust and prone to user's errors when the user writes an extension for their custom type. In case they forget to implement a serialization function for that type and yet insert an object of that type into sdbus::Message, the current behavior is that, surprisingly, the library masks the error as it resolves the call to the Variant overload, because Variant provides an implicit template converting constructor, so the library tries to construct first the Variant object from the object of custom type, and then inserting into the message that Variant object. Variant constructor serializes the underlying object into its internal message object, which resolves to the same message insertion overload, creating an infinite recursion and ultimately the stack overflow. This is undesired and plain wrong. Marking this Variant converting constructor solves these problems, plus in overall it makes the code a little safer and more verbose. With explicit Variant constructor, when the user forgets to implement a serialization function for their type, the call of such function will fail with an expressive compilation error, and will produce no undesired, surprising results.
Signatures of callbacks async_reply_handler, signal_handler, message_handler and property_set_callback were modified to take input message objects by value, as opposed to non-const ref.
The callee assumes ownership of the message. This API is more idiomatic, more expressive, cleaner and safer. Move semantics is used to pass messages to the callback handlers. In some cases, this also improves performance.
* Add preliminary changes for async server methods
* Refactor the Message concept and break it into distinctive types
* Continue working on async server methods (high-level API mainly)
* Continue developing support for async server
* Finishing async server methods
* Finishing async server methods (fixing tests & cleaning up)
* A little code cleaning
* Add unit tests for type traits of free functions
* Support for generating async server methods in stub headers
* Update ChangeLog for v0.3.0
* Update the tutorial with how to use async server-side methods
* Update the TOC in sdbus-c++ tutorial
* Update numbering in TOC
* Remove unnecessary code
* Final cleanups
Stanislav Angelovič
Stanislav Angelovic
Urs Ritzmann
riuriuriu
Stanislav Angelovič
Lukas Durfina
Stanislav Angelovic