From 1ca56f97a4a0f474f2c3ece7acc36c30d4b62102 Mon Sep 17 00:00:00 2001 From: David Garske Date: Mon, 5 Feb 2018 11:03:19 -0800 Subject: [PATCH 1/2] Fix warning with pointer compare to zero for IPV6 `peer == INADDR_ANY` in test.h. Fixes issue #1350. --- wolfssl/test.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wolfssl/test.h b/wolfssl/test.h index b771d76b2..7cc695856 100644 --- a/wolfssl/test.h +++ b/wolfssl/test.h @@ -695,8 +695,9 @@ static INLINE void build_addr(SOCKADDR_IN_T* addr, const char* peer, #else addr->sin6_family = AF_INET_V; addr->sin6_port = XHTONS(port); - if (peer == INADDR_ANY) + if ((size_t)peer != INADDR_ANY) { addr->sin6_addr = in6addr_any; + } else { #ifdef HAVE_GETADDRINFO struct addrinfo hints; From b3b3a2861655e4ea3fca08d2aa2d9eda86153ef9 Mon Sep 17 00:00:00 2001 From: David Garske Date: Tue, 6 Feb 2018 09:18:42 -0800 Subject: [PATCH 2/2] Fix logic typo for IPV6 any addr. --- wolfssl/test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wolfssl/test.h b/wolfssl/test.h index 7cc695856..500afc524 100644 --- a/wolfssl/test.h +++ b/wolfssl/test.h @@ -695,7 +695,7 @@ static INLINE void build_addr(SOCKADDR_IN_T* addr, const char* peer, #else addr->sin6_family = AF_INET_V; addr->sin6_port = XHTONS(port); - if ((size_t)peer != INADDR_ANY) { + if ((size_t)peer == INADDR_ANY) { addr->sin6_addr = in6addr_any; } else {