feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

wolfcrypt/src/sp_int.c: catch and propagate errors from sp_init_size() in sp_invmod() and sp_gcd() to fix clang-analyzer-core.UndefinedBinaryOperatorResult.

Browse Source
This commit is contained in:
Daniel Pouzzner
2022-09-17 12:55:48 -05:00
parent 02cc7bf82e
commit 0fc80f5f85
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
wolfcrypt/src/sp_int.c
View File

@@ -10600,11 +10600,16 @@ int sp_invmod(sp_int* a, sp_int* m, sp_int* r)
else if (err != MP_OKAY) { else if (err != MP_OKAY) {
} }
else { else {
sp_init_size(u, m->used + 1); err = sp_init_size(u, m->used + 1);
sp_init_size(v, m->used + 1); if (err == MP_OKAY)
sp_init_size(b, m->used + 1); err = sp_init_size(v, m->used + 1);
sp_init_size(c, 2 * m->used + 1); if (err == MP_OKAY)
err = sp_init_size(b, m->used + 1);
if (err == MP_OKAY)
err = sp_init_size(c, 2 * m->used + 1);
}
if ((err == MP_OKAY) && !sp_isone(a)) {
if (sp_iseven(m)) { if (sp_iseven(m)) {
/* a^-1 mod m = m + ((1 - m*(m^-1 % a)) / a) */ /* a^-1 mod m = m + ((1 - m*(m^-1 % a)) / a) */
mm = a; mm = a;
@@ -16363,10 +16368,14 @@ int sp_gcd(sp_int* a, sp_int* b, sp_int* r)
u = d[0]; u = d[0];
v = d[1]; v = d[1];
t = d[2]; t = d[2];
sp_init_size(u, used); err = sp_init_size(u, used);
sp_init_size(v, used); }
sp_init_size(t, used); if (err == MP_OKAY)
err = sp_init_size(v, used);
if (err == MP_OKAY)
err = sp_init_size(t, used);
if (err == MP_OKAY) {
if (_sp_cmp(a, b) != MP_LT) { if (_sp_cmp(a, b) != MP_LT) {
sp_copy(b, u); sp_copy(b, u);
/* First iteration - u = a, v = b */ /* First iteration - u = a, v = b */