feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

cppcheck: fixes

Browse Source 
CBIORecv/Send are only assigned once.
IOCB_ReadCtx/WriteCtx only assigned once.
BuildMessage checks output and input wiht sizeOnly every call - state
machine doesn't cache these.
Renamed alias_tbl variables to something unique.
Other cppcheck fixes.
Also reworked pem_read_bio_key().
This commit is contained in:
Sean Parkinson
2022-04-12 12:45:02 +10:00
parent e87ded85b4
commit 20e5e654a3
10 changed files with 199 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api.c
+6 -5
View File
@@ -7302,7 +7302,7 @@ static void test_wolfSSL_UseSNI_connection(void)
XMEMSET(&server_cb, 0, sizeof(callback_functions));
client_cb.method = wolfSSLv23_client_method;
server_cb.method = wolfSSLv23_server_method;
server_cb.devId = devId;
client_cb.devId = devId;
server_cb.devId = devId;
/* success case at ctx */
@@ -7338,6 +7338,7 @@ static void test_wolfSSL_UseSNI_connection(void)
/* sni abort - abort when absent (ctx) */
client_cb.ctx_ready = NULL; client_cb.ssl_ready = NULL; client_cb.on_result = verify_FATAL_ERROR_on_client;
server_cb.ctx_ready = use_MANDATORY_SNI_at_ctx; server_cb.ssl_ready = NULL; server_cb.on_result = verify_SNI_ABSENT_on_server;
test_wolfSSL_client_server(&client_cb, &server_cb);
/* sni abort - abort when absent (ssl) */
client_cb.ctx_ready = NULL; client_cb.ssl_ready = NULL; client_cb.on_result = verify_FATAL_ERROR_on_client;
@@ -7831,7 +7832,7 @@ static void test_wolfSSL_UseALPN_connection(void)
XMEMSET(&server_cb, 0, sizeof(callback_functions));
client_cb.method = wolfSSLv23_client_method;
server_cb.method = wolfSSLv23_server_method;
server_cb.devId = devId;
client_cb.devId = devId;
server_cb.devId = devId;
/* success case same list */
@@ -8031,7 +8032,7 @@ static void test_wolfSSL_set_alpn_protos(void)
XMEMSET(&server_cb, 0, sizeof(callback_functions));
client_cb.method = wolfSSLv23_client_method;
server_cb.method = wolfSSLv23_server_method;
server_cb.devId = devId;
client_cb.devId = devId;
server_cb.devId = devId;
/* use CTX_alpn_protos */
@@ -30365,8 +30366,8 @@ static void test_wc_GetPubKeyDerFromCert(void)
byte certBuf[6000]; /* for PEM and CSR, client-cert.pem is 5-6kB */
word32 certBufSz = sizeof(certBuf);
#endif
#if (!defined(USE_CERT_BUFFERS_2048) && !defined(USE_CERT_BUFFERS_1024)) || \
defined(WOLFSSL_CERT_REQ)
#if ((!defined(USE_CERT_BUFFERS_2048) && !defined(USE_CERT_BUFFERS_1024)) || \
defined(WOLFSSL_CERT_REQ)) && !defined(NO_RSA)
XFILE fp;
#endif
#ifndef NO_RSA