feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

RSA padding - no pad length check fix

Browse Source 
Perform correct length check of input bytes based on bits in key in
wc_RsaPad_ex when no padding to be done.
This commit is contained in:
Sean Parkinson
2023-02-27 15:05:50 +10:00
parent 47aad3fedb
commit 2a33f24dc9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wolfcrypt/src/rsa.c
View File

@ -1580,11 +1580,14 @@ int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock,
#ifdef WC_RSA_NO_PADDING #ifdef WC_RSA_NO_PADDING
case WC_RSA_NO_PAD: case WC_RSA_NO_PAD:
{
int bytes = (bits + WOLFSSL_BIT_SIZE - 1) / WOLFSSL_BIT_SIZE;
WOLFSSL_MSG("wolfSSL Using NO padding"); WOLFSSL_MSG("wolfSSL Using NO padding");
/* In the case of no padding being used check that input is exactly /* In the case of no padding being used check that input is exactly
* the RSA key length */ * the RSA key length */
if (bits <= 0 || inputLen != ((word32)bits/WOLFSSL_BIT_SIZE)) { if ((bits <= 0) || (inputLen != (word32)bytes)) {
WOLFSSL_MSG("Bad input size"); WOLFSSL_MSG("Bad input size");
ret = RSA_PAD_E; ret = RSA_PAD_E;
} }
@ -1593,6 +1596,7 @@ int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock,
ret = 0; ret = 0;
} }
break; break;
}
#endif #endif
default: default: